diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:20 -0500 |
commit | 90ab5ee94171b3e28de6bb42ee30b527014e0be7 (patch) | |
tree | fcf89889f6e881f2b231d3d20287c08174ce4b54 /drivers/pci | |
parent | 476bc0015bf09dad39d36a8b19f76f0c181d1ec9 (diff) |
module_param: make bool parameters really bool (drivers & misc)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'drivers/pci')
-rw-r--r-- | drivers/pci/hotplug/acpi_pcihp.c | 2 | ||||
-rw-r--r-- | drivers/pci/hotplug/acpiphp_core.c | 2 | ||||
-rw-r--r-- | drivers/pci/hotplug/acpiphp_ibm.c | 2 | ||||
-rw-r--r-- | drivers/pci/hotplug/cpcihp_zt5550.c | 4 | ||||
-rw-r--r-- | drivers/pci/hotplug/cpqphp_core.c | 4 | ||||
-rw-r--r-- | drivers/pci/hotplug/ibmphp_core.c | 2 | ||||
-rw-r--r-- | drivers/pci/hotplug/pci_hotplug_core.c | 2 | ||||
-rw-r--r-- | drivers/pci/hotplug/pciehp.h | 6 | ||||
-rw-r--r-- | drivers/pci/hotplug/pciehp_core.c | 6 | ||||
-rw-r--r-- | drivers/pci/hotplug/pcihp_skeleton.c | 2 | ||||
-rw-r--r-- | drivers/pci/hotplug/rpaphp.h | 2 | ||||
-rw-r--r-- | drivers/pci/hotplug/rpaphp_core.c | 2 | ||||
-rw-r--r-- | drivers/pci/hotplug/shpchp.h | 4 | ||||
-rw-r--r-- | drivers/pci/hotplug/shpchp_core.c | 4 | ||||
-rw-r--r-- | drivers/pci/pcie/aer/aer_inject.c | 2 | ||||
-rw-r--r-- | drivers/pci/pcie/aer/aerdrv_core.c | 4 |
16 files changed, 25 insertions, 25 deletions
diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c index 095f29e13734..2a47e82821da 100644 --- a/drivers/pci/hotplug/acpi_pcihp.c +++ b/drivers/pci/hotplug/acpi_pcihp.c | |||
@@ -44,7 +44,7 @@ | |||
44 | #define METHOD_NAME__SUN "_SUN" | 44 | #define METHOD_NAME__SUN "_SUN" |
45 | #define METHOD_NAME_OSHP "OSHP" | 45 | #define METHOD_NAME_OSHP "OSHP" |
46 | 46 | ||
47 | static int debug_acpi; | 47 | static bool debug_acpi; |
48 | 48 | ||
49 | static acpi_status | 49 | static acpi_status |
50 | decode_type0_hpx_record(union acpi_object *record, struct hotplug_params *hpx) | 50 | decode_type0_hpx_record(union acpi_object *record, struct hotplug_params *hpx) |
diff --git a/drivers/pci/hotplug/acpiphp_core.c b/drivers/pci/hotplug/acpiphp_core.c index efa9f2de51c1..aa41631e9e02 100644 --- a/drivers/pci/hotplug/acpiphp_core.c +++ b/drivers/pci/hotplug/acpiphp_core.c | |||
@@ -47,7 +47,7 @@ | |||
47 | /* name size which is used for entries in pcihpfs */ | 47 | /* name size which is used for entries in pcihpfs */ |
48 | #define SLOT_NAME_SIZE 21 /* {_SUN} */ | 48 | #define SLOT_NAME_SIZE 21 /* {_SUN} */ |
49 | 49 | ||
50 | static int debug; | 50 | static bool debug; |
51 | int acpiphp_debug; | 51 | int acpiphp_debug; |
52 | 52 | ||
53 | /* local variables */ | 53 | /* local variables */ |
diff --git a/drivers/pci/hotplug/acpiphp_ibm.c b/drivers/pci/hotplug/acpiphp_ibm.c index e525263210ee..c35e8ad6db01 100644 --- a/drivers/pci/hotplug/acpiphp_ibm.c +++ b/drivers/pci/hotplug/acpiphp_ibm.c | |||
@@ -43,7 +43,7 @@ | |||
43 | #define DRIVER_AUTHOR "Irene Zubarev <zubarev@us.ibm.com>, Vernon Mauery <vernux@us.ibm.com>" | 43 | #define DRIVER_AUTHOR "Irene Zubarev <zubarev@us.ibm.com>, Vernon Mauery <vernux@us.ibm.com>" |
44 | #define DRIVER_DESC "ACPI Hot Plug PCI Controller Driver IBM extension" | 44 | #define DRIVER_DESC "ACPI Hot Plug PCI Controller Driver IBM extension" |
45 | 45 | ||
46 | static int debug; | 46 | static bool debug; |
47 | 47 | ||
48 | MODULE_AUTHOR(DRIVER_AUTHOR); | 48 | MODULE_AUTHOR(DRIVER_AUTHOR); |
49 | MODULE_DESCRIPTION(DRIVER_DESC); | 49 | MODULE_DESCRIPTION(DRIVER_DESC); |
diff --git a/drivers/pci/hotplug/cpcihp_zt5550.c b/drivers/pci/hotplug/cpcihp_zt5550.c index 41f6a8d79c81..6bf8d2ab164f 100644 --- a/drivers/pci/hotplug/cpcihp_zt5550.c +++ b/drivers/pci/hotplug/cpcihp_zt5550.c | |||
@@ -57,8 +57,8 @@ | |||
57 | #define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg) | 57 | #define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg) |
58 | 58 | ||
59 | /* local variables */ | 59 | /* local variables */ |
60 | static int debug; | 60 | static bool debug; |
61 | static int poll; | 61 | static bool poll; |
62 | static struct cpci_hp_controller_ops zt5550_hpc_ops; | 62 | static struct cpci_hp_controller_ops zt5550_hpc_ops; |
63 | static struct cpci_hp_controller zt5550_hpc; | 63 | static struct cpci_hp_controller zt5550_hpc; |
64 | 64 | ||
diff --git a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c index f1ce99cceac6..187a199da93c 100644 --- a/drivers/pci/hotplug/cpqphp_core.c +++ b/drivers/pci/hotplug/cpqphp_core.c | |||
@@ -57,8 +57,8 @@ struct irq_routing_table *cpqhp_routing_table; | |||
57 | static void __iomem *smbios_table; | 57 | static void __iomem *smbios_table; |
58 | static void __iomem *smbios_start; | 58 | static void __iomem *smbios_start; |
59 | static void __iomem *cpqhp_rom_start; | 59 | static void __iomem *cpqhp_rom_start; |
60 | static int power_mode; | 60 | static bool power_mode; |
61 | static int debug; | 61 | static bool debug; |
62 | static int initialized; | 62 | static int initialized; |
63 | 63 | ||
64 | #define DRIVER_VERSION "0.9.8" | 64 | #define DRIVER_VERSION "0.9.8" |
diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c index d934dd4fa873..5506e0e8fbc0 100644 --- a/drivers/pci/hotplug/ibmphp_core.c +++ b/drivers/pci/hotplug/ibmphp_core.c | |||
@@ -49,7 +49,7 @@ | |||
49 | 49 | ||
50 | int ibmphp_debug; | 50 | int ibmphp_debug; |
51 | 51 | ||
52 | static int debug; | 52 | static bool debug; |
53 | module_param(debug, bool, S_IRUGO | S_IWUSR); | 53 | module_param(debug, bool, S_IRUGO | S_IWUSR); |
54 | MODULE_PARM_DESC (debug, "Debugging mode enabled or not"); | 54 | MODULE_PARM_DESC (debug, "Debugging mode enabled or not"); |
55 | MODULE_LICENSE ("GPL"); | 55 | MODULE_LICENSE ("GPL"); |
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c index 6d2eea93298f..202f4a969eb5 100644 --- a/drivers/pci/hotplug/pci_hotplug_core.c +++ b/drivers/pci/hotplug/pci_hotplug_core.c | |||
@@ -51,7 +51,7 @@ | |||
51 | 51 | ||
52 | 52 | ||
53 | /* local variables */ | 53 | /* local variables */ |
54 | static int debug; | 54 | static bool debug; |
55 | 55 | ||
56 | #define DRIVER_VERSION "0.5" | 56 | #define DRIVER_VERSION "0.5" |
57 | #define DRIVER_AUTHOR "Greg Kroah-Hartman <greg@kroah.com>, Scott Murray <scottm@somanetworks.com>" | 57 | #define DRIVER_AUTHOR "Greg Kroah-Hartman <greg@kroah.com>, Scott Murray <scottm@somanetworks.com>" |
diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h index 9a33fdde2d16..4b7cce1de6ec 100644 --- a/drivers/pci/hotplug/pciehp.h +++ b/drivers/pci/hotplug/pciehp.h | |||
@@ -40,10 +40,10 @@ | |||
40 | 40 | ||
41 | #define MY_NAME "pciehp" | 41 | #define MY_NAME "pciehp" |
42 | 42 | ||
43 | extern int pciehp_poll_mode; | 43 | extern bool pciehp_poll_mode; |
44 | extern int pciehp_poll_time; | 44 | extern int pciehp_poll_time; |
45 | extern int pciehp_debug; | 45 | extern bool pciehp_debug; |
46 | extern int pciehp_force; | 46 | extern bool pciehp_force; |
47 | extern struct workqueue_struct *pciehp_wq; | 47 | extern struct workqueue_struct *pciehp_wq; |
48 | 48 | ||
49 | #define dbg(format, arg...) \ | 49 | #define dbg(format, arg...) \ |
diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index b8c99d35ac97..365c6b96c642 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c | |||
@@ -38,10 +38,10 @@ | |||
38 | #include <linux/time.h> | 38 | #include <linux/time.h> |
39 | 39 | ||
40 | /* Global variables */ | 40 | /* Global variables */ |
41 | int pciehp_debug; | 41 | bool pciehp_debug; |
42 | int pciehp_poll_mode; | 42 | bool pciehp_poll_mode; |
43 | int pciehp_poll_time; | 43 | int pciehp_poll_time; |
44 | int pciehp_force; | 44 | bool pciehp_force; |
45 | struct workqueue_struct *pciehp_wq; | 45 | struct workqueue_struct *pciehp_wq; |
46 | 46 | ||
47 | #define DRIVER_VERSION "0.4" | 47 | #define DRIVER_VERSION "0.4" |
diff --git a/drivers/pci/hotplug/pcihp_skeleton.c b/drivers/pci/hotplug/pcihp_skeleton.c index 5175d9b26f0b..b20ceaaa31f4 100644 --- a/drivers/pci/hotplug/pcihp_skeleton.c +++ b/drivers/pci/hotplug/pcihp_skeleton.c | |||
@@ -59,7 +59,7 @@ static LIST_HEAD(slot_list); | |||
59 | #define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg) | 59 | #define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg) |
60 | 60 | ||
61 | /* local variables */ | 61 | /* local variables */ |
62 | static int debug; | 62 | static bool debug; |
63 | static int num_slots; | 63 | static int num_slots; |
64 | 64 | ||
65 | #define DRIVER_VERSION "0.3" | 65 | #define DRIVER_VERSION "0.3" |
diff --git a/drivers/pci/hotplug/rpaphp.h b/drivers/pci/hotplug/rpaphp.h index 419919a87b0f..df5677440a08 100644 --- a/drivers/pci/hotplug/rpaphp.h +++ b/drivers/pci/hotplug/rpaphp.h | |||
@@ -46,7 +46,7 @@ | |||
46 | #define PRESENT 1 /* Card in slot */ | 46 | #define PRESENT 1 /* Card in slot */ |
47 | 47 | ||
48 | #define MY_NAME "rpaphp" | 48 | #define MY_NAME "rpaphp" |
49 | extern int rpaphp_debug; | 49 | extern bool rpaphp_debug; |
50 | #define dbg(format, arg...) \ | 50 | #define dbg(format, arg...) \ |
51 | do { \ | 51 | do { \ |
52 | if (rpaphp_debug) \ | 52 | if (rpaphp_debug) \ |
diff --git a/drivers/pci/hotplug/rpaphp_core.c b/drivers/pci/hotplug/rpaphp_core.c index 758adb5f47fd..127d6e600185 100644 --- a/drivers/pci/hotplug/rpaphp_core.c +++ b/drivers/pci/hotplug/rpaphp_core.c | |||
@@ -37,7 +37,7 @@ | |||
37 | /* and pci_do_scan_bus */ | 37 | /* and pci_do_scan_bus */ |
38 | #include "rpaphp.h" | 38 | #include "rpaphp.h" |
39 | 39 | ||
40 | int rpaphp_debug; | 40 | bool rpaphp_debug; |
41 | LIST_HEAD(rpaphp_slot_head); | 41 | LIST_HEAD(rpaphp_slot_head); |
42 | 42 | ||
43 | #define DRIVER_VERSION "0.1" | 43 | #define DRIVER_VERSION "0.1" |
diff --git a/drivers/pci/hotplug/shpchp.h b/drivers/pci/hotplug/shpchp.h index e0c90e643b5f..ca64932e658b 100644 --- a/drivers/pci/hotplug/shpchp.h +++ b/drivers/pci/hotplug/shpchp.h | |||
@@ -43,9 +43,9 @@ | |||
43 | #define MY_NAME THIS_MODULE->name | 43 | #define MY_NAME THIS_MODULE->name |
44 | #endif | 44 | #endif |
45 | 45 | ||
46 | extern int shpchp_poll_mode; | 46 | extern bool shpchp_poll_mode; |
47 | extern int shpchp_poll_time; | 47 | extern int shpchp_poll_time; |
48 | extern int shpchp_debug; | 48 | extern bool shpchp_debug; |
49 | extern struct workqueue_struct *shpchp_wq; | 49 | extern struct workqueue_struct *shpchp_wq; |
50 | extern struct workqueue_struct *shpchp_ordered_wq; | 50 | extern struct workqueue_struct *shpchp_ordered_wq; |
51 | 51 | ||
diff --git a/drivers/pci/hotplug/shpchp_core.c b/drivers/pci/hotplug/shpchp_core.c index dd7e0c51a33e..7414fd9ad1d2 100644 --- a/drivers/pci/hotplug/shpchp_core.c +++ b/drivers/pci/hotplug/shpchp_core.c | |||
@@ -36,8 +36,8 @@ | |||
36 | #include "shpchp.h" | 36 | #include "shpchp.h" |
37 | 37 | ||
38 | /* Global variables */ | 38 | /* Global variables */ |
39 | int shpchp_debug; | 39 | bool shpchp_debug; |
40 | int shpchp_poll_mode; | 40 | bool shpchp_poll_mode; |
41 | int shpchp_poll_time; | 41 | int shpchp_poll_time; |
42 | struct workqueue_struct *shpchp_wq; | 42 | struct workqueue_struct *shpchp_wq; |
43 | struct workqueue_struct *shpchp_ordered_wq; | 43 | struct workqueue_struct *shpchp_ordered_wq; |
diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c index 95489cd9a555..52229863e9fe 100644 --- a/drivers/pci/pcie/aer/aer_inject.c +++ b/drivers/pci/pcie/aer/aer_inject.c | |||
@@ -28,7 +28,7 @@ | |||
28 | #include "aerdrv.h" | 28 | #include "aerdrv.h" |
29 | 29 | ||
30 | /* Override the existing corrected and uncorrected error masks */ | 30 | /* Override the existing corrected and uncorrected error masks */ |
31 | static int aer_mask_override; | 31 | static bool aer_mask_override; |
32 | module_param(aer_mask_override, bool, 0); | 32 | module_param(aer_mask_override, bool, 0); |
33 | 33 | ||
34 | struct aer_error_inj { | 34 | struct aer_error_inj { |
diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c index 9674e9f30d49..0ca053538146 100644 --- a/drivers/pci/pcie/aer/aerdrv_core.c +++ b/drivers/pci/pcie/aer/aerdrv_core.c | |||
@@ -27,8 +27,8 @@ | |||
27 | #include <linux/kfifo.h> | 27 | #include <linux/kfifo.h> |
28 | #include "aerdrv.h" | 28 | #include "aerdrv.h" |
29 | 29 | ||
30 | static int forceload; | 30 | static bool forceload; |
31 | static int nosourceid; | 31 | static bool nosourceid; |
32 | module_param(forceload, bool, 0); | 32 | module_param(forceload, bool, 0); |
33 | module_param(nosourceid, bool, 0); | 33 | module_param(nosourceid, bool, 0); |
34 | 34 | ||