diff options
author | Sudip Mukherjee <sudipm.mukherjee@gmail.com> | 2015-10-28 05:11:38 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-01-03 19:32:59 -0500 |
commit | b95b9d6cdecabfd99e074d6fda51dc962fd2a1cf (patch) | |
tree | 9fd99a1bfb9fb2cb362dfc45fd7376779a3da6a0 /drivers/parport | |
parent | 47ec57ec0e52839b92066567e6eb02fb1e60e603 (diff) |
parport: change style of NULL comparison
checkpatch was complaining about NULL comparisons.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/parport')
-rw-r--r-- | drivers/parport/share.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/parport/share.c b/drivers/parport/share.c index 441333bd4839..ccd7df458ebc 100644 --- a/drivers/parport/share.c +++ b/drivers/parport/share.c | |||
@@ -738,11 +738,11 @@ parport_register_device(struct parport *port, const char *name, | |||
738 | parport_get_port (port); | 738 | parport_get_port (port); |
739 | 739 | ||
740 | tmp = kmalloc(sizeof(struct pardevice), GFP_KERNEL); | 740 | tmp = kmalloc(sizeof(struct pardevice), GFP_KERNEL); |
741 | if (tmp == NULL) | 741 | if (!tmp) |
742 | goto out; | 742 | goto out; |
743 | 743 | ||
744 | tmp->state = kmalloc(sizeof(struct parport_state), GFP_KERNEL); | 744 | tmp->state = kmalloc(sizeof(struct parport_state), GFP_KERNEL); |
745 | if (tmp->state == NULL) | 745 | if (!tmp->state) |
746 | goto out_free_pardevice; | 746 | goto out_free_pardevice; |
747 | 747 | ||
748 | tmp->name = name; | 748 | tmp->name = name; |
@@ -971,7 +971,7 @@ void parport_unregister_device(struct pardevice *dev) | |||
971 | struct parport *port; | 971 | struct parport *port; |
972 | 972 | ||
973 | #ifdef PARPORT_PARANOID | 973 | #ifdef PARPORT_PARANOID |
974 | if (dev == NULL) { | 974 | if (!dev) { |
975 | printk(KERN_ERR "parport_unregister_device: passed NULL\n"); | 975 | printk(KERN_ERR "parport_unregister_device: passed NULL\n"); |
976 | return; | 976 | return; |
977 | } | 977 | } |
@@ -1345,7 +1345,7 @@ void parport_release(struct pardevice *dev) | |||
1345 | * interested in being woken up. (Note: no locking required) | 1345 | * interested in being woken up. (Note: no locking required) |
1346 | */ | 1346 | */ |
1347 | /* !!! LOCKING IS NEEDED HERE */ | 1347 | /* !!! LOCKING IS NEEDED HERE */ |
1348 | for (pd = port->devices; (port->cad == NULL) && pd; pd = pd->next) { | 1348 | for (pd = port->devices; !port->cad && pd; pd = pd->next) { |
1349 | if (pd->wakeup && pd != dev) | 1349 | if (pd->wakeup && pd != dev) |
1350 | pd->wakeup(pd->private); | 1350 | pd->wakeup(pd->private); |
1351 | } | 1351 | } |