diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-07-06 05:26:52 -0400 |
---|---|---|
committer | Sagi Grimberg <sagi@grimberg.me> | 2017-07-10 02:09:58 -0400 |
commit | 2ee0e4ed5ca24c0642a7b72d75b4fe6dfc0a8db8 (patch) | |
tree | 6b04e8d1d7ea90fb04bc2ac69488faa9ad3edcbf /drivers/nvme/host/pci.c | |
parent | 4cb7ca8073e1f226487168155c9a887079d605e4 (diff) |
nvme-pci: compile warnings in nvme_alloc_host_mem()
"i" should be signed or it could cause a forever loop on the cleanup
path. "size" can be used uninitialized.
Fixes: 87ad72a59a38 ("nvme-pci: implement host memory buffer support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Diffstat (limited to 'drivers/nvme/host/pci.c')
-rw-r--r-- | drivers/nvme/host/pci.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index 882ed3677117..73fddf2c99f9 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c | |||
@@ -1582,9 +1582,10 @@ static void nvme_free_host_mem(struct nvme_dev *dev) | |||
1582 | static int nvme_alloc_host_mem(struct nvme_dev *dev, u64 min, u64 preferred) | 1582 | static int nvme_alloc_host_mem(struct nvme_dev *dev, u64 min, u64 preferred) |
1583 | { | 1583 | { |
1584 | struct nvme_host_mem_buf_desc *descs; | 1584 | struct nvme_host_mem_buf_desc *descs; |
1585 | u32 chunk_size, max_entries, i = 0; | 1585 | u32 chunk_size, max_entries; |
1586 | int i = 0; | ||
1586 | void **bufs; | 1587 | void **bufs; |
1587 | u64 size, tmp; | 1588 | u64 size = 0, tmp; |
1588 | 1589 | ||
1589 | /* start big and work our way down */ | 1590 | /* start big and work our way down */ |
1590 | chunk_size = min(preferred, (u64)PAGE_SIZE << MAX_ORDER); | 1591 | chunk_size = min(preferred, (u64)PAGE_SIZE << MAX_ORDER); |