diff options
author | Christophe Ricard <christophe.ricard@gmail.com> | 2016-04-30 03:12:44 -0400 |
---|---|---|
committer | Samuel Ortiz <sameo@linux.intel.com> | 2016-05-03 19:36:24 -0400 |
commit | 070718a499cea9e6d7e6404788490574dfb71388 (patch) | |
tree | 95b9fc8abc06ace6743a73f2bb924766a4c95b01 /drivers/nfc | |
parent | 7cb6ab590d7d203b53284f4f211d4a8a89a125fc (diff) |
NFC: st21nfca: Drop two useless checks in ACPI probe path
When st21nfca_hci_i2c_acpi_request_resources() gets called we
already know that the entries in ->acpi_match_table have matched
ACPI ID of the device.
In addition I2C client pointer cannot be NULL in any case
(otherwise I2C core would not call ->probe() for the driver in
the first place).
Drop the two useless checks from the driver.
Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'drivers/nfc')
-rw-r--r-- | drivers/nfc/st21nfca/i2c.c | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index a3153a30be5d..5a82f553906c 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c | |||
@@ -507,21 +507,10 @@ static struct nfc_phy_ops i2c_phy_ops = { | |||
507 | static int st21nfca_hci_i2c_acpi_request_resources(struct i2c_client *client) | 507 | static int st21nfca_hci_i2c_acpi_request_resources(struct i2c_client *client) |
508 | { | 508 | { |
509 | struct st21nfca_i2c_phy *phy = i2c_get_clientdata(client); | 509 | struct st21nfca_i2c_phy *phy = i2c_get_clientdata(client); |
510 | const struct acpi_device_id *id; | ||
511 | struct gpio_desc *gpiod_ena; | 510 | struct gpio_desc *gpiod_ena; |
512 | struct device *dev; | 511 | struct device *dev = &client->dev; |
513 | u8 tmp; | 512 | u8 tmp; |
514 | 513 | ||
515 | if (!client) | ||
516 | return -EINVAL; | ||
517 | |||
518 | dev = &client->dev; | ||
519 | |||
520 | /* Match the struct device against a given list of ACPI IDs */ | ||
521 | id = acpi_match_device(dev->driver->acpi_match_table, dev); | ||
522 | if (!id) | ||
523 | return -ENODEV; | ||
524 | |||
525 | /* Get EN GPIO from ACPI */ | 514 | /* Get EN GPIO from ACPI */ |
526 | gpiod_ena = devm_gpiod_get_index(dev, ST21NFCA_GPIO_NAME_EN, 1, | 515 | gpiod_ena = devm_gpiod_get_index(dev, ST21NFCA_GPIO_NAME_EN, 1, |
527 | GPIOD_OUT_LOW); | 516 | GPIOD_OUT_LOW); |