aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2017-01-13 11:39:24 -0500
committerDavid S. Miller <davem@davemloft.net>2017-01-16 11:44:10 -0500
commit8cf699ec849f4ca1413cea01289bd7d37dbcc626 (patch)
treead2b0afac883e5613962f92d571d0365111e1f14 /drivers/net
parent507191952406c90290fb605ebd4ebfe34b7303b9 (diff)
mlx4: do not call napi_schedule() without care
Disable BH around the call to napi_schedule() to avoid following warning [ 52.095499] NOHZ: local_softirq_pending 08 [ 52.421291] NOHZ: local_softirq_pending 08 [ 52.608313] NOHZ: local_softirq_pending 08 Fixes: 8d59de8f7bb3 ("net/mlx4_en: Process all completions in RX rings after port goes up") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Erez Shitrit <erezsh@mellanox.com> Cc: Eugenia Emantayev <eugenia@mellanox.com> Cc: Tariq Toukan <tariqt@mellanox.com> Acked-by: Tariq Toukan <tariqt@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r--drivers/net/ethernet/mellanox/mlx4/en_netdev.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 4910d9af1933..761f8b12399c 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -1748,8 +1748,11 @@ int mlx4_en_start_port(struct net_device *dev)
1748 /* Process all completions if exist to prevent 1748 /* Process all completions if exist to prevent
1749 * the queues freezing if they are full 1749 * the queues freezing if they are full
1750 */ 1750 */
1751 for (i = 0; i < priv->rx_ring_num; i++) 1751 for (i = 0; i < priv->rx_ring_num; i++) {
1752 local_bh_disable();
1752 napi_schedule(&priv->rx_cq[i]->napi); 1753 napi_schedule(&priv->rx_cq[i]->napi);
1754 local_bh_enable();
1755 }
1753 1756
1754 netif_tx_start_all_queues(dev); 1757 netif_tx_start_all_queues(dev);
1755 netif_device_attach(dev); 1758 netif_device_attach(dev);