diff options
| author | Shannon Nelson <shannon.nelson@oracle.com> | 2017-05-15 13:51:08 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-05-15 15:36:08 -0400 |
| commit | 8b671f906c2debc4f2393438c4e7668936522e99 (patch) | |
| tree | af9a39f437355719c399dcb18ee70427c3818142 /drivers/net | |
| parent | b18e5e86b44be0dca399d8e2383f97c8077392ce (diff) | |
ldmvsw: stop the clean timer at beginning of remove
Stop the clean timer earlier to be sure there's no asynchronous
interference while stopping the port.
Orabug: 25748241
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/sun/ldmvsw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c index 309747c7b8ae..5b56c24b6ed2 100644 --- a/drivers/net/ethernet/sun/ldmvsw.c +++ b/drivers/net/ethernet/sun/ldmvsw.c | |||
| @@ -411,6 +411,7 @@ static int vsw_port_remove(struct vio_dev *vdev) | |||
| 411 | 411 | ||
| 412 | if (port) { | 412 | if (port) { |
| 413 | del_timer_sync(&port->vio.timer); | 413 | del_timer_sync(&port->vio.timer); |
| 414 | del_timer_sync(&port->clean_timer); | ||
| 414 | 415 | ||
| 415 | napi_disable(&port->napi); | 416 | napi_disable(&port->napi); |
| 416 | unregister_netdev(port->dev); | 417 | unregister_netdev(port->dev); |
| @@ -418,7 +419,6 @@ static int vsw_port_remove(struct vio_dev *vdev) | |||
| 418 | list_del_rcu(&port->list); | 419 | list_del_rcu(&port->list); |
| 419 | 420 | ||
| 420 | synchronize_rcu(); | 421 | synchronize_rcu(); |
| 421 | del_timer_sync(&port->clean_timer); | ||
| 422 | spin_lock_irqsave(&port->vp->lock, flags); | 422 | spin_lock_irqsave(&port->vp->lock, flags); |
| 423 | sunvnet_port_rm_txq_common(port); | 423 | sunvnet_port_rm_txq_common(port); |
| 424 | spin_unlock_irqrestore(&port->vp->lock, flags); | 424 | spin_unlock_irqrestore(&port->vp->lock, flags); |
