diff options
author | Karicheri, Muralidharan <m-karicheri2@ti.com> | 2017-01-13 09:32:34 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-01-16 13:29:51 -0500 |
commit | 34c55cf2fc75f8bf6ba87df321038c064cf2d426 (patch) | |
tree | d395ae855b879a856a754a6eb66d7a77259856d8 /drivers/net | |
parent | 02ca0423fd65a0a9c4d70da0dbb8f4b8503f08c7 (diff) |
net: phy: dp83867: allow RGMII_TXID/RGMII_RXID interface types
Currently dp83867 driver returns error if phy interface type
PHY_INTERFACE_MODE_RGMII_RXID is used to set the rx only internal
delay. Similarly issue happens for PHY_INTERFACE_MODE_RGMII_TXID.
Fix this by checking also the interface type if a particular delay
value is missing in the phy dt bindings. Also update the DT document
accordingly.
Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
-rw-r--r-- | drivers/net/phy/dp83867.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index e84ae084e259..ca1b462bf7b2 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c | |||
@@ -132,12 +132,16 @@ static int dp83867_of_init(struct phy_device *phydev) | |||
132 | 132 | ||
133 | ret = of_property_read_u32(of_node, "ti,rx-internal-delay", | 133 | ret = of_property_read_u32(of_node, "ti,rx-internal-delay", |
134 | &dp83867->rx_id_delay); | 134 | &dp83867->rx_id_delay); |
135 | if (ret) | 135 | if (ret && |
136 | (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID || | ||
137 | phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)) | ||
136 | return ret; | 138 | return ret; |
137 | 139 | ||
138 | ret = of_property_read_u32(of_node, "ti,tx-internal-delay", | 140 | ret = of_property_read_u32(of_node, "ti,tx-internal-delay", |
139 | &dp83867->tx_id_delay); | 141 | &dp83867->tx_id_delay); |
140 | if (ret) | 142 | if (ret && |
143 | (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID || | ||
144 | phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID)) | ||
141 | return ret; | 145 | return ret; |
142 | 146 | ||
143 | return of_property_read_u32(of_node, "ti,fifo-depth", | 147 | return of_property_read_u32(of_node, "ti,fifo-depth", |