rtlwifi: Use mutex to replace spin_lock to protect IPS and LPS

Enter/leavel IPS and LPS are large critical section, and they can't use
sleep function because running in atomic-context, which own a spin_lock.
In commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save"), it moves
LPS functions to thread-context, so this commit can simply change LPS's
spin lock to mutex.
Considering IPS functions, rtl_ips_nic_on() may be called by TX tasklet
(softirq-context) that check whether packet is auth frame. Fortunately,
current mac80211 will ask driver to leave IPS using op_config with
changed flag IEEE80211_CONF_CHANGE_IDLE, before issuing auth frame, so
IPS functions can run in thread-context and use mutex to protect critical
section, too.
Also, this commit removes some useless spin locks.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

1 files changed, 2 insertions, 4 deletions

diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
index 0ba9c0cc95e1..89ec318598ea 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -551,7 +551,8 @@ int rtl_init_core(struct ieee80211_hw *hw)
 
         /* <4> locks */
         mutex_init(&rtlpriv->locks.conf_mutex);
-        spin_lock_init(&rtlpriv->locks.ips_lock);
+        mutex_init(&rtlpriv->locks.ips_mutex);
+        mutex_init(&rtlpriv->locks.lps_mutex);
         spin_lock_init(&rtlpriv->locks.irq_th_lock);
         spin_lock_init(&rtlpriv->locks.h2c_lock);
         spin_lock_init(&rtlpriv->locks.rf_ps_lock);
@@ -561,9 +562,7 @@ int rtl_init_core(struct ieee80211_hw *hw)
         spin_lock_init(&rtlpriv->locks.c2hcmd_lock);
         spin_lock_init(&rtlpriv->locks.scan_list_lock);
         spin_lock_init(&rtlpriv->locks.cck_and_rw_pagea_lock);
-        spin_lock_init(&rtlpriv->locks.check_sendpkt_lock);
         spin_lock_init(&rtlpriv->locks.fw_ps_lock);
-        spin_lock_init(&rtlpriv->locks.lps_lock);
         spin_lock_init(&rtlpriv->locks.iqk_lock);
         /* <5> init list */
         INIT_LIST_HEAD(&rtlpriv->entry_list);
@@ -1229,7 +1228,6 @@ bool rtl_tx_mgmt_proc(struct ieee80211_hw *hw, struct sk_buff *skb)
         }
         if (ieee80211_is_auth(fc)) {
                 RT_TRACE(rtlpriv, COMP_SEND, DBG_DMESG, "MAC80211_LINKING\n");
-                rtl_ips_nic_on(hw);
 
                 mac->link_state = MAC80211_LINKING;
                 /* Dul mac */