diff options
| author | Emmanuel Grumbach <emmanuel.grumbach@intel.com> | 2011-08-26 02:11:03 -0400 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2011-08-29 15:25:34 -0400 |
| commit | effcea16e554b4d7497bbcfc80b9baca8e017691 (patch) | |
| tree | 2ca7952d5d1fe33b1b91df06da62d9e54a3a102d /drivers/net/wireless/iwlwifi/iwl-trans.c | |
| parent | 105183b156b7c220b47c3162e087101a0a6abc9f (diff) | |
iwlagn: fix the check of IWLAGN_FIRST_AMPDU_QUEUE
BUILD_BUG_ON(ARRAY_SIZE(iwlagn_ipan_queue_to_tx_fifo) !=
IWLAGN_FIRST_AMPDU_QUEUE);
This check can be buggy. IWLAGN_FIRST_AMPDU_QUEUE has to be greater than the
ARRAY_SIZE of iwlagn_ipan_queue_to_tx_fifo.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/iwlwifi/iwl-trans.c')
| -rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-trans.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans.c b/drivers/net/wireless/iwlwifi/iwl-trans.c index 0e04b51e7f79..a2950a4cc35c 100644 --- a/drivers/net/wireless/iwlwifi/iwl-trans.c +++ b/drivers/net/wireless/iwlwifi/iwl-trans.c | |||
| @@ -875,9 +875,9 @@ static void iwl_trans_pcie_tx_start(struct iwl_priv *priv) | |||
| 875 | /* reset to 0 to enable all the queue first */ | 875 | /* reset to 0 to enable all the queue first */ |
| 876 | priv->txq_ctx_active_msk = 0; | 876 | priv->txq_ctx_active_msk = 0; |
| 877 | 877 | ||
| 878 | BUILD_BUG_ON(ARRAY_SIZE(iwlagn_default_queue_to_tx_fifo) != | 878 | BUILD_BUG_ON(ARRAY_SIZE(iwlagn_default_queue_to_tx_fifo) < |
| 879 | IWLAGN_FIRST_AMPDU_QUEUE); | 879 | IWLAGN_FIRST_AMPDU_QUEUE); |
| 880 | BUILD_BUG_ON(ARRAY_SIZE(iwlagn_ipan_queue_to_tx_fifo) != | 880 | BUILD_BUG_ON(ARRAY_SIZE(iwlagn_ipan_queue_to_tx_fifo) < |
| 881 | IWLAGN_FIRST_AMPDU_QUEUE); | 881 | IWLAGN_FIRST_AMPDU_QUEUE); |
| 882 | 882 | ||
| 883 | for (i = 0; i < IWLAGN_FIRST_AMPDU_QUEUE; i++) { | 883 | for (i = 0; i < IWLAGN_FIRST_AMPDU_QUEUE; i++) { |