diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2019-01-29 07:23:05 -0500 |
|---|---|---|
| committer | Luca Coelho <luciano.coelho@intel.com> | 2019-02-20 13:47:57 -0500 |
| commit | cad7eb754dbd8e921e481b0a41ee0596016afa2f (patch) | |
| tree | 277b89129e85c293cb627b9238c27dfb76f03975 /drivers/net/wireless/intel | |
| parent | a371bb646ff72f7ea13bdb920b2353b34f9d45b5 (diff) | |
iwlwifi: mvm: remove IWL_MVM_INIT_STATUS_REG_HW_INIT_COMPLETE
There's no point in this, we already do everything in a nested
fashion, and if we didn't we'd already crash in iwl_mvm_leds_exit()
etc. Just remove the bit.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Diffstat (limited to 'drivers/net/wireless/intel')
| -rw-r--r-- | drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 5 | ||||
| -rw-r--r-- | drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | 1 | ||||
| -rw-r--r-- | drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 5 |
3 files changed, 2 insertions, 9 deletions
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c index a585ee509987..24556a7cd29c 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | |||
| @@ -803,12 +803,9 @@ int iwl_mvm_mac_setup_register(struct iwl_mvm *mvm) | |||
| 803 | ret = ieee80211_register_hw(mvm->hw); | 803 | ret = ieee80211_register_hw(mvm->hw); |
| 804 | if (ret) { | 804 | if (ret) { |
| 805 | iwl_mvm_leds_exit(mvm); | 805 | iwl_mvm_leds_exit(mvm); |
| 806 | return ret; | ||
| 807 | } | 806 | } |
| 808 | 807 | ||
| 809 | mvm->init_status |= IWL_MVM_INIT_STATUS_REG_HW_INIT_COMPLETE; | 808 | return ret; |
| 810 | |||
| 811 | return 0; | ||
| 812 | } | 809 | } |
| 813 | 810 | ||
| 814 | static bool iwl_mvm_defer_tx(struct iwl_mvm *mvm, | 811 | static bool iwl_mvm_defer_tx(struct iwl_mvm *mvm, |
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h index 148aee1ad79d..bca6f6b536d9 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mvm.h | |||
| @@ -1221,7 +1221,6 @@ enum iwl_mvm_status { | |||
| 1221 | enum iwl_mvm_init_status { | 1221 | enum iwl_mvm_init_status { |
| 1222 | IWL_MVM_INIT_STATUS_THERMAL_INIT_COMPLETE = BIT(0), | 1222 | IWL_MVM_INIT_STATUS_THERMAL_INIT_COMPLETE = BIT(0), |
| 1223 | IWL_MVM_INIT_STATUS_LEDS_INIT_COMPLETE = BIT(1), | 1223 | IWL_MVM_INIT_STATUS_LEDS_INIT_COMPLETE = BIT(1), |
| 1224 | IWL_MVM_INIT_STATUS_REG_HW_INIT_COMPLETE = BIT(2), | ||
| 1225 | }; | 1224 | }; |
| 1226 | 1225 | ||
| 1227 | static inline bool iwl_mvm_is_radio_killed(struct iwl_mvm *mvm) | 1226 | static inline bool iwl_mvm_is_radio_killed(struct iwl_mvm *mvm) |
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c index 0996c97c4b94..ba27dce4c2bb 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c | |||
| @@ -919,10 +919,7 @@ static void iwl_op_mode_mvm_stop(struct iwl_op_mode *op_mode) | |||
| 919 | 919 | ||
| 920 | iwl_mvm_thermal_exit(mvm); | 920 | iwl_mvm_thermal_exit(mvm); |
| 921 | 921 | ||
| 922 | if (mvm->init_status & IWL_MVM_INIT_STATUS_REG_HW_INIT_COMPLETE) { | 922 | ieee80211_unregister_hw(mvm->hw); |
| 923 | ieee80211_unregister_hw(mvm->hw); | ||
| 924 | mvm->init_status &= ~IWL_MVM_INIT_STATUS_REG_HW_INIT_COMPLETE; | ||
| 925 | } | ||
| 926 | 923 | ||
| 927 | kfree(mvm->scan_cmd); | 924 | kfree(mvm->scan_cmd); |
| 928 | kfree(mvm->mcast_filter_cmd); | 925 | kfree(mvm->mcast_filter_cmd); |
