aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/intel/iwlegacy/debug.c
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2018-03-23 18:54:37 -0400
committerKalle Valo <kvalo@codeaurora.org>2018-03-27 04:01:13 -0400
commit2ef00c53049b6a8758d118188992da01d75f3628 (patch)
treef7eb61964d5504c7d5c8bc7f675fd1fe810eb7f9 /drivers/net/wireless/intel/iwlegacy/debug.c
parent255dd5b79d5474dad3ecebe99be7818684921abd (diff)
wireless: Use octal not symbolic permissions
Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/intel/iwlegacy/debug.c')
-rw-r--r--drivers/net/wireless/intel/iwlegacy/debug.c58
1 files changed, 28 insertions, 30 deletions
diff --git a/drivers/net/wireless/intel/iwlegacy/debug.c b/drivers/net/wireless/intel/iwlegacy/debug.c
index 6fc6b7ff9849..d76073def677 100644
--- a/drivers/net/wireless/intel/iwlegacy/debug.c
+++ b/drivers/net/wireless/intel/iwlegacy/debug.c
@@ -135,16 +135,14 @@ EXPORT_SYMBOL(il_update_stats);
135 135
136#define DEBUGFS_ADD_BOOL(name, parent, ptr) do { \ 136#define DEBUGFS_ADD_BOOL(name, parent, ptr) do { \
137 struct dentry *__tmp; \ 137 struct dentry *__tmp; \
138 __tmp = debugfs_create_bool(#name, S_IWUSR | S_IRUSR, \ 138 __tmp = debugfs_create_bool(#name, 0600, parent, ptr); \
139 parent, ptr); \
140 if (IS_ERR(__tmp) || !__tmp) \ 139 if (IS_ERR(__tmp) || !__tmp) \
141 goto err; \ 140 goto err; \
142} while (0) 141} while (0)
143 142
144#define DEBUGFS_ADD_X32(name, parent, ptr) do { \ 143#define DEBUGFS_ADD_X32(name, parent, ptr) do { \
145 struct dentry *__tmp; \ 144 struct dentry *__tmp; \
146 __tmp = debugfs_create_x32(#name, S_IWUSR | S_IRUSR, \ 145 __tmp = debugfs_create_x32(#name, 0600, parent, ptr); \
147 parent, ptr); \
148 if (IS_ERR(__tmp) || !__tmp) \ 146 if (IS_ERR(__tmp) || !__tmp) \
149 goto err; \ 147 goto err; \
150} while (0) 148} while (0)
@@ -1365,35 +1363,35 @@ il_dbgfs_register(struct il_priv *il, const char *name)
1365 if (!dir_debug) 1363 if (!dir_debug)
1366 goto err; 1364 goto err;
1367 1365
1368 DEBUGFS_ADD_FILE(nvm, dir_data, S_IRUSR); 1366 DEBUGFS_ADD_FILE(nvm, dir_data, 0400);
1369 DEBUGFS_ADD_FILE(sram, dir_data, S_IWUSR | S_IRUSR); 1367 DEBUGFS_ADD_FILE(sram, dir_data, 0600);
1370 DEBUGFS_ADD_FILE(stations, dir_data, S_IRUSR); 1368 DEBUGFS_ADD_FILE(stations, dir_data, 0400);
1371 DEBUGFS_ADD_FILE(channels, dir_data, S_IRUSR); 1369 DEBUGFS_ADD_FILE(channels, dir_data, 0400);
1372 DEBUGFS_ADD_FILE(status, dir_data, S_IRUSR); 1370 DEBUGFS_ADD_FILE(status, dir_data, 0400);
1373 DEBUGFS_ADD_FILE(interrupt, dir_data, S_IWUSR | S_IRUSR); 1371 DEBUGFS_ADD_FILE(interrupt, dir_data, 0600);
1374 DEBUGFS_ADD_FILE(qos, dir_data, S_IRUSR); 1372 DEBUGFS_ADD_FILE(qos, dir_data, 0400);
1375 DEBUGFS_ADD_FILE(disable_ht40, dir_data, S_IWUSR | S_IRUSR); 1373 DEBUGFS_ADD_FILE(disable_ht40, dir_data, 0600);
1376 DEBUGFS_ADD_FILE(rx_stats, dir_debug, S_IRUSR); 1374 DEBUGFS_ADD_FILE(rx_stats, dir_debug, 0400);
1377 DEBUGFS_ADD_FILE(tx_stats, dir_debug, S_IRUSR); 1375 DEBUGFS_ADD_FILE(tx_stats, dir_debug, 0400);
1378 DEBUGFS_ADD_FILE(rx_queue, dir_debug, S_IRUSR); 1376 DEBUGFS_ADD_FILE(rx_queue, dir_debug, 0400);
1379 DEBUGFS_ADD_FILE(tx_queue, dir_debug, S_IRUSR); 1377 DEBUGFS_ADD_FILE(tx_queue, dir_debug, 0400);
1380 DEBUGFS_ADD_FILE(power_save_status, dir_debug, S_IRUSR); 1378 DEBUGFS_ADD_FILE(power_save_status, dir_debug, 0400);
1381 DEBUGFS_ADD_FILE(clear_ucode_stats, dir_debug, S_IWUSR); 1379 DEBUGFS_ADD_FILE(clear_ucode_stats, dir_debug, 0200);
1382 DEBUGFS_ADD_FILE(clear_traffic_stats, dir_debug, S_IWUSR); 1380 DEBUGFS_ADD_FILE(clear_traffic_stats, dir_debug, 0200);
1383 DEBUGFS_ADD_FILE(fh_reg, dir_debug, S_IRUSR); 1381 DEBUGFS_ADD_FILE(fh_reg, dir_debug, 0400);
1384 DEBUGFS_ADD_FILE(missed_beacon, dir_debug, S_IWUSR); 1382 DEBUGFS_ADD_FILE(missed_beacon, dir_debug, 0200);
1385 DEBUGFS_ADD_FILE(force_reset, dir_debug, S_IWUSR | S_IRUSR); 1383 DEBUGFS_ADD_FILE(force_reset, dir_debug, 0600);
1386 DEBUGFS_ADD_FILE(ucode_rx_stats, dir_debug, S_IRUSR); 1384 DEBUGFS_ADD_FILE(ucode_rx_stats, dir_debug, 0400);
1387 DEBUGFS_ADD_FILE(ucode_tx_stats, dir_debug, S_IRUSR); 1385 DEBUGFS_ADD_FILE(ucode_tx_stats, dir_debug, 0400);
1388 DEBUGFS_ADD_FILE(ucode_general_stats, dir_debug, S_IRUSR); 1386 DEBUGFS_ADD_FILE(ucode_general_stats, dir_debug, 0400);
1389 1387
1390 if (il->cfg->sensitivity_calib_by_driver) 1388 if (il->cfg->sensitivity_calib_by_driver)
1391 DEBUGFS_ADD_FILE(sensitivity, dir_debug, S_IRUSR); 1389 DEBUGFS_ADD_FILE(sensitivity, dir_debug, 0400);
1392 if (il->cfg->chain_noise_calib_by_driver) 1390 if (il->cfg->chain_noise_calib_by_driver)
1393 DEBUGFS_ADD_FILE(chain_noise, dir_debug, S_IRUSR); 1391 DEBUGFS_ADD_FILE(chain_noise, dir_debug, 0400);
1394 DEBUGFS_ADD_FILE(rxon_flags, dir_debug, S_IWUSR); 1392 DEBUGFS_ADD_FILE(rxon_flags, dir_debug, 0200);
1395 DEBUGFS_ADD_FILE(rxon_filter_flags, dir_debug, S_IWUSR); 1393 DEBUGFS_ADD_FILE(rxon_filter_flags, dir_debug, 0200);
1396 DEBUGFS_ADD_FILE(wd_timeout, dir_debug, S_IWUSR); 1394 DEBUGFS_ADD_FILE(wd_timeout, dir_debug, 0200);
1397 if (il->cfg->sensitivity_calib_by_driver) 1395 if (il->cfg->sensitivity_calib_by_driver)
1398 DEBUGFS_ADD_BOOL(disable_sensitivity, dir_rf, 1396 DEBUGFS_ADD_BOOL(disable_sensitivity, dir_rf,
1399 &il->disable_sens_cal); 1397 &il->disable_sens_cal);