ath9k: Switch to using mac80211 intermediate software queues.

This switches ath9k over to using the mac80211 intermediate software
queueing mechanism for data packets. It removes the queueing inside the
driver, except for the retry queue, and instead pulls from mac80211 when
a packet is needed. The retry queue is used to store a packet that was
pulled but can't be sent immediately.

The old code path in ath_tx_start that would queue packets has been
removed completely, as has the qlen limit tunables (since there's no
longer a queue in the driver to limit).

The mac80211 intermediate software queues offer significant latency
reductions, and this patch allows ath9k to realise them. The exact gains
from this varies with the test scenario, but in an access point scenario
we have seen latency reductions ranging from 1/3 to as much as an order
of magnitude. We also achieve slightly better aggregation.

Median latency (ping) figures with this patch applied at the access point,
with two high-rate stations and one low-rate station (HT20 5Ghz), running
a Flent rtt_fair_var_up test with one TCP flow and one ping flow going to
each station:

                                 Fast station        Slow station
Default pfifo_fast qdisc:            430.4 ms            638.7 ms
fq_codel qdisc on iface:              35.5 ms            211.8 ms
This patch set:                       22.4 ms             38.2 ms

Median aggregation sizes over the same test:

Default pfifo_fast qdisc:            9.5 pkts            1.9 pkts
fq_codel qdisc on iface:            11.2 pkts            1.9 pkts
This patch set:                     13.9 pkts            1.9 pkts

This patch is based on Tim's original patch set, but reworked quite
thoroughly.

Cc: Tim Shepard <shep@alum.mit.edu>
Cc: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>

1 files changed, 1 insertions, 13 deletions

diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c
index c56e40ff35e5..89a94dd5f2cb 100644
--- a/drivers/net/wireless/ath/ath9k/debug.c
+++ b/drivers/net/wireless/ath/ath9k/debug.c
@@ -600,7 +600,6 @@ static int read_file_xmit(struct seq_file *file, void *data)
         PR("MPDUs XRetried:  ", xretries);
         PR("Aggregates:      ", a_aggr);
         PR("AMPDUs Queued HW:", a_queued_hw);
-        PR("AMPDUs Queued SW:", a_queued_sw);
         PR("AMPDUs Completed:", a_completed);
         PR("AMPDUs Retried:  ", a_retries);
         PR("AMPDUs XRetried: ", a_xretries);
@@ -629,8 +628,7 @@ static void print_queue(struct ath_softc *sc, struct ath_txq *txq,
         seq_printf(file, "%s: %d ", "qnum", txq->axq_qnum);
         seq_printf(file, "%s: %2d ", "qdepth", txq->axq_depth);
         seq_printf(file, "%s: %2d ", "ampdu-depth", txq->axq_ampdu_depth);
-        seq_printf(file, "%s: %3d ", "pending", txq->pending_frames);
-        seq_printf(file, "%s: %d\n", "stopped", txq->stopped);
+        seq_printf(file, "%s: %3d\n", "pending", txq->pending_frames);
 
         ath_txq_unlock(sc, txq);
 }
@@ -1208,7 +1206,6 @@ static const char ath9k_gstrings_stats[][ETH_GSTRING_LEN] = {
         AMKSTR(d_tx_mpdu_xretries),
         AMKSTR(d_tx_aggregates),
         AMKSTR(d_tx_ampdus_queued_hw),
-        AMKSTR(d_tx_ampdus_queued_sw),
         AMKSTR(d_tx_ampdus_completed),
         AMKSTR(d_tx_ampdu_retries),
         AMKSTR(d_tx_ampdu_xretries),
@@ -1288,7 +1285,6 @@ void ath9k_get_et_stats(struct ieee80211_hw *hw,
         AWDATA(xretries);
         AWDATA(a_aggr);
         AWDATA(a_queued_hw);
-        AWDATA(a_queued_sw);
         AWDATA(a_completed);
         AWDATA(a_retries);
         AWDATA(a_xretries);
@@ -1346,14 +1342,6 @@ int ath9k_init_debug(struct ath_hw *ah)
                                     read_file_xmit);
         debugfs_create_devm_seqfile(sc->dev, "queues", sc->debug.debugfs_phy,
                                     read_file_queues);
-        debugfs_create_u32("qlen_bk", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
-                           &sc->tx.txq_max_pending[IEEE80211_AC_BK]);
-        debugfs_create_u32("qlen_be", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
-                           &sc->tx.txq_max_pending[IEEE80211_AC_BE]);
-        debugfs_create_u32("qlen_vi", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
-                           &sc->tx.txq_max_pending[IEEE80211_AC_VI]);
-        debugfs_create_u32("qlen_vo", S_IRUSR | S_IWUSR, sc->debug.debugfs_phy,
-                           &sc->tx.txq_max_pending[IEEE80211_AC_VO]);
         debugfs_create_devm_seqfile(sc->dev, "misc", sc->debug.debugfs_phy,
                                     read_file_misc);
         debugfs_create_devm_seqfile(sc->dev, "reset", sc->debug.debugfs_phy,