aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/ath/ath10k/debug.c
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-09-22 13:35:34 -0400
committerKalle Valo <kvalo@qca.qualcomm.com>2014-09-29 07:29:23 -0400
commitbabcb3edd942927091ef5e5b284ffc657c652023 (patch)
tree0deb32a455b883fc2bae8bd7d9b16e89be95e828 /drivers/net/wireless/ath/ath10k/debug.c
parent7869b4faf53e9d25212b17fcbc59dce22324fce7 (diff)
ath: change logging functions to return void
The return values are not used by callers of these functions so change the functions to return void. Other miscellanea: o add __printf verification to wil6210 logging functions No format/argument mismatches found Acked-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com> Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Diffstat (limited to 'drivers/net/wireless/ath/ath10k/debug.c')
-rw-r--r--drivers/net/wireless/ath/ath10k/debug.c18
1 files changed, 5 insertions, 13 deletions
diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index 22b4888444c9..5d44a4320ad0 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -107,21 +107,18 @@ struct ath10k_dump_file_data {
107 u8 data[0]; 107 u8 data[0];
108} __packed; 108} __packed;
109 109
110int ath10k_info(struct ath10k *ar, const char *fmt, ...) 110void ath10k_info(struct ath10k *ar, const char *fmt, ...)
111{ 111{
112 struct va_format vaf = { 112 struct va_format vaf = {
113 .fmt = fmt, 113 .fmt = fmt,
114 }; 114 };
115 va_list args; 115 va_list args;
116 int ret;
117 116
118 va_start(args, fmt); 117 va_start(args, fmt);
119 vaf.va = &args; 118 vaf.va = &args;
120 ret = dev_info(ar->dev, "%pV", &vaf); 119 dev_info(ar->dev, "%pV", &vaf);
121 trace_ath10k_log_info(ar, &vaf); 120 trace_ath10k_log_info(ar, &vaf);
122 va_end(args); 121 va_end(args);
123
124 return ret;
125} 122}
126EXPORT_SYMBOL(ath10k_info); 123EXPORT_SYMBOL(ath10k_info);
127 124
@@ -148,25 +145,22 @@ void ath10k_print_driver_info(struct ath10k *ar)
148} 145}
149EXPORT_SYMBOL(ath10k_print_driver_info); 146EXPORT_SYMBOL(ath10k_print_driver_info);
150 147
151int ath10k_err(struct ath10k *ar, const char *fmt, ...) 148void ath10k_err(struct ath10k *ar, const char *fmt, ...)
152{ 149{
153 struct va_format vaf = { 150 struct va_format vaf = {
154 .fmt = fmt, 151 .fmt = fmt,
155 }; 152 };
156 va_list args; 153 va_list args;
157 int ret;
158 154
159 va_start(args, fmt); 155 va_start(args, fmt);
160 vaf.va = &args; 156 vaf.va = &args;
161 ret = dev_err(ar->dev, "%pV", &vaf); 157 dev_err(ar->dev, "%pV", &vaf);
162 trace_ath10k_log_err(ar, &vaf); 158 trace_ath10k_log_err(ar, &vaf);
163 va_end(args); 159 va_end(args);
164
165 return ret;
166} 160}
167EXPORT_SYMBOL(ath10k_err); 161EXPORT_SYMBOL(ath10k_err);
168 162
169int ath10k_warn(struct ath10k *ar, const char *fmt, ...) 163void ath10k_warn(struct ath10k *ar, const char *fmt, ...)
170{ 164{
171 struct va_format vaf = { 165 struct va_format vaf = {
172 .fmt = fmt, 166 .fmt = fmt,
@@ -179,8 +173,6 @@ int ath10k_warn(struct ath10k *ar, const char *fmt, ...)
179 trace_ath10k_log_warn(ar, &vaf); 173 trace_ath10k_log_warn(ar, &vaf);
180 174
181 va_end(args); 175 va_end(args);
182
183 return 0;
184} 176}
185EXPORT_SYMBOL(ath10k_warn); 177EXPORT_SYMBOL(ath10k_warn);
186 178