aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/phy/bcm-cygnus.c
diff options
context:
space:
mode:
authorHeiner Kallweit <hkallweit1@gmail.com>2019-04-12 14:47:03 -0400
committerDavid S. Miller <davem@davemloft.net>2019-04-15 20:19:54 -0400
commitdcdecdcfe1fc39ded8590aed2fe84d62f14b2392 (patch)
tree7b0ce1afad9d8d4a8bba17713d42e29302a475d2 /drivers/net/phy/bcm-cygnus.c
parentb6ed55cb721c13497c3cddd6caee46a7f92c4e7b (diff)
net: phy: switch drivers to use dynamic feature detection
Recently genphy_read_abilities() has been added that dynamically detects clause 22 PHY abilities. I *think* this detection should work with all supported PHY's, at least for the ones with basic features sets, i.e. PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting these features explicitly and rely on phylib feature detection. I don't have access to most of these PHY's, therefore I'd appreciate regression testing. v2: - make the feature constant a comment so that readers know which features are supported by the respective PHY Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Tested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/phy/bcm-cygnus.c')
-rw-r--r--drivers/net/phy/bcm-cygnus.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/phy/bcm-cygnus.c b/drivers/net/phy/bcm-cygnus.c
index 625b7cb76285..9ccf28b0a04d 100644
--- a/drivers/net/phy/bcm-cygnus.c
+++ b/drivers/net/phy/bcm-cygnus.c
@@ -254,7 +254,7 @@ static struct phy_driver bcm_cygnus_phy_driver[] = {
254 .phy_id = PHY_ID_BCM_CYGNUS, 254 .phy_id = PHY_ID_BCM_CYGNUS,
255 .phy_id_mask = 0xfffffff0, 255 .phy_id_mask = 0xfffffff0,
256 .name = "Broadcom Cygnus PHY", 256 .name = "Broadcom Cygnus PHY",
257 .features = PHY_GBIT_FEATURES, 257 /* PHY_GBIT_FEATURES */
258 .config_init = bcm_cygnus_config_init, 258 .config_init = bcm_cygnus_config_init,
259 .ack_interrupt = bcm_phy_ack_intr, 259 .ack_interrupt = bcm_phy_ack_intr,
260 .config_intr = bcm_phy_config_intr, 260 .config_intr = bcm_phy_config_intr,
@@ -264,7 +264,7 @@ static struct phy_driver bcm_cygnus_phy_driver[] = {
264 .phy_id = PHY_ID_BCM_OMEGA, 264 .phy_id = PHY_ID_BCM_OMEGA,
265 .phy_id_mask = 0xfffffff0, 265 .phy_id_mask = 0xfffffff0,
266 .name = "Broadcom Omega Combo GPHY", 266 .name = "Broadcom Omega Combo GPHY",
267 .features = PHY_GBIT_FEATURES, 267 /* PHY_GBIT_FEATURES */
268 .flags = PHY_IS_INTERNAL, 268 .flags = PHY_IS_INTERNAL,
269 .config_init = bcm_omega_config_init, 269 .config_init = bcm_omega_config_init,
270 .suspend = genphy_suspend, 270 .suspend = genphy_suspend,