net: make ndo_get_stats64 a void function

The network device operation for reading statistics is only called
in one place, and it ignores the return value. Having a structure
return value is potentially confusing because some future driver could
incorrectly assume that the return value was used.

Fix all drivers with ndo_get_stats64 to have a void function.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 3 insertions, 5 deletions

diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
index f83cf6696820..778a77303c49 100644
--- a/drivers/net/macsec.c
+++ b/drivers/net/macsec.c
@@ -2888,13 +2888,13 @@ static int macsec_change_mtu(struct net_device *dev, int new_mtu)
         return 0;
 }
 
-static struct rtnl_link_stats64 *macsec_get_stats64(struct net_device *dev,
-                                                    struct rtnl_link_stats64 *s)
+static void macsec_get_stats64(struct net_device *dev,
+                               struct rtnl_link_stats64 *s)
 {
         int cpu;
 
         if (!dev->tstats)
-                return s;
+                return;
 
         for_each_possible_cpu(cpu) {
                 struct pcpu_sw_netstats *stats;
@@ -2918,8 +2918,6 @@ static struct rtnl_link_stats64 *macsec_get_stats64(struct net_device *dev,
 
         s->rx_dropped = dev->stats.rx_dropped;
         s->tx_dropped = dev->stats.tx_dropped;
-
-        return s;
 }
 
 static int macsec_get_iflink(const struct net_device *dev)