diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-03-05 12:48:46 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-03-06 21:50:42 -0500 |
commit | feb27d155dfabcb8baabe10367f25fc2b1bcede1 (patch) | |
tree | d78b81abe2f05d367e90b411473c0ce239a9d389 /drivers/net/hamradio | |
parent | f68a8ebd33d752d3178d1fcae453a14106357c79 (diff) |
ax25: remove unneeded NULL test in ax_xmit()
We get a static checker warning here on devel kernels:
drivers/net/hamradio/mkiss.c:560 ax_xmit()
warn: variable dereferenced before check 'skb' (see line 532)
It turns out that the NULL check can be deleted.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/hamradio')
-rw-r--r-- | drivers/net/hamradio/mkiss.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 17058c490b79..2ffbf13471d0 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c | |||
@@ -557,11 +557,9 @@ static netdev_tx_t ax_xmit(struct sk_buff *skb, struct net_device *dev) | |||
557 | } | 557 | } |
558 | 558 | ||
559 | /* We were not busy, so we are now... :-) */ | 559 | /* We were not busy, so we are now... :-) */ |
560 | if (skb != NULL) { | 560 | netif_stop_queue(dev); |
561 | netif_stop_queue(dev); | 561 | ax_encaps(dev, skb->data, skb->len); |
562 | ax_encaps(dev, skb->data, skb->len); | 562 | kfree_skb(skb); |
563 | kfree_skb(skb); | ||
564 | } | ||
565 | 563 | ||
566 | return NETDEV_TX_OK; | 564 | return NETDEV_TX_OK; |
567 | } | 565 | } |