diff options
| author | Maciej W. Rozycki <macro@linux-mips.org> | 2014-07-05 10:28:22 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-07-08 18:31:52 -0400 |
| commit | 51ba0ed17514f9f7cf63a4be21092e8f2d8c558e (patch) | |
| tree | 8df3c1e149c0ccf7a4508d6389d03443a914c778 /drivers/net/fddi | |
| parent | 284a83a0766101933250437f373c4886ff87e8a4 (diff) | |
defxx: Fix issues with debug printk calls
This fixes issues with debug printk calls across the driver, normally
disabled; first compilation errors:
drivers/net/fddi/defxx.c:676:1: error: pasting "(" and ""In dfx_bus_init...\n"" does not give a valid preprocessing token
drivers/net/fddi/defxx.c:820:1: error: pasting "(" and ""In dfx_bus_uninit...\n"" does not give a valid preprocessing token
and so on, and then warnings:
drivers/net/fddi/defxx.c: In function 'dfx_driver_init':
drivers/net/fddi/defxx.c:1132: warning: format '%0X' expects type 'unsigned int', but argument 4 has type 'dma_addr_t'
drivers/net/fddi/defxx.c:1132: warning: format '%0X' expects type 'unsigned int', but argument 4 has type 'dma_addr_t'
etc. Additionally casts are removed from virtual addresses and %p used.
Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/fddi')
| -rw-r--r-- | drivers/net/fddi/defxx.c | 21 | ||||
| -rw-r--r-- | drivers/net/fddi/defxx.h | 2 |
2 files changed, 11 insertions, 12 deletions
diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c index 3d1a878a4ab0..6ea59ece7e0b 100644 --- a/drivers/net/fddi/defxx.c +++ b/drivers/net/fddi/defxx.c | |||
| @@ -1123,17 +1123,16 @@ static int dfx_driver_init(struct net_device *dev, const char *print_name, | |||
| 1123 | 1123 | ||
| 1124 | /* Display virtual and physical addresses if debug driver */ | 1124 | /* Display virtual and physical addresses if debug driver */ |
| 1125 | 1125 | ||
| 1126 | DBG_printk("%s: Descriptor block virt = %0lX, phys = %0X\n", | 1126 | DBG_printk("%s: Descriptor block virt = %p, phys = %pad\n", |
| 1127 | print_name, | 1127 | print_name, bp->descr_block_virt, &bp->descr_block_phys); |
| 1128 | (long)bp->descr_block_virt, bp->descr_block_phys); | 1128 | DBG_printk("%s: Command Request buffer virt = %p, phys = %pad\n", |
| 1129 | DBG_printk("%s: Command Request buffer virt = %0lX, phys = %0X\n", | 1129 | print_name, bp->cmd_req_virt, &bp->cmd_req_phys); |
| 1130 | print_name, (long)bp->cmd_req_virt, bp->cmd_req_phys); | 1130 | DBG_printk("%s: Command Response buffer virt = %p, phys = %pad\n", |
| 1131 | DBG_printk("%s: Command Response buffer virt = %0lX, phys = %0X\n", | 1131 | print_name, bp->cmd_rsp_virt, &bp->cmd_rsp_phys); |
| 1132 | print_name, (long)bp->cmd_rsp_virt, bp->cmd_rsp_phys); | 1132 | DBG_printk("%s: Receive buffer block virt = %p, phys = %pad\n", |
| 1133 | DBG_printk("%s: Receive buffer block virt = %0lX, phys = %0X\n", | 1133 | print_name, bp->rcv_block_virt, &bp->rcv_block_phys); |
| 1134 | print_name, (long)bp->rcv_block_virt, bp->rcv_block_phys); | 1134 | DBG_printk("%s: Consumer block virt = %p, phys = %pad\n", |
| 1135 | DBG_printk("%s: Consumer block virt = %0lX, phys = %0X\n", | 1135 | print_name, bp->cons_block_virt, &bp->cons_block_phys); |
| 1136 | print_name, (long)bp->cons_block_virt, bp->cons_block_phys); | ||
| 1137 | 1136 | ||
| 1138 | return DFX_K_SUCCESS; | 1137 | return DFX_K_SUCCESS; |
| 1139 | } | 1138 | } |
diff --git a/drivers/net/fddi/defxx.h b/drivers/net/fddi/defxx.h index 19a6f64df198..adb63f3f7b4a 100644 --- a/drivers/net/fddi/defxx.h +++ b/drivers/net/fddi/defxx.h | |||
| @@ -1693,7 +1693,7 @@ typedef union | |||
| 1693 | /* Only execute special print call when debug driver was built */ | 1693 | /* Only execute special print call when debug driver was built */ |
| 1694 | 1694 | ||
| 1695 | #ifdef DEFXX_DEBUG | 1695 | #ifdef DEFXX_DEBUG |
| 1696 | #define DBG_printk(args...) printk(## args) | 1696 | #define DBG_printk(args...) printk(args) |
| 1697 | #else | 1697 | #else |
| 1698 | #define DBG_printk(args...) | 1698 | #define DBG_printk(args...) |
| 1699 | #endif | 1699 | #endif |
