aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/microchip
diff options
context:
space:
mode:
authorDanny Kukawka <danny.kukawka@bisect.de>2012-02-15 01:45:40 -0500
committerDavid S. Miller <davem@davemloft.net>2012-02-15 15:34:17 -0500
commit7ce5d222190cb3ce3ae88bafde7c4fa52a5103e0 (patch)
tree2b284365b7a2e11d4ba286a589bd35bc39918805 /drivers/net/ethernet/microchip
parentf2cedb63df14342ad40a8b5b324fc5d94a60b665 (diff)
net: use eth_hw_addr_random() and reset addr_assign_type
Use eth_hw_addr_random() instead of calling random_ether_addr() to set addr_assign_type correctly to NET_ADDR_RANDOM. Reset the state to NET_ADDR_PERM as soon as the MAC get changed via .ndo_set_mac_address. v2: adapt to renamed eth_hw_addr_random() Signed-off-by: Danny Kukawka <danny.kukawka@bisect.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/microchip')
-rw-r--r--drivers/net/ethernet/microchip/enc28j60.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/microchip/enc28j60.c b/drivers/net/ethernet/microchip/enc28j60.c
index 1d6b7ce3e1ee..6118bdad244f 100644
--- a/drivers/net/ethernet/microchip/enc28j60.c
+++ b/drivers/net/ethernet/microchip/enc28j60.c
@@ -527,6 +527,7 @@ static int enc28j60_set_mac_address(struct net_device *dev, void *addr)
527 if (!is_valid_ether_addr(address->sa_data)) 527 if (!is_valid_ether_addr(address->sa_data))
528 return -EADDRNOTAVAIL; 528 return -EADDRNOTAVAIL;
529 529
530 dev->addr_assign_type &= ~NET_ADDR_RANDOM;
530 memcpy(dev->dev_addr, address->sa_data, dev->addr_len); 531 memcpy(dev->dev_addr, address->sa_data, dev->addr_len);
531 return enc28j60_set_hw_macaddr(dev); 532 return enc28j60_set_hw_macaddr(dev);
532} 533}
@@ -1575,7 +1576,7 @@ static int __devinit enc28j60_probe(struct spi_device *spi)
1575 ret = -EIO; 1576 ret = -EIO;
1576 goto error_irq; 1577 goto error_irq;
1577 } 1578 }
1578 random_ether_addr(dev->dev_addr); 1579 eth_hw_addr_random(dev);
1579 enc28j60_set_hw_macaddr(dev); 1580 enc28j60_set_hw_macaddr(dev);
1580 1581
1581 /* Board setup must set the relevant edge trigger type; 1582 /* Board setup must set the relevant edge trigger type;