aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel
diff options
context:
space:
mode:
authorMitch Williams <mitch.a.williams@intel.com>2018-10-26 17:33:33 -0400
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2018-11-14 13:56:34 -0500
commit7cd8eb0861981ad212ce4242a1870c4b5831ceff (patch)
treec41fd29b83c190a9491fde28c499e54d448b2e90 /drivers/net/ethernet/intel
parent211257a499c632052669526c7e643f6ac51e3fc8 (diff)
i40e: suppress bogus error message
The i40e driver complains about unprivileged VFs trying to configure promiscuous mode each time a VF reset occurs. This isn't the fault of the poor VF driver - the PF driver itself is making the request. To fix this, skip the privilege check if the request is to disable all promiscuous activity. This gets rid of the bogus message, but doesn't affect privilege checks, since we really only care if the unprivileged VF is trying to enable promiscuous mode. Signed-off-by: Mitch Williams <mitch.a.williams@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel')
-rw-r--r--drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
index 8e0a247e7e5a..2ac23ebfbf31 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
@@ -1112,7 +1112,8 @@ static i40e_status i40e_config_vf_promiscuous_mode(struct i40e_vf *vf,
1112 if (!i40e_vc_isvalid_vsi_id(vf, vsi_id) || !vsi) 1112 if (!i40e_vc_isvalid_vsi_id(vf, vsi_id) || !vsi)
1113 return I40E_ERR_PARAM; 1113 return I40E_ERR_PARAM;
1114 1114
1115 if (!test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps)) { 1115 if (!test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps) &&
1116 (allmulti || alluni)) {
1116 dev_err(&pf->pdev->dev, 1117 dev_err(&pf->pdev->dev,
1117 "Unprivileged VF %d is attempting to configure promiscuous mode\n", 1118 "Unprivileged VF %d is attempting to configure promiscuous mode\n",
1118 vf->vf_id); 1119 vf->vf_id);