aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/igb/igb_main.c
diff options
context:
space:
mode:
authorCarolyn Wyborny <carolyn.wyborny@intel.com>2014-04-10 21:45:17 -0400
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2014-04-23 04:22:19 -0400
commitc75c4edfc38da8235d110a8f28b596193de787ab (patch)
tree3411303cc42d6a38f01a2abc2cc7bd43de811d86 /drivers/net/ethernet/intel/igb/igb_main.c
parent0e8e842b8105e521287c3305806099f370986fb1 (diff)
igb: Cleanups for messaging
This patch fixes WARNING:PREFER_PR_LEVEL and WARNING:SPLIT_STRING from checkpatch file check. Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/igb/igb_main.c')
-rw-r--r--drivers/net/ethernet/intel/igb/igb_main.c34
1 files changed, 12 insertions, 22 deletions
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index fb98d4602f9d..13edca95e56d 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -217,8 +217,7 @@ static void igb_netpoll(struct net_device *);
217#ifdef CONFIG_PCI_IOV 217#ifdef CONFIG_PCI_IOV
218static unsigned int max_vfs = 0; 218static unsigned int max_vfs = 0;
219module_param(max_vfs, uint, 0); 219module_param(max_vfs, uint, 0);
220MODULE_PARM_DESC(max_vfs, "Maximum number of virtual functions to allocate " 220MODULE_PARM_DESC(max_vfs, "Maximum number of virtual functions to allocate per physical function");
221 "per physical function");
222#endif /* CONFIG_PCI_IOV */ 221#endif /* CONFIG_PCI_IOV */
223 222
224static pci_ers_result_t igb_io_error_detected(struct pci_dev *, 223static pci_ers_result_t igb_io_error_detected(struct pci_dev *,
@@ -384,8 +383,7 @@ static void igb_dump(struct igb_adapter *adapter)
384 /* Print netdevice Info */ 383 /* Print netdevice Info */
385 if (netdev) { 384 if (netdev) {
386 dev_info(&adapter->pdev->dev, "Net device Info\n"); 385 dev_info(&adapter->pdev->dev, "Net device Info\n");
387 pr_info("Device Name state trans_start " 386 pr_info("Device Name state trans_start last_rx\n");
388 "last_rx\n");
389 pr_info("%-15s %016lX %016lX %016lX\n", netdev->name, 387 pr_info("%-15s %016lX %016lX %016lX\n", netdev->name,
390 netdev->state, netdev->trans_start, netdev->last_rx); 388 netdev->state, netdev->trans_start, netdev->last_rx);
391 } 389 }
@@ -438,9 +436,7 @@ static void igb_dump(struct igb_adapter *adapter)
438 pr_info("------------------------------------\n"); 436 pr_info("------------------------------------\n");
439 pr_info("TX QUEUE INDEX = %d\n", tx_ring->queue_index); 437 pr_info("TX QUEUE INDEX = %d\n", tx_ring->queue_index);
440 pr_info("------------------------------------\n"); 438 pr_info("------------------------------------\n");
441 pr_info("T [desc] [address 63:0 ] [PlPOCIStDDM Ln] " 439 pr_info("T [desc] [address 63:0 ] [PlPOCIStDDM Ln] [bi->dma ] leng ntw timestamp bi->skb\n");
442 "[bi->dma ] leng ntw timestamp "
443 "bi->skb\n");
444 440
445 for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) { 441 for (i = 0; tx_ring->desc && (i < tx_ring->count); i++) {
446 const char *next_desc; 442 const char *next_desc;
@@ -458,9 +454,8 @@ static void igb_dump(struct igb_adapter *adapter)
458 else 454 else
459 next_desc = ""; 455 next_desc = "";
460 456
461 pr_info("T [0x%03X] %016llX %016llX %016llX" 457 pr_info("T [0x%03X] %016llX %016llX %016llX %04X %p %016llX %p%s\n",
462 " %04X %p %016llX %p%s\n", i, 458 i, le64_to_cpu(u0->a),
463 le64_to_cpu(u0->a),
464 le64_to_cpu(u0->b), 459 le64_to_cpu(u0->b),
465 (u64)dma_unmap_addr(buffer_info, dma), 460 (u64)dma_unmap_addr(buffer_info, dma),
466 dma_unmap_len(buffer_info, len), 461 dma_unmap_len(buffer_info, len),
@@ -519,10 +514,8 @@ rx_ring_summary:
519 pr_info("------------------------------------\n"); 514 pr_info("------------------------------------\n");
520 pr_info("RX QUEUE INDEX = %d\n", rx_ring->queue_index); 515 pr_info("RX QUEUE INDEX = %d\n", rx_ring->queue_index);
521 pr_info("------------------------------------\n"); 516 pr_info("------------------------------------\n");
522 pr_info("R [desc] [ PktBuf A0] [ HeadBuf DD] " 517 pr_info("R [desc] [ PktBuf A0] [ HeadBuf DD] [bi->dma ] [bi->skb] <-- Adv Rx Read format\n");
523 "[bi->dma ] [bi->skb] <-- Adv Rx Read format\n"); 518 pr_info("RWB[desc] [PcsmIpSHl PtRs] [vl er S cks ln] ---------------- [bi->skb] <-- Adv Rx Write-Back format\n");
524 pr_info("RWB[desc] [PcsmIpSHl PtRs] [vl er S cks ln] -----"
525 "----------- [bi->skb] <-- Adv Rx Write-Back format\n");
526 519
527 for (i = 0; i < rx_ring->count; i++) { 520 for (i = 0; i < rx_ring->count; i++) {
528 const char *next_desc; 521 const char *next_desc;
@@ -4215,8 +4208,8 @@ static void igb_watchdog_task(struct work_struct *work)
4215 4208
4216 ctrl = rd32(E1000_CTRL); 4209 ctrl = rd32(E1000_CTRL);
4217 /* Links status message must follow this format */ 4210 /* Links status message must follow this format */
4218 printk(KERN_INFO "igb: %s NIC Link is Up %d Mbps %s " 4211 netdev_info(netdev,
4219 "Duplex, Flow Control: %s\n", 4212 "igb: %s NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\n",
4220 netdev->name, 4213 netdev->name,
4221 adapter->link_speed, 4214 adapter->link_speed,
4222 adapter->link_duplex == FULL_DUPLEX ? 4215 adapter->link_duplex == FULL_DUPLEX ?
@@ -4243,9 +4236,7 @@ static void igb_watchdog_task(struct work_struct *work)
4243 /* check for thermal sensor event */ 4236 /* check for thermal sensor event */
4244 if (igb_thermal_sensor_event(hw, 4237 if (igb_thermal_sensor_event(hw,
4245 E1000_THSTAT_LINK_THROTTLE)) { 4238 E1000_THSTAT_LINK_THROTTLE)) {
4246 netdev_info(netdev, "The network adapter link " 4239 netdev_info(netdev, "The network adapter link speed was downshifted because it overheated\n");
4247 "speed was downshifted because it "
4248 "overheated\n");
4249 } 4240 }
4250 4241
4251 /* adjust timeout factor according to speed/duplex */ 4242 /* adjust timeout factor according to speed/duplex */
@@ -4277,12 +4268,11 @@ static void igb_watchdog_task(struct work_struct *work)
4277 /* check for thermal sensor event */ 4268 /* check for thermal sensor event */
4278 if (igb_thermal_sensor_event(hw, 4269 if (igb_thermal_sensor_event(hw,
4279 E1000_THSTAT_PWR_DOWN)) { 4270 E1000_THSTAT_PWR_DOWN)) {
4280 netdev_err(netdev, "The network adapter was " 4271 netdev_err(netdev, "The network adapter was stopped because it overheated\n");
4281 "stopped because it overheated\n");
4282 } 4272 }
4283 4273
4284 /* Links status message must follow this format */ 4274 /* Links status message must follow this format */
4285 printk(KERN_INFO "igb: %s NIC Link is Down\n", 4275 netdev_info(netdev, "igb: %s NIC Link is Down\n",
4286 netdev->name); 4276 netdev->name);
4287 netif_carrier_off(netdev); 4277 netif_carrier_off(netdev);
4288 4278