aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/intel/ice/ice_switch.c
diff options
context:
space:
mode:
authorBruce Allan <bruce.w.allan@intel.com>2018-11-07 13:19:35 -0500
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>2018-11-20 14:39:04 -0500
commitf25dad19ba70f7cc135da78ec013325042cd8c52 (patch)
treed161d7799b6c78009a6947c7e573a462ad85a43c /drivers/net/ethernet/intel/ice/ice_switch.c
parentd337f2afb7aceb16840a2621c5e2f9e868630653 (diff)
ice: Fix possible NULL pointer de-reference
A recent update to smatch is causing it to report the error "we previously assumed 'm_entry->vsi_list_info' could be null". Fix that. Signed-off-by: Bruce Allan <bruce.w.allan@intel.com> Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> Tested-by: Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice_switch.c')
-rw-r--r--drivers/net/ethernet/intel/ice/ice_switch.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index 091047f7ac02..2e5693107fa4 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -1247,6 +1247,9 @@ ice_add_update_vsi_list(struct ice_hw *hw,
1247 u16 vsi_handle = new_fltr->vsi_handle; 1247 u16 vsi_handle = new_fltr->vsi_handle;
1248 enum ice_adminq_opc opcode; 1248 enum ice_adminq_opc opcode;
1249 1249
1250 if (!m_entry->vsi_list_info)
1251 return ICE_ERR_CFG;
1252
1250 /* A rule already exists with the new VSI being added */ 1253 /* A rule already exists with the new VSI being added */
1251 if (test_bit(vsi_handle, m_entry->vsi_list_info->vsi_map)) 1254 if (test_bit(vsi_handle, m_entry->vsi_list_info->vsi_map))
1252 return 0; 1255 return 0;