diff options
author | Petr Machata <petrm@mellanox.com> | 2018-12-12 12:02:48 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-12-12 19:34:21 -0500 |
commit | 2fd527b72bb6f95dfe8a1902e998cb76390c431e (patch) | |
tree | 94b0ba7d645c645a20f3310444d85977e13633d2 /drivers/net/ethernet/intel/ice/ice_main.c | |
parent | 351cbde969230a072cabca9969c68ab04e58e6b3 (diff) |
net: ndo_bridge_setlink: Add extack
Drivers may not be able to implement a VLAN addition or reconfiguration.
In those cases it's desirable to explain to the user that it was
rejected (and why).
To that end, add extack argument to ndo_bridge_setlink. Adapt all users
to that change.
Following patches will use the new argument in the bridge driver.
Signed-off-by: Petr Machata <petrm@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/intel/ice/ice_main.c')
-rw-r--r-- | drivers/net/ethernet/intel/ice/ice_main.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index e45e57499d91..f9f0d470412b 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c | |||
@@ -3624,6 +3624,7 @@ static int ice_vsi_update_bridge_mode(struct ice_vsi *vsi, u16 bmode) | |||
3624 | * @dev: the netdev being configured | 3624 | * @dev: the netdev being configured |
3625 | * @nlh: RTNL message | 3625 | * @nlh: RTNL message |
3626 | * @flags: bridge setlink flags | 3626 | * @flags: bridge setlink flags |
3627 | * @extack: netlink extended ack | ||
3627 | * | 3628 | * |
3628 | * Sets the bridge mode (VEB/VEPA) of the switch to which the netdev (VSI) is | 3629 | * Sets the bridge mode (VEB/VEPA) of the switch to which the netdev (VSI) is |
3629 | * hooked up to. Iterates through the PF VSI list and sets the loopback mode (if | 3630 | * hooked up to. Iterates through the PF VSI list and sets the loopback mode (if |
@@ -3632,7 +3633,7 @@ static int ice_vsi_update_bridge_mode(struct ice_vsi *vsi, u16 bmode) | |||
3632 | */ | 3633 | */ |
3633 | static int | 3634 | static int |
3634 | ice_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh, | 3635 | ice_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh, |
3635 | u16 __always_unused flags) | 3636 | u16 __always_unused flags, struct netlink_ext_ack *extack) |
3636 | { | 3637 | { |
3637 | struct ice_netdev_priv *np = netdev_priv(dev); | 3638 | struct ice_netdev_priv *np = netdev_priv(dev); |
3638 | struct ice_pf *pf = np->vsi->back; | 3639 | struct ice_pf *pf = np->vsi->back; |