diff options
author | Joe Perches <joe@perches.com> | 2018-03-23 19:34:44 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-03-26 12:07:49 -0400 |
commit | d3757ba4c1421d2ad00d2bf97119005e37ad2902 (patch) | |
tree | a3b09afa0c49bf22c10eb29c2436bf71619a5395 /drivers/net/ethernet/ibm | |
parent | d61e40385655fbba659fc3d81df9bdf1b848e263 (diff) |
ethernet: Use octal not symbolic permissions
Prefer the direct use of octal for permissions.
Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace
and some typing.
Miscellanea:
o Whitespace neatening around these conversions.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/ibm')
-rw-r--r-- | drivers/net/ethernet/ibm/ehea/ehea_main.c | 7 | ||||
-rw-r--r-- | drivers/net/ethernet/ibm/ibmveth.c | 2 |
2 files changed, 4 insertions, 5 deletions
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 4878b7169e0f..ba580bfae512 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c | |||
@@ -2903,8 +2903,7 @@ static ssize_t ehea_show_port_id(struct device *dev, | |||
2903 | return sprintf(buf, "%d", port->logical_port_id); | 2903 | return sprintf(buf, "%d", port->logical_port_id); |
2904 | } | 2904 | } |
2905 | 2905 | ||
2906 | static DEVICE_ATTR(log_port_id, S_IRUSR | S_IRGRP | S_IROTH, ehea_show_port_id, | 2906 | static DEVICE_ATTR(log_port_id, 0444, ehea_show_port_id, NULL); |
2907 | NULL); | ||
2908 | 2907 | ||
2909 | static void logical_port_release(struct device *dev) | 2908 | static void logical_port_release(struct device *dev) |
2910 | { | 2909 | { |
@@ -3235,8 +3234,8 @@ static ssize_t ehea_remove_port(struct device *dev, | |||
3235 | return (ssize_t) count; | 3234 | return (ssize_t) count; |
3236 | } | 3235 | } |
3237 | 3236 | ||
3238 | static DEVICE_ATTR(probe_port, S_IWUSR, NULL, ehea_probe_port); | 3237 | static DEVICE_ATTR(probe_port, 0200, NULL, ehea_probe_port); |
3239 | static DEVICE_ATTR(remove_port, S_IWUSR, NULL, ehea_remove_port); | 3238 | static DEVICE_ATTR(remove_port, 0200, NULL, ehea_remove_port); |
3240 | 3239 | ||
3241 | static int ehea_create_device_sysfs(struct platform_device *dev) | 3240 | static int ehea_create_device_sysfs(struct platform_device *dev) |
3242 | { | 3241 | { |
diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index f210398200ec..c1b51edaaf62 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c | |||
@@ -82,7 +82,7 @@ module_param(rx_flush, uint, 0644); | |||
82 | MODULE_PARM_DESC(rx_flush, "Flush receive buffers before use"); | 82 | MODULE_PARM_DESC(rx_flush, "Flush receive buffers before use"); |
83 | 83 | ||
84 | static bool old_large_send __read_mostly; | 84 | static bool old_large_send __read_mostly; |
85 | module_param(old_large_send, bool, S_IRUGO); | 85 | module_param(old_large_send, bool, 0444); |
86 | MODULE_PARM_DESC(old_large_send, | 86 | MODULE_PARM_DESC(old_large_send, |
87 | "Use old large send method on firmware that supports the new method"); | 87 | "Use old large send method on firmware that supports the new method"); |
88 | 88 | ||