diff options
author | Ivan Vecera <ivecera@redhat.com> | 2015-06-11 09:52:20 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-06-11 18:57:16 -0400 |
commit | f39857e1e20d22402df4fb29234d3dd5045bcd11 (patch) | |
tree | a67f94226d2b93592f77c9c2df36512d3fa365dd /drivers/net/ethernet/brocade | |
parent | ef5b67c133b480d3f4b66b074c37b6462ee1e8a3 (diff) |
bna: remove oper_state_cbfn from struct bna_rxf
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/brocade')
-rw-r--r-- | drivers/net/ethernet/brocade/bna/bna.h | 15 | ||||
-rw-r--r-- | drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 6 | ||||
-rw-r--r-- | drivers/net/ethernet/brocade/bna/bna_types.h | 4 |
3 files changed, 0 insertions, 25 deletions
diff --git a/drivers/net/ethernet/brocade/bna/bna.h b/drivers/net/ethernet/brocade/bna/bna.h index 0962e54e66ef..4f16ee23b7a0 100644 --- a/drivers/net/ethernet/brocade/bna/bna.h +++ b/drivers/net/ethernet/brocade/bna/bna.h | |||
@@ -119,21 +119,6 @@ do { \ | |||
119 | } \ | 119 | } \ |
120 | } while (0) | 120 | } while (0) |
121 | 121 | ||
122 | #define call_rxf_pause_cbfn(rxf) \ | ||
123 | do { \ | ||
124 | if ((rxf)->oper_state_cbfn) { \ | ||
125 | void (*cbfn)(struct bnad *, struct bna_rx *); \ | ||
126 | struct bnad *cbarg; \ | ||
127 | cbfn = (rxf)->oper_state_cbfn; \ | ||
128 | cbarg = (rxf)->oper_state_cbarg; \ | ||
129 | (rxf)->oper_state_cbfn = NULL; \ | ||
130 | (rxf)->oper_state_cbarg = NULL; \ | ||
131 | cbfn(cbarg, rxf->rx); \ | ||
132 | } \ | ||
133 | } while (0) | ||
134 | |||
135 | #define call_rxf_resume_cbfn(rxf) call_rxf_pause_cbfn(rxf) | ||
136 | |||
137 | #define is_xxx_enable(mode, bitmask, xxx) ((bitmask & xxx) && (mode & xxx)) | 122 | #define is_xxx_enable(mode, bitmask, xxx) ((bitmask & xxx) && (mode & xxx)) |
138 | 123 | ||
139 | #define is_xxx_disable(mode, bitmask, xxx) ((bitmask & xxx) && !(mode & xxx)) | 124 | #define is_xxx_disable(mode, bitmask, xxx) ((bitmask & xxx) && !(mode & xxx)) |
diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c b/drivers/net/ethernet/brocade/bna/bna_tx_rx.c index 16d36df7cd0e..27f75d7a18f8 100644 --- a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c +++ b/drivers/net/ethernet/brocade/bna/bna_tx_rx.c | |||
@@ -103,12 +103,10 @@ bna_rxf_sm_stopped(struct bna_rxf *rxf, enum bna_rxf_event event) | |||
103 | 103 | ||
104 | case RXF_E_PAUSE: | 104 | case RXF_E_PAUSE: |
105 | rxf->flags |= BNA_RXF_F_PAUSED; | 105 | rxf->flags |= BNA_RXF_F_PAUSED; |
106 | call_rxf_pause_cbfn(rxf); | ||
107 | break; | 106 | break; |
108 | 107 | ||
109 | case RXF_E_RESUME: | 108 | case RXF_E_RESUME: |
110 | rxf->flags &= ~BNA_RXF_F_PAUSED; | 109 | rxf->flags &= ~BNA_RXF_F_PAUSED; |
111 | call_rxf_resume_cbfn(rxf); | ||
112 | break; | 110 | break; |
113 | 111 | ||
114 | default: | 112 | default: |
@@ -119,7 +117,6 @@ bna_rxf_sm_stopped(struct bna_rxf *rxf, enum bna_rxf_event event) | |||
119 | static void | 117 | static void |
120 | bna_rxf_sm_paused_entry(struct bna_rxf *rxf) | 118 | bna_rxf_sm_paused_entry(struct bna_rxf *rxf) |
121 | { | 119 | { |
122 | call_rxf_pause_cbfn(rxf); | ||
123 | } | 120 | } |
124 | 121 | ||
125 | static void | 122 | static void |
@@ -166,7 +163,6 @@ bna_rxf_sm_cfg_wait(struct bna_rxf *rxf, enum bna_rxf_event event) | |||
166 | bna_rxf_cfg_reset(rxf); | 163 | bna_rxf_cfg_reset(rxf); |
167 | call_rxf_start_cbfn(rxf); | 164 | call_rxf_start_cbfn(rxf); |
168 | call_rxf_cam_fltr_cbfn(rxf); | 165 | call_rxf_cam_fltr_cbfn(rxf); |
169 | call_rxf_resume_cbfn(rxf); | ||
170 | bfa_fsm_set_state(rxf, bna_rxf_sm_stopped); | 166 | bfa_fsm_set_state(rxf, bna_rxf_sm_stopped); |
171 | break; | 167 | break; |
172 | 168 | ||
@@ -197,7 +193,6 @@ bna_rxf_sm_started_entry(struct bna_rxf *rxf) | |||
197 | { | 193 | { |
198 | call_rxf_start_cbfn(rxf); | 194 | call_rxf_start_cbfn(rxf); |
199 | call_rxf_cam_fltr_cbfn(rxf); | 195 | call_rxf_cam_fltr_cbfn(rxf); |
200 | call_rxf_resume_cbfn(rxf); | ||
201 | } | 196 | } |
202 | 197 | ||
203 | static void | 198 | static void |
@@ -238,7 +233,6 @@ bna_rxf_sm_fltr_clr_wait(struct bna_rxf *rxf, enum bna_rxf_event event) | |||
238 | switch (event) { | 233 | switch (event) { |
239 | case RXF_E_FAIL: | 234 | case RXF_E_FAIL: |
240 | bna_rxf_cfg_reset(rxf); | 235 | bna_rxf_cfg_reset(rxf); |
241 | call_rxf_pause_cbfn(rxf); | ||
242 | bfa_fsm_set_state(rxf, bna_rxf_sm_stopped); | 236 | bfa_fsm_set_state(rxf, bna_rxf_sm_stopped); |
243 | break; | 237 | break; |
244 | 238 | ||
diff --git a/drivers/net/ethernet/brocade/bna/bna_types.h b/drivers/net/ethernet/brocade/bna/bna_types.h index a50ee997dd45..96a02f24a391 100644 --- a/drivers/net/ethernet/brocade/bna/bna_types.h +++ b/drivers/net/ethernet/brocade/bna/bna_types.h | |||
@@ -739,10 +739,6 @@ struct bna_rxf { | |||
739 | void (*stop_cbfn) (struct bna_rx *rx); | 739 | void (*stop_cbfn) (struct bna_rx *rx); |
740 | struct bna_rx *stop_cbarg; | 740 | struct bna_rx *stop_cbarg; |
741 | 741 | ||
742 | /* callback for bna_rx_receive_pause() / bna_rx_receive_resume() */ | ||
743 | void (*oper_state_cbfn) (struct bnad *bnad, struct bna_rx *rx); | ||
744 | struct bnad *oper_state_cbarg; | ||
745 | |||
746 | /** | 742 | /** |
747 | * callback for: | 743 | * callback for: |
748 | * bna_rxf_ucast_set() | 744 | * bna_rxf_ucast_set() |