aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/broadcom/genet
diff options
context:
space:
mode:
authorFlorian Fainelli <f.fainelli@gmail.com>2015-07-16 18:51:19 -0400
committerDavid S. Miller <davem@davemloft.net>2015-07-20 23:48:14 -0400
commit28b45910ccda7b3e4de61b24a6f34d5fb1da90d2 (patch)
treeb713d1b8bb721209a004c567cf5e1ede265d9658 /drivers/net/ethernet/broadcom/genet
parent6cc8e6d4dcb3651eea9b01db3e195fffb19fb24f (diff)
net: bcmgenet: Remove init parameter from bcmgenet_mii_config
Now that we have reworked the way we perform the PHY initialization, we no longer need to differentiate between init time vs. non-init time calls, just use a dev_info_once() print to print the PHY type. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/broadcom/genet')
-rw-r--r--drivers/net/ethernet/broadcom/genet/bcmgenet.c2
-rw-r--r--drivers/net/ethernet/broadcom/genet/bcmgenet.h2
-rw-r--r--drivers/net/ethernet/broadcom/genet/bcmmii.c7
3 files changed, 5 insertions, 6 deletions
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index fbab7757adfa..5bf7ce0ae221 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -3364,7 +3364,7 @@ static int bcmgenet_resume(struct device *d)
3364 3364
3365 phy_init_hw(priv->phydev); 3365 phy_init_hw(priv->phydev);
3366 /* Speed settings must be restored */ 3366 /* Speed settings must be restored */
3367 bcmgenet_mii_config(priv->dev, false); 3367 bcmgenet_mii_config(priv->dev);
3368 3368
3369 /* disable ethernet MAC while updating its registers */ 3369 /* disable ethernet MAC while updating its registers */
3370 umac_enable_set(priv, CMD_TX_EN | CMD_RX_EN, false); 3370 umac_enable_set(priv, CMD_TX_EN | CMD_RX_EN, false);
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
index e25b5327cc40..7299d1075422 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.h
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
@@ -671,7 +671,7 @@ GENET_IO_MACRO(rbuf, GENET_RBUF_OFF);
671 671
672/* MDIO routines */ 672/* MDIO routines */
673int bcmgenet_mii_init(struct net_device *dev); 673int bcmgenet_mii_init(struct net_device *dev);
674int bcmgenet_mii_config(struct net_device *dev, bool init); 674int bcmgenet_mii_config(struct net_device *dev);
675int bcmgenet_mii_probe(struct net_device *dev); 675int bcmgenet_mii_probe(struct net_device *dev);
676void bcmgenet_mii_exit(struct net_device *dev); 676void bcmgenet_mii_exit(struct net_device *dev);
677void bcmgenet_phy_power_set(struct net_device *dev, bool enable); 677void bcmgenet_phy_power_set(struct net_device *dev, bool enable);
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
index b503897a0da3..0802cd9d2424 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -217,7 +217,7 @@ static void bcmgenet_moca_phy_setup(struct bcmgenet_priv *priv)
217 bcmgenet_sys_writel(priv, reg, SYS_PORT_CTRL); 217 bcmgenet_sys_writel(priv, reg, SYS_PORT_CTRL);
218} 218}
219 219
220int bcmgenet_mii_config(struct net_device *dev, bool init) 220int bcmgenet_mii_config(struct net_device *dev)
221{ 221{
222 struct bcmgenet_priv *priv = netdev_priv(dev); 222 struct bcmgenet_priv *priv = netdev_priv(dev);
223 struct phy_device *phydev = priv->phydev; 223 struct phy_device *phydev = priv->phydev;
@@ -310,8 +310,7 @@ int bcmgenet_mii_config(struct net_device *dev, bool init)
310 bcmgenet_ext_writel(priv, reg, EXT_RGMII_OOB_CTRL); 310 bcmgenet_ext_writel(priv, reg, EXT_RGMII_OOB_CTRL);
311 } 311 }
312 312
313 if (init) 313 dev_info_once(kdev, "configuring instance for %s\n", phy_name);
314 dev_info(kdev, "configuring instance for %s\n", phy_name);
315 314
316 return 0; 315 return 0;
317} 316}
@@ -359,7 +358,7 @@ int bcmgenet_mii_probe(struct net_device *dev)
359 * PHY speed which is needed for bcmgenet_mii_config() to configure 358 * PHY speed which is needed for bcmgenet_mii_config() to configure
360 * things appropriately. 359 * things appropriately.
361 */ 360 */
362 ret = bcmgenet_mii_config(dev, true); 361 ret = bcmgenet_mii_config(dev);
363 if (ret) { 362 if (ret) {
364 phy_disconnect(priv->phydev); 363 phy_disconnect(priv->phydev);
365 return ret; 364 return ret;