aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
diff options
context:
space:
mode:
authorIyappan Subramanian <isubramanian@apm.com>2017-05-10 16:45:10 -0400
committerDavid S. Miller <davem@davemloft.net>2017-05-16 11:41:11 -0400
commit8aba8474181070a30f56ffd19359f5d80665175e (patch)
treeaa4c16c1409054f2a1a78b1dc89c7ce71f015131 /drivers/net/ethernet/apm/xgene/xgene_enet_main.c
parent61c759cdf48a21e0a0794d30c509c49cbdbac752 (diff)
drivers: net: xgene: Fix redundant prefetch buffer cleanup
Prefetch buffer cleanup code was called twice, causing EDAC to report errors during reboot. [ 1130.972475] xgene-edac 78800000.edac: IOB bridge agent (BA) transaction error [ 1130.979584] xgene-edac 78800000.edac: IOB BA write response error [ 1130.985648] xgene-edac 78800000.edac: IOB BA write access at 0x00.00000000 () [ 1130.993612] xgene-edac 78800000.edac: IOB BA requestor ID 0x00002400 [ 1131.000242] xgene-edac 78800000.edac: IOB bridge agent (BA) transaction error ... This patch fixes the errors by, - removing the redundant prefetch buffer cleanup from port_ops->shutdown() - moving port_ops->shutdown() after delete_rings() Signed-off-by: Iyappan Subramanian <isubramanian@apm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/apm/xgene/xgene_enet_main.c')
-rw-r--r--drivers/net/ethernet/apm/xgene/xgene_enet_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 01e389df3aff..21cd4ef3e5eb 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -2159,8 +2159,8 @@ static int xgene_enet_remove(struct platform_device *pdev)
2159 xgene_enet_mdio_remove(pdata); 2159 xgene_enet_mdio_remove(pdata);
2160 2160
2161 unregister_netdev(ndev); 2161 unregister_netdev(ndev);
2162 pdata->port_ops->shutdown(pdata);
2163 xgene_enet_delete_desc_rings(pdata); 2162 xgene_enet_delete_desc_rings(pdata);
2163 pdata->port_ops->shutdown(pdata);
2164 free_netdev(ndev); 2164 free_netdev(ndev);
2165 2165
2166 return 0; 2166 return 0;