aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/adi
diff options
context:
space:
mode:
authorJingoo Han <jg1.han@samsung.com>2013-05-27 15:01:12 -0400
committerDavid S. Miller <davem@davemloft.net>2013-05-28 01:34:51 -0400
commitdfd93c977d84fef77404b689ef95bc716b313533 (patch)
treeab1084c9933e81cd603f5b01d3f50b53dc2d2f5d /drivers/net/ethernet/adi
parent3acfeac351c6ab2fe1139ee13d780729af0c8145 (diff)
net: ethernet: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Acked-by: Rob Herring <rob.herring@calxeda.com> Acked-by: Roland Stigge <stigge@antcom.de> Acked-by: Mugunthan V N <mugunthanvnm@ti.com> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> Tested-by: Roland Stigge <stigge@antcom.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/adi')
-rw-r--r--drivers/net/ethernet/adi/bfin_mac.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
index dada66bfe0d6..e904b3838dcc 100644
--- a/drivers/net/ethernet/adi/bfin_mac.c
+++ b/drivers/net/ethernet/adi/bfin_mac.c
@@ -1719,7 +1719,6 @@ out_err_mii_probe:
1719 mdiobus_unregister(lp->mii_bus); 1719 mdiobus_unregister(lp->mii_bus);
1720 mdiobus_free(lp->mii_bus); 1720 mdiobus_free(lp->mii_bus);
1721out_err_probe_mac: 1721out_err_probe_mac:
1722 platform_set_drvdata(pdev, NULL);
1723 free_netdev(ndev); 1722 free_netdev(ndev);
1724 1723
1725 return rc; 1724 return rc;
@@ -1732,8 +1731,6 @@ static int bfin_mac_remove(struct platform_device *pdev)
1732 1731
1733 bfin_phc_release(lp); 1732 bfin_phc_release(lp);
1734 1733
1735 platform_set_drvdata(pdev, NULL);
1736
1737 lp->mii_bus->priv = NULL; 1734 lp->mii_bus->priv = NULL;
1738 1735
1739 unregister_netdev(ndev); 1736 unregister_netdev(ndev);
@@ -1868,7 +1865,6 @@ static int bfin_mii_bus_remove(struct platform_device *pdev)
1868 struct bfin_mii_bus_platform_data *mii_bus_pd = 1865 struct bfin_mii_bus_platform_data *mii_bus_pd =
1869 dev_get_platdata(&pdev->dev); 1866 dev_get_platdata(&pdev->dev);
1870 1867
1871 platform_set_drvdata(pdev, NULL);
1872 mdiobus_unregister(miibus); 1868 mdiobus_unregister(miibus);
1873 kfree(miibus->irq); 1869 kfree(miibus->irq);
1874 mdiobus_free(miibus); 1870 mdiobus_free(miibus);