diff options
author | Florian Fainelli <f.fainelli@gmail.com> | 2014-09-12 00:18:09 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-09-13 17:04:35 -0400 |
commit | ac7a04c33dd7f8e429df4b929ba3a3e8e729cc89 (patch) | |
tree | 5b1e76c258c08ef39fdcf5e469a05e0322ffb228 /drivers/net/dsa | |
parent | c55542983e572bcac813fd9a393e725e158074be (diff) |
net: dsa: change tag_protocol to an enum
Now that we introduced an additional multiplexing/demultiplexing layer
with commit 3e8a72d1dae37 ("net: dsa: reduce number of protocol hooks")
that lives within the DSA code, we no longer need to have a given switch
driver tag_protocol be an actual ethertype value, instead, we can
replace it with an enum: dsa_tag_protocol.
Do this replacement in the drivers, which allows us to get rid of the
cpu_to_be16()/htons() dance, and remove ETH_P_BRCMTAG since we do not
need it anymore.
Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
-rw-r--r-- | drivers/net/dsa/bcm_sf2.c | 2 | ||||
-rw-r--r-- | drivers/net/dsa/mv88e6060.c | 2 | ||||
-rw-r--r-- | drivers/net/dsa/mv88e6123_61_65.c | 4 | ||||
-rw-r--r-- | drivers/net/dsa/mv88e6131.c | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index bb7cb8e283b1..e9918c7f1792 100644 --- a/drivers/net/dsa/bcm_sf2.c +++ b/drivers/net/dsa/bcm_sf2.c | |||
@@ -592,7 +592,7 @@ static void bcm_sf2_sw_fixed_link_update(struct dsa_switch *ds, int port, | |||
592 | } | 592 | } |
593 | 593 | ||
594 | static struct dsa_switch_driver bcm_sf2_switch_driver = { | 594 | static struct dsa_switch_driver bcm_sf2_switch_driver = { |
595 | .tag_protocol = htons(ETH_P_BRCMTAG), | 595 | .tag_protocol = DSA_TAG_PROTO_BRCM, |
596 | .priv_size = sizeof(struct bcm_sf2_priv), | 596 | .priv_size = sizeof(struct bcm_sf2_priv), |
597 | .probe = bcm_sf2_sw_probe, | 597 | .probe = bcm_sf2_sw_probe, |
598 | .setup = bcm_sf2_sw_setup, | 598 | .setup = bcm_sf2_sw_setup, |
diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c index 7a54ec04b418..d8037c1055ac 100644 --- a/drivers/net/dsa/mv88e6060.c +++ b/drivers/net/dsa/mv88e6060.c | |||
@@ -258,7 +258,7 @@ static void mv88e6060_poll_link(struct dsa_switch *ds) | |||
258 | } | 258 | } |
259 | 259 | ||
260 | static struct dsa_switch_driver mv88e6060_switch_driver = { | 260 | static struct dsa_switch_driver mv88e6060_switch_driver = { |
261 | .tag_protocol = htons(ETH_P_TRAILER), | 261 | .tag_protocol = DSA_TAG_PROTO_TRAILER, |
262 | .probe = mv88e6060_probe, | 262 | .probe = mv88e6060_probe, |
263 | .setup = mv88e6060_setup, | 263 | .setup = mv88e6060_setup, |
264 | .set_addr = mv88e6060_set_addr, | 264 | .set_addr = mv88e6060_set_addr, |
diff --git a/drivers/net/dsa/mv88e6123_61_65.c b/drivers/net/dsa/mv88e6123_61_65.c index 69c42513dd72..975774f338c2 100644 --- a/drivers/net/dsa/mv88e6123_61_65.c +++ b/drivers/net/dsa/mv88e6123_61_65.c | |||
@@ -207,7 +207,7 @@ static int mv88e6123_61_65_setup_port(struct dsa_switch *ds, int p) | |||
207 | */ | 207 | */ |
208 | val = 0x0433; | 208 | val = 0x0433; |
209 | if (dsa_is_cpu_port(ds, p)) { | 209 | if (dsa_is_cpu_port(ds, p)) { |
210 | if (ds->dst->tag_protocol == htons(ETH_P_EDSA)) | 210 | if (ds->dst->tag_protocol == DSA_TAG_PROTO_EDSA) |
211 | val |= 0x3300; | 211 | val |= 0x3300; |
212 | else | 212 | else |
213 | val |= 0x0100; | 213 | val |= 0x0100; |
@@ -391,7 +391,7 @@ static int mv88e6123_61_65_get_sset_count(struct dsa_switch *ds) | |||
391 | } | 391 | } |
392 | 392 | ||
393 | struct dsa_switch_driver mv88e6123_61_65_switch_driver = { | 393 | struct dsa_switch_driver mv88e6123_61_65_switch_driver = { |
394 | .tag_protocol = cpu_to_be16(ETH_P_EDSA), | 394 | .tag_protocol = DSA_TAG_PROTO_EDSA, |
395 | .priv_size = sizeof(struct mv88e6xxx_priv_state), | 395 | .priv_size = sizeof(struct mv88e6xxx_priv_state), |
396 | .probe = mv88e6123_61_65_probe, | 396 | .probe = mv88e6123_61_65_probe, |
397 | .setup = mv88e6123_61_65_setup, | 397 | .setup = mv88e6123_61_65_setup, |
diff --git a/drivers/net/dsa/mv88e6131.c b/drivers/net/dsa/mv88e6131.c index 953bc6a49e59..35541f2ceca3 100644 --- a/drivers/net/dsa/mv88e6131.c +++ b/drivers/net/dsa/mv88e6131.c | |||
@@ -379,7 +379,7 @@ static int mv88e6131_get_sset_count(struct dsa_switch *ds) | |||
379 | } | 379 | } |
380 | 380 | ||
381 | struct dsa_switch_driver mv88e6131_switch_driver = { | 381 | struct dsa_switch_driver mv88e6131_switch_driver = { |
382 | .tag_protocol = cpu_to_be16(ETH_P_DSA), | 382 | .tag_protocol = DSA_TAG_PROTO_DSA, |
383 | .priv_size = sizeof(struct mv88e6xxx_priv_state), | 383 | .priv_size = sizeof(struct mv88e6xxx_priv_state), |
384 | .probe = mv88e6131_probe, | 384 | .probe = mv88e6131_probe, |
385 | .setup = mv88e6131_setup, | 385 | .setup = mv88e6131_setup, |