aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/can/usb/peak_usb
diff options
context:
space:
mode:
authorDavid S. Miller <davem@davemloft.net>2012-11-30 12:12:05 -0500
committerDavid S. Miller <davem@davemloft.net>2012-11-30 12:12:05 -0500
commitfed2c6fd1ffb7b24e55159eb40a5a7330be656c8 (patch)
tree0b3ec505cbe89f0f026897e32b8bb73ffb6a5fd8 /drivers/net/can/usb/peak_usb
parent481af03bfbc1e07954310689831ad2695b7c6a44 (diff)
parent823d7a1f761d6404babaab04cc8b1724186cf2c8 (diff)
Merge branch 'for-davem' of git://gitorious.org/linux-can/linux-can-next
Marc Kleine-Budde says: ==================== this pull request is for net-next/master. There is a patch by Alexander Stein fixing a reference counter problem which can make driver unloading impossible (stable Cc'ed). And several patches by me which remove an obsolete mechanism from several drivers, which is already handled at the infrastructure level. ==================== Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/can/usb/peak_usb')
-rw-r--r--drivers/net/can/usb/peak_usb/pcan_usb_core.c5
-rw-r--r--drivers/net/can/usb/peak_usb/pcan_usb_core.h1
2 files changed, 0 insertions, 6 deletions
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
index c4643c400d46..d9290ea788e0 100644
--- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c
+++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c
@@ -520,7 +520,6 @@ static int peak_usb_ndo_open(struct net_device *netdev)
520 return err; 520 return err;
521 } 521 }
522 522
523 dev->open_time = jiffies;
524 netif_start_queue(netdev); 523 netif_start_queue(netdev);
525 524
526 return 0; 525 return 0;
@@ -576,7 +575,6 @@ static int peak_usb_ndo_stop(struct net_device *netdev)
576 575
577 close_candev(netdev); 576 close_candev(netdev);
578 577
579 dev->open_time = 0;
580 dev->can.state = CAN_STATE_STOPPED; 578 dev->can.state = CAN_STATE_STOPPED;
581 579
582 /* can set bus off now */ 580 /* can set bus off now */
@@ -661,9 +659,6 @@ static int peak_usb_set_mode(struct net_device *netdev, enum can_mode mode)
661 struct peak_usb_device *dev = netdev_priv(netdev); 659 struct peak_usb_device *dev = netdev_priv(netdev);
662 int err = 0; 660 int err = 0;
663 661
664 if (!dev->open_time)
665 return -EINVAL;
666
667 switch (mode) { 662 switch (mode) {
668 case CAN_MODE_START: 663 case CAN_MODE_START:
669 err = peak_usb_restart(dev); 664 err = peak_usb_restart(dev);
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.h b/drivers/net/can/usb/peak_usb/pcan_usb_core.h
index c8e5e91d7cb5..073b47ff8eee 100644
--- a/drivers/net/can/usb/peak_usb/pcan_usb_core.h
+++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.h
@@ -104,7 +104,6 @@ struct peak_usb_device {
104 struct can_priv can; 104 struct can_priv can;
105 struct peak_usb_adapter *adapter; 105 struct peak_usb_adapter *adapter;
106 unsigned int ctrl_idx; 106 unsigned int ctrl_idx;
107 int open_time;
108 u32 state; 107 u32 state;
109 108
110 struct sk_buff *echo_skb[PCAN_USB_MAX_TX_URBS]; 109 struct sk_buff *echo_skb[PCAN_USB_MAX_TX_URBS];