diff options
author | Joe Perches <joe@perches.com> | 2015-05-05 13:05:55 -0400 |
---|---|---|
committer | Michael Grzeschik <m.grzeschik@pengutronix.de> | 2015-09-23 02:44:24 -0400 |
commit | a34c0932c3b2f28542825ffc5280d562c49ad42d (patch) | |
tree | 2fd465fe1c93b7ea866af66847c7167f81bff47a /drivers/net/arcnet/com20020.c | |
parent | 72aeea4841c037b9b3abf65859673cbd7b6664a9 (diff) |
arcnet: Convert BUGMSG and BUGMSG2 to arc_prink and arc_cont
These macros don't actually represent BUG uses but are more commonly
used as logging macros, so use a more kernel style macro.
Convert the BUGMSG from a netdev_ like use to actually use netdev_<level>.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Diffstat (limited to 'drivers/net/arcnet/com20020.c')
-rw-r--r-- | drivers/net/arcnet/com20020.c | 64 |
1 files changed, 33 insertions, 31 deletions
diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index 3170e8ebb7fa..b0b8a0be08e5 100644 --- a/drivers/net/arcnet/com20020.c +++ b/drivers/net/arcnet/com20020.c | |||
@@ -68,7 +68,7 @@ static void com20020_copy_from_card(struct net_device *dev, int bufnum, | |||
68 | outb(ofs & 0xff, _ADDR_LO); | 68 | outb(ofs & 0xff, _ADDR_LO); |
69 | 69 | ||
70 | /* copy the data */ | 70 | /* copy the data */ |
71 | TIME("insb", count, insb(_MEMDATA, buf, count)); | 71 | TIME(dev, "insb", count, insb(_MEMDATA, buf, count)); |
72 | } | 72 | } |
73 | 73 | ||
74 | static void com20020_copy_to_card(struct net_device *dev, int bufnum, | 74 | static void com20020_copy_to_card(struct net_device *dev, int bufnum, |
@@ -81,7 +81,7 @@ static void com20020_copy_to_card(struct net_device *dev, int bufnum, | |||
81 | outb(ofs & 0xff, _ADDR_LO); | 81 | outb(ofs & 0xff, _ADDR_LO); |
82 | 82 | ||
83 | /* copy the data */ | 83 | /* copy the data */ |
84 | TIME("outsb", count, outsb(_MEMDATA, buf, count)); | 84 | TIME(dev, "outsb", count, outsb(_MEMDATA, buf, count)); |
85 | } | 85 | } |
86 | 86 | ||
87 | /* Reset the card and check some basic stuff during the detection stage. */ | 87 | /* Reset the card and check some basic stuff during the detection stage. */ |
@@ -120,10 +120,10 @@ int com20020_check(struct net_device *dev) | |||
120 | status = ASTATUS(); | 120 | status = ASTATUS(); |
121 | 121 | ||
122 | if ((status & 0x99) != (NORXflag | TXFREEflag | RESETflag)) { | 122 | if ((status & 0x99) != (NORXflag | TXFREEflag | RESETflag)) { |
123 | BUGMSG(D_NORMAL, "status invalid (%Xh).\n", status); | 123 | arc_printk(D_NORMAL, dev, "status invalid (%Xh).\n", status); |
124 | return -ENODEV; | 124 | return -ENODEV; |
125 | } | 125 | } |
126 | BUGMSG(D_INIT_REASONS, "status after reset: %X\n", status); | 126 | arc_printk(D_INIT_REASONS, dev, "status after reset: %X\n", status); |
127 | 127 | ||
128 | /* Enable TX */ | 128 | /* Enable TX */ |
129 | outb(0x39, _CONFIG); | 129 | outb(0x39, _CONFIG); |
@@ -132,16 +132,16 @@ int com20020_check(struct net_device *dev) | |||
132 | ACOMMAND(CFLAGScmd | RESETclear | CONFIGclear); | 132 | ACOMMAND(CFLAGScmd | RESETclear | CONFIGclear); |
133 | 133 | ||
134 | status = ASTATUS(); | 134 | status = ASTATUS(); |
135 | BUGMSG(D_INIT_REASONS, "status after reset acknowledged: %X\n", | 135 | arc_printk(D_INIT_REASONS, dev, "status after reset acknowledged: %X\n", |
136 | status); | 136 | status); |
137 | 137 | ||
138 | /* Read first location of memory */ | 138 | /* Read first location of memory */ |
139 | outb(0 | RDDATAflag | AUTOINCflag, _ADDR_HI); | 139 | outb(0 | RDDATAflag | AUTOINCflag, _ADDR_HI); |
140 | outb(0, _ADDR_LO); | 140 | outb(0, _ADDR_LO); |
141 | 141 | ||
142 | if ((status = inb(_MEMDATA)) != TESTvalue) { | 142 | if ((status = inb(_MEMDATA)) != TESTvalue) { |
143 | BUGMSG(D_NORMAL, "Signature byte not found (%02Xh != D1h).\n", | 143 | arc_printk(D_NORMAL, dev, "Signature byte not found (%02Xh != D1h).\n", |
144 | status); | 144 | status); |
145 | return -ENODEV; | 145 | return -ENODEV; |
146 | } | 146 | } |
147 | return 0; | 147 | return 0; |
@@ -213,24 +213,25 @@ int com20020_found(struct net_device *dev, int shared) | |||
213 | /* reserve the irq */ | 213 | /* reserve the irq */ |
214 | if (request_irq(dev->irq, arcnet_interrupt, shared, | 214 | if (request_irq(dev->irq, arcnet_interrupt, shared, |
215 | "arcnet (COM20020)", dev)) { | 215 | "arcnet (COM20020)", dev)) { |
216 | BUGMSG(D_NORMAL, "Can't get IRQ %d!\n", dev->irq); | 216 | arc_printk(D_NORMAL, dev, "Can't get IRQ %d!\n", dev->irq); |
217 | return -ENODEV; | 217 | return -ENODEV; |
218 | } | 218 | } |
219 | 219 | ||
220 | dev->base_addr = ioaddr; | 220 | dev->base_addr = ioaddr; |
221 | 221 | ||
222 | BUGMSG(D_NORMAL, "%s: station %02Xh found at %03lXh, IRQ %d.\n", | 222 | arc_printk(D_NORMAL, dev, "%s: station %02Xh found at %03lXh, IRQ %d.\n", |
223 | lp->card_name, dev->dev_addr[0], dev->base_addr, dev->irq); | 223 | lp->card_name, dev->dev_addr[0], dev->base_addr, dev->irq); |
224 | 224 | ||
225 | if (lp->backplane) | 225 | if (lp->backplane) |
226 | BUGMSG(D_NORMAL, "Using backplane mode.\n"); | 226 | arc_printk(D_NORMAL, dev, "Using backplane mode.\n"); |
227 | 227 | ||
228 | if (lp->timeout != 3) | 228 | if (lp->timeout != 3) |
229 | BUGMSG(D_NORMAL, "Using extended timeout value of %d.\n", lp->timeout); | 229 | arc_printk(D_NORMAL, dev, "Using extended timeout value of %d\n", |
230 | lp->timeout); | ||
230 | 231 | ||
231 | BUGMSG(D_NORMAL, "Using CKP %d - data rate %s.\n", | 232 | arc_printk(D_NORMAL, dev, "Using CKP %d - data rate %s\n", |
232 | lp->setup >> 1, | 233 | lp->setup >> 1, |
233 | clockrates[3 - ((lp->setup2 & 0xF0) >> 4) + ((lp->setup & 0x0F) >> 1)]); | 234 | clockrates[3 - ((lp->setup2 & 0xF0) >> 4) + ((lp->setup & 0x0F) >> 1)]); |
234 | 235 | ||
235 | if (register_netdev(dev)) { | 236 | if (register_netdev(dev)) { |
236 | free_irq(dev->irq, dev); | 237 | free_irq(dev->irq, dev); |
@@ -252,16 +253,16 @@ static int com20020_reset(struct net_device *dev, int really_reset) | |||
252 | u_int ioaddr = dev->base_addr; | 253 | u_int ioaddr = dev->base_addr; |
253 | u_char inbyte; | 254 | u_char inbyte; |
254 | 255 | ||
255 | BUGMSG(D_DEBUG, "%s: %d: %s: dev: %p, lp: %p, dev->name: %s\n", | 256 | arc_printk(D_DEBUG, dev, "%s: %d: %s: dev: %p, lp: %p, dev->name: %s\n", |
256 | __FILE__, __LINE__, __func__, dev, lp, dev->name); | 257 | __FILE__, __LINE__, __func__, dev, lp, dev->name); |
257 | BUGMSG(D_INIT, "Resetting %s (status=%02Xh)\n", | 258 | arc_printk(D_INIT, dev, "Resetting %s (status=%02Xh)\n", |
258 | dev->name, ASTATUS()); | 259 | dev->name, ASTATUS()); |
259 | 260 | ||
260 | BUGMSG(D_DEBUG, "%s: %d: %s\n", __FILE__, __LINE__, __func__); | 261 | arc_printk(D_DEBUG, dev, "%s: %d: %s\n", __FILE__, __LINE__, __func__); |
261 | lp->config = TXENcfg | (lp->timeout << 3) | (lp->backplane << 2); | 262 | lp->config = TXENcfg | (lp->timeout << 3) | (lp->backplane << 2); |
262 | /* power-up defaults */ | 263 | /* power-up defaults */ |
263 | SETCONF; | 264 | SETCONF; |
264 | BUGMSG(D_DEBUG, "%s: %d: %s\n", __FILE__, __LINE__, __func__); | 265 | arc_printk(D_DEBUG, dev, "%s: %d: %s\n", __FILE__, __LINE__, __func__); |
265 | 266 | ||
266 | if (really_reset) { | 267 | if (really_reset) { |
267 | /* reset the card */ | 268 | /* reset the card */ |
@@ -269,22 +270,23 @@ static int com20020_reset(struct net_device *dev, int really_reset) | |||
269 | mdelay(RESETtime * 2); /* COM20020 seems to be slower sometimes */ | 270 | mdelay(RESETtime * 2); /* COM20020 seems to be slower sometimes */ |
270 | } | 271 | } |
271 | /* clear flags & end reset */ | 272 | /* clear flags & end reset */ |
272 | BUGMSG(D_DEBUG, "%s: %d: %s\n", __FILE__, __LINE__, __func__); | 273 | arc_printk(D_DEBUG, dev, "%s: %d: %s\n", __FILE__, __LINE__, __func__); |
273 | ACOMMAND(CFLAGScmd | RESETclear | CONFIGclear); | 274 | ACOMMAND(CFLAGScmd | RESETclear | CONFIGclear); |
274 | 275 | ||
275 | /* verify that the ARCnet signature byte is present */ | 276 | /* verify that the ARCnet signature byte is present */ |
276 | BUGMSG(D_DEBUG, "%s: %d: %s\n", __FILE__, __LINE__, __func__); | 277 | arc_printk(D_DEBUG, dev, "%s: %d: %s\n", __FILE__, __LINE__, __func__); |
277 | 278 | ||
278 | com20020_copy_from_card(dev, 0, 0, &inbyte, 1); | 279 | com20020_copy_from_card(dev, 0, 0, &inbyte, 1); |
279 | BUGMSG(D_DEBUG, "%s: %d: %s\n", __FILE__, __LINE__, __func__); | 280 | arc_printk(D_DEBUG, dev, "%s: %d: %s\n", __FILE__, __LINE__, __func__); |
280 | if (inbyte != TESTvalue) { | 281 | if (inbyte != TESTvalue) { |
281 | BUGMSG(D_DEBUG, "%s: %d: %s\n", __FILE__, __LINE__, __func__); | 282 | arc_printk(D_DEBUG, dev, "%s: %d: %s\n", |
282 | BUGMSG(D_NORMAL, "reset failed: TESTvalue not present.\n"); | 283 | __FILE__, __LINE__, __func__); |
284 | arc_printk(D_NORMAL, dev, "reset failed: TESTvalue not present.\n"); | ||
283 | return 1; | 285 | return 1; |
284 | } | 286 | } |
285 | /* enable extended (512-byte) packets */ | 287 | /* enable extended (512-byte) packets */ |
286 | ACOMMAND(CONFIGcmd | EXTconf); | 288 | ACOMMAND(CONFIGcmd | EXTconf); |
287 | BUGMSG(D_DEBUG, "%s: %d: %s\n", __FILE__, __LINE__, __func__); | 289 | arc_printk(D_DEBUG, dev, "%s: %d: %s\n", __FILE__, __LINE__, __func__); |
288 | 290 | ||
289 | /* done! return success. */ | 291 | /* done! return success. */ |
290 | return 0; | 292 | return 0; |
@@ -294,7 +296,7 @@ static void com20020_setmask(struct net_device *dev, int mask) | |||
294 | { | 296 | { |
295 | u_int ioaddr = dev->base_addr; | 297 | u_int ioaddr = dev->base_addr; |
296 | 298 | ||
297 | BUGMSG(D_DURING, "Setting mask to %x at %x\n", mask, ioaddr); | 299 | arc_printk(D_DURING, dev, "Setting mask to %x at %x\n", mask, ioaddr); |
298 | AINTMASK(mask); | 300 | AINTMASK(mask); |
299 | } | 301 | } |
300 | 302 | ||
@@ -336,7 +338,7 @@ static void com20020_set_mc_list(struct net_device *dev) | |||
336 | 338 | ||
337 | if ((dev->flags & IFF_PROMISC) && (dev->flags & IFF_UP)) { /* Enable promiscuous mode */ | 339 | if ((dev->flags & IFF_PROMISC) && (dev->flags & IFF_UP)) { /* Enable promiscuous mode */ |
338 | if (!(lp->setup & PROMISCset)) | 340 | if (!(lp->setup & PROMISCset)) |
339 | BUGMSG(D_NORMAL, "Setting promiscuous flag...\n"); | 341 | arc_printk(D_NORMAL, dev, "Setting promiscuous flag...\n"); |
340 | SET_SUBADR(SUB_SETUP1); | 342 | SET_SUBADR(SUB_SETUP1); |
341 | lp->setup |= PROMISCset; | 343 | lp->setup |= PROMISCset; |
342 | outb(lp->setup, _XREG); | 344 | outb(lp->setup, _XREG); |
@@ -344,7 +346,7 @@ static void com20020_set_mc_list(struct net_device *dev) | |||
344 | /* Disable promiscuous mode, use normal mode */ | 346 | /* Disable promiscuous mode, use normal mode */ |
345 | { | 347 | { |
346 | if ((lp->setup & PROMISCset)) | 348 | if ((lp->setup & PROMISCset)) |
347 | BUGMSG(D_NORMAL, "Resetting promiscuous flag...\n"); | 349 | arc_printk(D_NORMAL, dev, "Resetting promiscuous flag...\n"); |
348 | SET_SUBADR(SUB_SETUP1); | 350 | SET_SUBADR(SUB_SETUP1); |
349 | lp->setup &= ~PROMISCset; | 351 | lp->setup &= ~PROMISCset; |
350 | outb(lp->setup, _XREG); | 352 | outb(lp->setup, _XREG); |