aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mmc
diff options
context:
space:
mode:
authorDong Aisheng <aisheng.dong@nxp.com>2016-04-15 13:29:25 -0400
committerUlf Hansson <ulf.hansson@linaro.org>2016-05-16 05:31:25 -0400
commitded97e0b165076556714d4a5708c87f5bcf03783 (patch)
tree245e330bbaffca0866aaf4568de123be584a269a /drivers/mmc
parent0400ed0a083a6567d45df96fb813f4702ece7d1b (diff)
mmc: sdhci: removed unneeded function wrappers
After commit d6463f170cf0 ("mmc: sdhci: Remove redundant runtime PM calls"), some of original sdhci_do_xx() function wrappers becomes meaningless, so remove them. Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to 'drivers/mmc')
-rw-r--r--drivers/mmc/host/sdhci.c60
1 files changed, 15 insertions, 45 deletions
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 94cffa77490a..e010ea4eb6f5 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -48,7 +48,7 @@ static void sdhci_finish_data(struct sdhci_host *);
48static void sdhci_finish_command(struct sdhci_host *); 48static void sdhci_finish_command(struct sdhci_host *);
49static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode); 49static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode);
50static void sdhci_enable_preset_value(struct sdhci_host *host, bool enable); 50static void sdhci_enable_preset_value(struct sdhci_host *host, bool enable);
51static int sdhci_do_get_cd(struct sdhci_host *host); 51static int sdhci_get_cd(struct mmc_host *mmc);
52 52
53static void sdhci_dumpregs(struct sdhci_host *host) 53static void sdhci_dumpregs(struct sdhci_host *host)
54{ 54{
@@ -193,7 +193,7 @@ EXPORT_SYMBOL_GPL(sdhci_reset);
193static void sdhci_do_reset(struct sdhci_host *host, u8 mask) 193static void sdhci_do_reset(struct sdhci_host *host, u8 mask)
194{ 194{
195 if (host->quirks & SDHCI_QUIRK_NO_CARD_NO_RESET) { 195 if (host->quirks & SDHCI_QUIRK_NO_CARD_NO_RESET) {
196 if (!sdhci_do_get_cd(host)) 196 if (!sdhci_get_cd(host->mmc))
197 return; 197 return;
198 } 198 }
199 199
@@ -1450,11 +1450,11 @@ void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing)
1450} 1450}
1451EXPORT_SYMBOL_GPL(sdhci_set_uhs_signaling); 1451EXPORT_SYMBOL_GPL(sdhci_set_uhs_signaling);
1452 1452
1453static void sdhci_do_set_ios(struct sdhci_host *host, struct mmc_ios *ios) 1453static void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
1454{ 1454{
1455 struct sdhci_host *host = mmc_priv(mmc);
1455 unsigned long flags; 1456 unsigned long flags;
1456 u8 ctrl; 1457 u8 ctrl;
1457 struct mmc_host *mmc = host->mmc;
1458 1458
1459 spin_lock_irqsave(&host->lock, flags); 1459 spin_lock_irqsave(&host->lock, flags);
1460 1460
@@ -1608,16 +1608,10 @@ static void sdhci_do_set_ios(struct sdhci_host *host, struct mmc_ios *ios)
1608 spin_unlock_irqrestore(&host->lock, flags); 1608 spin_unlock_irqrestore(&host->lock, flags);
1609} 1609}
1610 1610
1611static void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) 1611static int sdhci_get_cd(struct mmc_host *mmc)
1612{ 1612{
1613 struct sdhci_host *host = mmc_priv(mmc); 1613 struct sdhci_host *host = mmc_priv(mmc);
1614 1614 int gpio_cd = mmc_gpio_get_cd(mmc);
1615 sdhci_do_set_ios(host, ios);
1616}
1617
1618static int sdhci_do_get_cd(struct sdhci_host *host)
1619{
1620 int gpio_cd = mmc_gpio_get_cd(host->mmc);
1621 1615
1622 if (host->flags & SDHCI_DEVICE_DEAD) 1616 if (host->flags & SDHCI_DEVICE_DEAD)
1623 return 0; 1617 return 0;
@@ -1641,13 +1635,6 @@ static int sdhci_do_get_cd(struct sdhci_host *host)
1641 return !!(sdhci_readl(host, SDHCI_PRESENT_STATE) & SDHCI_CARD_PRESENT); 1635 return !!(sdhci_readl(host, SDHCI_PRESENT_STATE) & SDHCI_CARD_PRESENT);
1642} 1636}
1643 1637
1644static int sdhci_get_cd(struct mmc_host *mmc)
1645{
1646 struct sdhci_host *host = mmc_priv(mmc);
1647
1648 return sdhci_do_get_cd(host);
1649}
1650
1651static int sdhci_check_ro(struct sdhci_host *host) 1638static int sdhci_check_ro(struct sdhci_host *host)
1652{ 1639{
1653 unsigned long flags; 1640 unsigned long flags;
@@ -1672,8 +1659,9 @@ static int sdhci_check_ro(struct sdhci_host *host)
1672 1659
1673#define SAMPLE_COUNT 5 1660#define SAMPLE_COUNT 5
1674 1661
1675static int sdhci_do_get_ro(struct sdhci_host *host) 1662static int sdhci_get_ro(struct mmc_host *mmc)
1676{ 1663{
1664 struct sdhci_host *host = mmc_priv(mmc);
1677 int i, ro_count; 1665 int i, ro_count;
1678 1666
1679 if (!(host->quirks & SDHCI_QUIRK_UNSTABLE_RO_DETECT)) 1667 if (!(host->quirks & SDHCI_QUIRK_UNSTABLE_RO_DETECT))
@@ -1698,13 +1686,6 @@ static void sdhci_hw_reset(struct mmc_host *mmc)
1698 host->ops->hw_reset(host); 1686 host->ops->hw_reset(host);
1699} 1687}
1700 1688
1701static int sdhci_get_ro(struct mmc_host *mmc)
1702{
1703 struct sdhci_host *host = mmc_priv(mmc);
1704
1705 return sdhci_do_get_ro(host);
1706}
1707
1708static void sdhci_enable_sdio_irq_nolock(struct sdhci_host *host, int enable) 1689static void sdhci_enable_sdio_irq_nolock(struct sdhci_host *host, int enable)
1709{ 1690{
1710 if (!(host->flags & SDHCI_DEVICE_DEAD)) { 1691 if (!(host->flags & SDHCI_DEVICE_DEAD)) {
@@ -1734,10 +1715,10 @@ static void sdhci_enable_sdio_irq(struct mmc_host *mmc, int enable)
1734 spin_unlock_irqrestore(&host->lock, flags); 1715 spin_unlock_irqrestore(&host->lock, flags);
1735} 1716}
1736 1717
1737static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, 1718static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc,
1738 struct mmc_ios *ios) 1719 struct mmc_ios *ios)
1739{ 1720{
1740 struct mmc_host *mmc = host->mmc; 1721 struct sdhci_host *host = mmc_priv(mmc);
1741 u16 ctrl; 1722 u16 ctrl;
1742 int ret; 1723 int ret;
1743 1724
@@ -1825,17 +1806,6 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host,
1825 } 1806 }
1826} 1807}
1827 1808
1828static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc,
1829 struct mmc_ios *ios)
1830{
1831 struct sdhci_host *host = mmc_priv(mmc);
1832
1833 if (host->version < SDHCI_SPEC_300)
1834 return 0;
1835
1836 return sdhci_do_start_signal_voltage_switch(host, ios);
1837}
1838
1839static int sdhci_card_busy(struct mmc_host *mmc) 1809static int sdhci_card_busy(struct mmc_host *mmc)
1840{ 1810{
1841 struct sdhci_host *host = mmc_priv(mmc); 1811 struct sdhci_host *host = mmc_priv(mmc);
@@ -2126,7 +2096,7 @@ static void sdhci_card_event(struct mmc_host *mmc)
2126 if (host->ops->card_event) 2096 if (host->ops->card_event)
2127 host->ops->card_event(host); 2097 host->ops->card_event(host);
2128 2098
2129 present = sdhci_do_get_cd(host); 2099 present = sdhci_get_cd(host->mmc);
2130 2100
2131 spin_lock_irqsave(&host->lock, flags); 2101 spin_lock_irqsave(&host->lock, flags);
2132 2102
@@ -2697,7 +2667,7 @@ int sdhci_resume_host(struct sdhci_host *host)
2697 sdhci_init(host, 0); 2667 sdhci_init(host, 0);
2698 host->pwr = 0; 2668 host->pwr = 0;
2699 host->clock = 0; 2669 host->clock = 0;
2700 sdhci_do_set_ios(host, &host->mmc->ios); 2670 sdhci_set_ios(host->mmc, &host->mmc->ios);
2701 } else { 2671 } else {
2702 sdhci_init(host, (host->mmc->pm_flags & MMC_PM_KEEP_POWER)); 2672 sdhci_init(host, (host->mmc->pm_flags & MMC_PM_KEEP_POWER));
2703 mmiowb(); 2673 mmiowb();
@@ -2759,8 +2729,8 @@ int sdhci_runtime_resume_host(struct sdhci_host *host)
2759 /* Force clock and power re-program */ 2729 /* Force clock and power re-program */
2760 host->pwr = 0; 2730 host->pwr = 0;
2761 host->clock = 0; 2731 host->clock = 0;
2762 sdhci_do_start_signal_voltage_switch(host, &host->mmc->ios); 2732 sdhci_start_signal_voltage_switch(host->mmc, &host->mmc->ios);
2763 sdhci_do_set_ios(host, &host->mmc->ios); 2733 sdhci_set_ios(host->mmc, &host->mmc->ios);
2764 2734
2765 if ((host_flags & SDHCI_PV_ENABLED) && 2735 if ((host_flags & SDHCI_PV_ENABLED) &&
2766 !(host->quirks2 & SDHCI_QUIRK2_PRESET_VALUE_BROKEN)) { 2736 !(host->quirks2 & SDHCI_QUIRK2_PRESET_VALUE_BROKEN)) {