BackMerge v4.19-rc5 into drm-next

Sean Paul requested an -rc5 backmerge from some sun4i fixes.

Signed-off-by: Dave Airlie <airlied@redhat.com>

5 files changed, 15 insertions, 12 deletions

diff --git a/drivers/misc/hmc6352.c b/drivers/misc/hmc6352.c
index eeb7eef62174..38f90e179927 100644
--- a/drivers/misc/hmc6352.c
+++ b/drivers/misc/hmc6352.c
@@ -27,6 +27,7 @@
 #include <linux/err.h>
 #include <linux/delay.h>
 #include <linux/sysfs.h>
+#include <linux/nospec.h>
 
 static DEFINE_MUTEX(compass_mutex);
 
@@ -50,6 +51,7 @@ static int compass_store(struct device *dev, const char *buf, size_t count,
                 return ret;
         if (val >= strlen(map))
                 return -EINVAL;
+        val = array_index_nospec(val, strlen(map));
         mutex_lock(&compass_mutex);
         ret = compass_command(c, map[val]);
         mutex_unlock(&compass_mutex);
diff --git a/drivers/misc/ibmvmc.c b/drivers/misc/ibmvmc.c
index 8f82bb9d11e2..b8aaa684c397 100644
--- a/drivers/misc/ibmvmc.c
+++ b/drivers/misc/ibmvmc.c
@@ -2131,7 +2131,7 @@ static int ibmvmc_init_crq_queue(struct crq_server_adapter *adapter)
         retrc = plpar_hcall_norets(H_REG_CRQ,
                                    vdev->unit_address,
                                    queue->msg_token, PAGE_SIZE);
-        retrc = rc;
+        rc = retrc;
 
         if (rc == H_RESOURCE)
                 rc = ibmvmc_reset_crq_queue(adapter);
diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c
index 7bba62a72921..fc3872fe7b25 100644
--- a/drivers/misc/mei/bus.c
+++ b/drivers/misc/mei/bus.c
@@ -521,17 +521,15 @@ int mei_cldev_enable(struct mei_cl_device *cldev)
 
         cl = cldev->cl;
 
+        mutex_lock(&bus->device_lock);
         if (cl->state == MEI_FILE_UNINITIALIZED) {
-                mutex_lock(&bus->device_lock);
                 ret = mei_cl_link(cl);
-                mutex_unlock(&bus->device_lock);
                 if (ret)
-                        return ret;
+                        goto out;
                 /* update pointers */
                 cl->cldev = cldev;
         }
 
-        mutex_lock(&bus->device_lock);
         if (mei_cl_is_connected(cl)) {
                 ret = 0;
                 goto out;
@@ -616,9 +614,8 @@ int mei_cldev_disable(struct mei_cl_device *cldev)
         if (err < 0)
                 dev_err(bus->dev, "Could not disconnect from the ME client\n");
 
-out:
         mei_cl_bus_module_put(cldev);
-
+out:
         /* Flush queues and remove any pending read */
         mei_cl_flush_queues(cl, NULL);
         mei_cl_unlink(cl);
@@ -876,12 +873,13 @@ static void mei_cl_bus_dev_release(struct device *dev)
 
         mei_me_cl_put(cldev->me_cl);
         mei_dev_bus_put(cldev->bus);
+        mei_cl_unlink(cldev->cl);
         kfree(cldev->cl);
         kfree(cldev);
 }
 
 static const struct device_type mei_cl_device_type = {
-        .release        = mei_cl_bus_dev_release,
+        .release = mei_cl_bus_dev_release,
 };
 
 /**
diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
index 4ab6251d418e..ebdcf0b450e2 100644
--- a/drivers/misc/mei/client.c
+++ b/drivers/misc/mei/client.c
@@ -1767,7 +1767,7 @@ out:
                 }
         }
 
-        rets = buf->size;
+        rets = len;
 err:
         cl_dbg(dev, cl, "rpm: autosuspend\n");
         pm_runtime_mark_last_busy(dev->dev);
diff --git a/drivers/misc/mei/hbm.c b/drivers/misc/mei/hbm.c
index 09e233d4c0de..e56f3e72d57a 100644
--- a/drivers/misc/mei/hbm.c
+++ b/drivers/misc/mei/hbm.c
@@ -1161,15 +1161,18 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr)
 
                 props_res = (struct hbm_props_response *)mei_msg;
 
-                if (props_res->status) {
+                if (props_res->status == MEI_HBMS_CLIENT_NOT_FOUND) {
+                        dev_dbg(dev->dev, "hbm: properties response: %d CLIENT_NOT_FOUND\n",
+                                props_res->me_addr);
+                } else if (props_res->status) {
                         dev_err(dev->dev, "hbm: properties response: wrong status = %d %s\n",
                                 props_res->status,
                                 mei_hbm_status_str(props_res->status));
                         return -EPROTO;
+                } else {
+                        mei_hbm_me_cl_add(dev, props_res);
                 }
 
-                mei_hbm_me_cl_add(dev, props_res);
-
                 /* request property for the next client */
                 if (mei_hbm_prop_req(dev, props_res->me_addr + 1))
                         return -EIO;