aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/misc/mei/interrupt.c
diff options
context:
space:
mode:
authorTomas Winkler <tomas.winkler@intel.com>2012-12-25 12:06:00 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-07 13:31:28 -0500
commit15d4acc57f23b6e02e587b773458a7c0e23e501d (patch)
treedf97d1e6c202ffce113adba34cb504e446e95b15 /drivers/misc/mei/interrupt.c
parent438763f37eb9664b6372bdfee990f8c33acdc63c (diff)
mei: use unified format for printing mei message header
Introduce MEI_HDR_FMT and MEI_HDR_PRM macros. Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/mei/interrupt.c')
-rw-r--r--drivers/misc/mei/interrupt.c14
1 files changed, 6 insertions, 8 deletions
diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c
index b72fa8196ddb..fe93d1c9c242 100644
--- a/drivers/misc/mei/interrupt.c
+++ b/drivers/misc/mei/interrupt.c
@@ -150,8 +150,8 @@ quit:
150 dev_dbg(&dev->pdev->dev, "message read\n"); 150 dev_dbg(&dev->pdev->dev, "message read\n");
151 if (!buffer) { 151 if (!buffer) {
152 mei_read_slots(dev, dev->rd_msg_buf, mei_hdr->length); 152 mei_read_slots(dev, dev->rd_msg_buf, mei_hdr->length);
153 dev_dbg(&dev->pdev->dev, "discarding message, header =%08x.\n", 153 dev_dbg(&dev->pdev->dev, "discarding message " MEI_HDR_FMT "\n",
154 *(u32 *) dev->rd_msg_buf); 154 MEI_HDR_PRM(mei_hdr));
155 } 155 }
156 156
157 return 0; 157 return 0;
@@ -742,8 +742,7 @@ static int mei_irq_thread_write_complete(struct mei_device *dev, s32 *slots,
742 742
743 dev_dbg(&dev->pdev->dev, "buf: size = %d idx = %lu\n", 743 dev_dbg(&dev->pdev->dev, "buf: size = %d idx = %lu\n",
744 cb->request_buffer.size, cb->buf_idx); 744 cb->request_buffer.size, cb->buf_idx);
745 dev_dbg(&dev->pdev->dev, "msg: len = %d complete = %d\n", 745 dev_dbg(&dev->pdev->dev, MEI_HDR_FMT, MEI_HDR_PRM(mei_hdr));
746 mei_hdr->length, mei_hdr->msg_complete);
747 746
748 *slots -= msg_slots; 747 *slots -= msg_slots;
749 if (mei_write_message(dev, mei_hdr, 748 if (mei_write_message(dev, mei_hdr,
@@ -790,7 +789,7 @@ static int mei_irq_thread_read_handler(struct mei_cl_cb *cmpl_list,
790 dev_dbg(&dev->pdev->dev, "slots =%08x.\n", *slots); 789 dev_dbg(&dev->pdev->dev, "slots =%08x.\n", *slots);
791 } 790 }
792 mei_hdr = (struct mei_msg_hdr *) &dev->rd_msg_hdr; 791 mei_hdr = (struct mei_msg_hdr *) &dev->rd_msg_hdr;
793 dev_dbg(&dev->pdev->dev, "mei_hdr->length =%d\n", mei_hdr->length); 792 dev_dbg(&dev->pdev->dev, MEI_HDR_FMT, MEI_HDR_PRM(mei_hdr));
794 793
795 if (mei_hdr->reserved || !dev->rd_msg_hdr) { 794 if (mei_hdr->reserved || !dev->rd_msg_hdr) {
796 dev_dbg(&dev->pdev->dev, "corrupted message header.\n"); 795 dev_dbg(&dev->pdev->dev, "corrupted message header.\n");
@@ -835,13 +834,12 @@ static int mei_irq_thread_read_handler(struct mei_cl_cb *cmpl_list,
835 (MEI_FILE_CONNECTED == dev->iamthif_cl.state) && 834 (MEI_FILE_CONNECTED == dev->iamthif_cl.state) &&
836 (dev->iamthif_state == MEI_IAMTHIF_READING)) { 835 (dev->iamthif_state == MEI_IAMTHIF_READING)) {
837 dev_dbg(&dev->pdev->dev, "call mei_irq_thread_read_iamthif_message.\n"); 836 dev_dbg(&dev->pdev->dev, "call mei_irq_thread_read_iamthif_message.\n");
838 dev_dbg(&dev->pdev->dev, "mei_hdr->length =%d\n", 837
839 mei_hdr->length); 838 dev_dbg(&dev->pdev->dev, MEI_HDR_FMT, MEI_HDR_PRM(mei_hdr));
840 839
841 ret = mei_amthif_irq_read_message(cmpl_list, dev, mei_hdr); 840 ret = mei_amthif_irq_read_message(cmpl_list, dev, mei_hdr);
842 if (ret) 841 if (ret)
843 goto end; 842 goto end;
844
845 } else { 843 } else {
846 dev_dbg(&dev->pdev->dev, "call mei_irq_thread_read_client_message.\n"); 844 dev_dbg(&dev->pdev->dev, "call mei_irq_thread_read_client_message.\n");
847 ret = mei_irq_thread_read_client_message(cmpl_list, 845 ret = mei_irq_thread_read_client_message(cmpl_list,