aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/misc/mei/init.c
diff options
context:
space:
mode:
authorTomas Winkler <tomas.winkler@intel.com>2012-12-25 12:05:59 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-07 13:31:27 -0500
commit438763f37eb9664b6372bdfee990f8c33acdc63c (patch)
tree71f2feab0d7b91cfd28c538c2943a8d8fe000c96 /drivers/misc/mei/init.c
parentd1c3ed669a2d452cacfb48c2d171a1f364dae2ed (diff)
mei: drop redundant length parameter from mei_write_message function
The length is already part of the message header and it is validated before the function call Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/mei/init.c')
-rw-r--r--drivers/misc/mei/init.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/misc/mei/init.c b/drivers/misc/mei/init.c
index a54cd5567ca2..c0c0b3e22579 100644
--- a/drivers/misc/mei/init.c
+++ b/drivers/misc/mei/init.c
@@ -345,7 +345,7 @@ void mei_host_start_message(struct mei_device *dev)
345 start_req->host_version.minor_version = HBM_MINOR_VERSION; 345 start_req->host_version.minor_version = HBM_MINOR_VERSION;
346 346
347 dev->recvd_msg = false; 347 dev->recvd_msg = false;
348 if (mei_write_message(dev, mei_hdr, (unsigned char *)start_req, len)) { 348 if (mei_write_message(dev, mei_hdr, (unsigned char *)start_req)) {
349 dev_dbg(&dev->pdev->dev, "write send version message to FW fail.\n"); 349 dev_dbg(&dev->pdev->dev, "write send version message to FW fail.\n");
350 dev->dev_state = MEI_DEV_RESETING; 350 dev->dev_state = MEI_DEV_RESETING;
351 mei_reset(dev, 1); 351 mei_reset(dev, 1);
@@ -374,7 +374,7 @@ void mei_host_enum_clients_message(struct mei_device *dev)
374 memset(enum_req, 0, sizeof(struct hbm_host_enum_request)); 374 memset(enum_req, 0, sizeof(struct hbm_host_enum_request));
375 enum_req->hbm_cmd = HOST_ENUM_REQ_CMD; 375 enum_req->hbm_cmd = HOST_ENUM_REQ_CMD;
376 376
377 if (mei_write_message(dev, mei_hdr, (unsigned char *)enum_req, len)) { 377 if (mei_write_message(dev, mei_hdr, (unsigned char *)enum_req)) {
378 dev->dev_state = MEI_DEV_RESETING; 378 dev->dev_state = MEI_DEV_RESETING;
379 dev_dbg(&dev->pdev->dev, "write send enumeration request message to FW fail.\n"); 379 dev_dbg(&dev->pdev->dev, "write send enumeration request message to FW fail.\n");
380 mei_reset(dev, 1); 380 mei_reset(dev, 1);
@@ -492,8 +492,7 @@ int mei_host_client_enumerate(struct mei_device *dev)
492 prop_req->hbm_cmd = HOST_CLIENT_PROPERTIES_REQ_CMD; 492 prop_req->hbm_cmd = HOST_CLIENT_PROPERTIES_REQ_CMD;
493 prop_req->address = next_client_index; 493 prop_req->address = next_client_index;
494 494
495 if (mei_write_message(dev, mei_hdr, (unsigned char *) prop_req, 495 if (mei_write_message(dev, mei_hdr, (unsigned char *) prop_req)) {
496 mei_hdr->length)) {
497 dev->dev_state = MEI_DEV_RESETING; 496 dev->dev_state = MEI_DEV_RESETING;
498 dev_err(&dev->pdev->dev, "Properties request command failed\n"); 497 dev_err(&dev->pdev->dev, "Properties request command failed\n");
499 mei_reset(dev, 1); 498 mei_reset(dev, 1);