aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/misc/ibmasm/event.c
diff options
context:
space:
mode:
authorAnton Vasilyev <vasilyev@ispras.ru>2017-08-01 09:25:59 -0400
committerJiri Kosina <jkosina@suse.cz>2017-10-12 09:37:19 -0400
commitf403f85f5334fb169d5c00deac106f140b62d3c9 (patch)
tree15600778f839c182c1dfd8bd4fa37f7cf0ff2d5b /drivers/misc/ibmasm/event.c
parentdf47b246ed176b504b1d50ad63aa5a3bf7551f82 (diff)
misc: ibmasm: Return error on error path
If ibmasm_event_buffer_init() or ibmasm_heartbeat_init() fails, then ibmasm_init_one() release all resources and return 0 on error path. The patch adds corresponding error for fails. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/misc/ibmasm/event.c')
-rw-r--r--drivers/misc/ibmasm/event.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/ibmasm/event.c b/drivers/misc/ibmasm/event.c
index 8e540f4e9d52..7e33025b4854 100644
--- a/drivers/misc/ibmasm/event.c
+++ b/drivers/misc/ibmasm/event.c
@@ -155,7 +155,7 @@ int ibmasm_event_buffer_init(struct service_processor *sp)
155 155
156 buffer = kmalloc(sizeof(struct event_buffer), GFP_KERNEL); 156 buffer = kmalloc(sizeof(struct event_buffer), GFP_KERNEL);
157 if (!buffer) 157 if (!buffer)
158 return 1; 158 return -ENOMEM;
159 159
160 buffer->next_index = 0; 160 buffer->next_index = 0;
161 buffer->next_serial_number = 1; 161 buffer->next_serial_number = 1;