aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/misc/cxl/debugfs.c
diff options
context:
space:
mode:
authorAndrew Donnellan <andrew.donnellan@au1.ibm.com>2016-11-22 05:13:27 -0500
committerMichael Ellerman <mpe@ellerman.id.au>2016-11-23 06:57:49 -0500
commit3382a6220ff3bac886d9d90766f3fe18cf25b468 (patch)
tree44b0b45a39044ccb53c45e8d2152bd2b437fd426 /drivers/misc/cxl/debugfs.c
parent902e06eb86cd62753974c249bd1dedae2825b430 (diff)
cxl: Fix coccinelle warnings
Fix the following coccinelle warnings: drivers/misc/cxl/debugfs.c:46:0-23: WARNING: fops_io_x64 should be defined with DEFINE_DEBUGFS_ATTRIBUTE drivers/misc/cxl/guest.c:890:5-26: WARNING: Comparison to bool drivers/misc/cxl/irq.c:107:3-23: WARNING: Assignment of bool to 0/1 drivers/misc/cxl/native.c:57:2-3: Unneeded semicolon drivers/misc/cxl/native.c:170:2-3: Unneeded semicolon Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com> Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com> Acked-by: Ian Munsie <imunsie@au1.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Diffstat (limited to 'drivers/misc/cxl/debugfs.c')
-rw-r--r--drivers/misc/cxl/debugfs.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/misc/cxl/debugfs.c b/drivers/misc/cxl/debugfs.c
index ec7b8a017439..9c06ac8fa5ac 100644
--- a/drivers/misc/cxl/debugfs.c
+++ b/drivers/misc/cxl/debugfs.c
@@ -43,12 +43,14 @@ static int debugfs_io_u64_set(void *data, u64 val)
43 out_be64((u64 __iomem *)data, val); 43 out_be64((u64 __iomem *)data, val);
44 return 0; 44 return 0;
45} 45}
46DEFINE_SIMPLE_ATTRIBUTE(fops_io_x64, debugfs_io_u64_get, debugfs_io_u64_set, "0x%016llx\n"); 46DEFINE_DEBUGFS_ATTRIBUTE(fops_io_x64, debugfs_io_u64_get, debugfs_io_u64_set,
47 "0x%016llx\n");
47 48
48static struct dentry *debugfs_create_io_x64(const char *name, umode_t mode, 49static struct dentry *debugfs_create_io_x64(const char *name, umode_t mode,
49 struct dentry *parent, u64 __iomem *value) 50 struct dentry *parent, u64 __iomem *value)
50{ 51{
51 return debugfs_create_file(name, mode, parent, (void __force *)value, &fops_io_x64); 52 return debugfs_create_file_unsafe(name, mode, parent,
53 (void __force *)value, &fops_io_x64);
52} 54}
53 55
54void cxl_debugfs_add_adapter_psl_regs(struct cxl *adapter, struct dentry *dir) 56void cxl_debugfs_add_adapter_psl_regs(struct cxl *adapter, struct dentry *dir)