aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mfd
diff options
context:
space:
mode:
authorAndrew F. Davis <afd@ti.com>2016-06-08 11:54:34 -0400
committerLee Jones <lee.jones@linaro.org>2016-06-29 05:14:38 -0400
commita318b7d0fa9c28df057747d584caaac52115f026 (patch)
tree2224e05220e95231e321178209bcd729de719293 /drivers/mfd
parent3df140d11c6dbf319f4e1bc034e202546fc5ec5c (diff)
mfd: ti_am335x_tscadc: Unify variable naming when referencing ti_tscadc_dev
All functions in this driver reference the same ti_tscadc_dev per device but use several different names for this structure pointer, this can be confusing when following the code. Use the name 'tscadc' everywhere. Signed-off-by: Andrew F. Davis <afd@ti.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
-rw-r--r--drivers/mfd/ti_am335x_tscadc.c88
1 files changed, 44 insertions, 44 deletions
diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
index f147fe780a0f..e71f6092be61 100644
--- a/drivers/mfd/ti_am335x_tscadc.c
+++ b/drivers/mfd/ti_am335x_tscadc.c
@@ -34,89 +34,89 @@ static const struct regmap_config tscadc_regmap_config = {
34 .val_bits = 32, 34 .val_bits = 32,
35}; 35};
36 36
37void am335x_tsc_se_set_cache(struct ti_tscadc_dev *tsadc, u32 val) 37void am335x_tsc_se_set_cache(struct ti_tscadc_dev *tscadc, u32 val)
38{ 38{
39 unsigned long flags; 39 unsigned long flags;
40 40
41 spin_lock_irqsave(&tsadc->reg_lock, flags); 41 spin_lock_irqsave(&tscadc->reg_lock, flags);
42 tsadc->reg_se_cache |= val; 42 tscadc->reg_se_cache |= val;
43 if (tsadc->adc_waiting) 43 if (tscadc->adc_waiting)
44 wake_up(&tsadc->reg_se_wait); 44 wake_up(&tscadc->reg_se_wait);
45 else if (!tsadc->adc_in_use) 45 else if (!tscadc->adc_in_use)
46 regmap_write(tsadc->regmap_tscadc, REG_SE, tsadc->reg_se_cache); 46 regmap_write(tscadc->regmap_tscadc, REG_SE, tscadc->reg_se_cache);
47 47
48 spin_unlock_irqrestore(&tsadc->reg_lock, flags); 48 spin_unlock_irqrestore(&tscadc->reg_lock, flags);
49} 49}
50EXPORT_SYMBOL_GPL(am335x_tsc_se_set_cache); 50EXPORT_SYMBOL_GPL(am335x_tsc_se_set_cache);
51 51
52static void am335x_tscadc_need_adc(struct ti_tscadc_dev *tsadc) 52static void am335x_tscadc_need_adc(struct ti_tscadc_dev *tscadc)
53{ 53{
54 DEFINE_WAIT(wait); 54 DEFINE_WAIT(wait);
55 u32 reg; 55 u32 reg;
56 56
57 regmap_read(tsadc->regmap_tscadc, REG_ADCFSM, &reg); 57 regmap_read(tscadc->regmap_tscadc, REG_ADCFSM, &reg);
58 if (reg & SEQ_STATUS) { 58 if (reg & SEQ_STATUS) {
59 tsadc->adc_waiting = true; 59 tscadc->adc_waiting = true;
60 prepare_to_wait(&tsadc->reg_se_wait, &wait, 60 prepare_to_wait(&tscadc->reg_se_wait, &wait,
61 TASK_UNINTERRUPTIBLE); 61 TASK_UNINTERRUPTIBLE);
62 spin_unlock_irq(&tsadc->reg_lock); 62 spin_unlock_irq(&tscadc->reg_lock);
63 63
64 schedule(); 64 schedule();
65 65
66 spin_lock_irq(&tsadc->reg_lock); 66 spin_lock_irq(&tscadc->reg_lock);
67 finish_wait(&tsadc->reg_se_wait, &wait); 67 finish_wait(&tscadc->reg_se_wait, &wait);
68 68
69 /* 69 /*
70 * Sequencer should either be idle or 70 * Sequencer should either be idle or
71 * busy applying the charge step. 71 * busy applying the charge step.
72 */ 72 */
73 regmap_read(tsadc->regmap_tscadc, REG_ADCFSM, &reg); 73 regmap_read(tscadc->regmap_tscadc, REG_ADCFSM, &reg);
74 WARN_ON((reg & SEQ_STATUS) && !(reg & CHARGE_STEP)); 74 WARN_ON((reg & SEQ_STATUS) && !(reg & CHARGE_STEP));
75 tsadc->adc_waiting = false; 75 tscadc->adc_waiting = false;
76 } 76 }
77 tsadc->adc_in_use = true; 77 tscadc->adc_in_use = true;
78} 78}
79 79
80void am335x_tsc_se_set_once(struct ti_tscadc_dev *tsadc, u32 val) 80void am335x_tsc_se_set_once(struct ti_tscadc_dev *tscadc, u32 val)
81{ 81{
82 spin_lock_irq(&tsadc->reg_lock); 82 spin_lock_irq(&tscadc->reg_lock);
83 am335x_tscadc_need_adc(tsadc); 83 am335x_tscadc_need_adc(tscadc);
84 84
85 regmap_write(tsadc->regmap_tscadc, REG_SE, val); 85 regmap_write(tscadc->regmap_tscadc, REG_SE, val);
86 spin_unlock_irq(&tsadc->reg_lock); 86 spin_unlock_irq(&tscadc->reg_lock);
87} 87}
88EXPORT_SYMBOL_GPL(am335x_tsc_se_set_once); 88EXPORT_SYMBOL_GPL(am335x_tsc_se_set_once);
89 89
90void am335x_tsc_se_adc_done(struct ti_tscadc_dev *tsadc) 90void am335x_tsc_se_adc_done(struct ti_tscadc_dev *tscadc)
91{ 91{
92 unsigned long flags; 92 unsigned long flags;
93 93
94 spin_lock_irqsave(&tsadc->reg_lock, flags); 94 spin_lock_irqsave(&tscadc->reg_lock, flags);
95 tsadc->adc_in_use = false; 95 tscadc->adc_in_use = false;
96 regmap_write(tsadc->regmap_tscadc, REG_SE, tsadc->reg_se_cache); 96 regmap_write(tscadc->regmap_tscadc, REG_SE, tscadc->reg_se_cache);
97 spin_unlock_irqrestore(&tsadc->reg_lock, flags); 97 spin_unlock_irqrestore(&tscadc->reg_lock, flags);
98} 98}
99EXPORT_SYMBOL_GPL(am335x_tsc_se_adc_done); 99EXPORT_SYMBOL_GPL(am335x_tsc_se_adc_done);
100 100
101void am335x_tsc_se_clr(struct ti_tscadc_dev *tsadc, u32 val) 101void am335x_tsc_se_clr(struct ti_tscadc_dev *tscadc, u32 val)
102{ 102{
103 unsigned long flags; 103 unsigned long flags;
104 104
105 spin_lock_irqsave(&tsadc->reg_lock, flags); 105 spin_lock_irqsave(&tscadc->reg_lock, flags);
106 tsadc->reg_se_cache &= ~val; 106 tscadc->reg_se_cache &= ~val;
107 regmap_write(tsadc->regmap_tscadc, REG_SE, tsadc->reg_se_cache); 107 regmap_write(tscadc->regmap_tscadc, REG_SE, tscadc->reg_se_cache);
108 spin_unlock_irqrestore(&tsadc->reg_lock, flags); 108 spin_unlock_irqrestore(&tscadc->reg_lock, flags);
109} 109}
110EXPORT_SYMBOL_GPL(am335x_tsc_se_clr); 110EXPORT_SYMBOL_GPL(am335x_tsc_se_clr);
111 111
112static void tscadc_idle_config(struct ti_tscadc_dev *config) 112static void tscadc_idle_config(struct ti_tscadc_dev *tscadc)
113{ 113{
114 unsigned int idleconfig; 114 unsigned int idleconfig;
115 115
116 idleconfig = STEPCONFIG_YNN | STEPCONFIG_INM_ADCREFM | 116 idleconfig = STEPCONFIG_YNN | STEPCONFIG_INM_ADCREFM |
117 STEPCONFIG_INP_ADCREFM | STEPCONFIG_YPN; 117 STEPCONFIG_INP_ADCREFM | STEPCONFIG_YPN;
118 118
119 regmap_write(config->regmap_tscadc, REG_IDLECONFIG, idleconfig); 119 regmap_write(tscadc->regmap_tscadc, REG_IDLECONFIG, idleconfig);
120} 120}
121 121
122static int ti_tscadc_probe(struct platform_device *pdev) 122static int ti_tscadc_probe(struct platform_device *pdev)
@@ -297,9 +297,9 @@ static int ti_tscadc_remove(struct platform_device *pdev)
297 297
298static int __maybe_unused tscadc_suspend(struct device *dev) 298static int __maybe_unused tscadc_suspend(struct device *dev)
299{ 299{
300 struct ti_tscadc_dev *tscadc_dev = dev_get_drvdata(dev); 300 struct ti_tscadc_dev *tscadc = dev_get_drvdata(dev);
301 301
302 regmap_write(tscadc_dev->regmap_tscadc, REG_SE, 0x00); 302 regmap_write(tscadc->regmap_tscadc, REG_SE, 0x00);
303 pm_runtime_put_sync(dev); 303 pm_runtime_put_sync(dev);
304 304
305 return 0; 305 return 0;
@@ -307,26 +307,26 @@ static int __maybe_unused tscadc_suspend(struct device *dev)
307 307
308static int __maybe_unused tscadc_resume(struct device *dev) 308static int __maybe_unused tscadc_resume(struct device *dev)
309{ 309{
310 struct ti_tscadc_dev *tscadc_dev = dev_get_drvdata(dev); 310 struct ti_tscadc_dev *tscadc = dev_get_drvdata(dev);
311 u32 ctrl; 311 u32 ctrl;
312 312
313 pm_runtime_get_sync(dev); 313 pm_runtime_get_sync(dev);
314 314
315 /* context restore */ 315 /* context restore */
316 ctrl = CNTRLREG_STEPCONFIGWRT | CNTRLREG_STEPID; 316 ctrl = CNTRLREG_STEPCONFIGWRT | CNTRLREG_STEPID;
317 regmap_write(tscadc_dev->regmap_tscadc, REG_CTRL, ctrl); 317 regmap_write(tscadc->regmap_tscadc, REG_CTRL, ctrl);
318 318
319 if (tscadc_dev->tsc_cell != -1) { 319 if (tscadc->tsc_cell != -1) {
320 if (tscadc_dev->tsc_wires == 5) 320 if (tscadc->tsc_wires == 5)
321 ctrl |= CNTRLREG_5WIRE | CNTRLREG_TSCENB; 321 ctrl |= CNTRLREG_5WIRE | CNTRLREG_TSCENB;
322 else 322 else
323 ctrl |= CNTRLREG_4WIRE | CNTRLREG_TSCENB; 323 ctrl |= CNTRLREG_4WIRE | CNTRLREG_TSCENB;
324 tscadc_idle_config(tscadc_dev); 324 tscadc_idle_config(tscadc);
325 } 325 }
326 ctrl |= CNTRLREG_TSCSSENB; 326 ctrl |= CNTRLREG_TSCSSENB;
327 regmap_write(tscadc_dev->regmap_tscadc, REG_CTRL, ctrl); 327 regmap_write(tscadc->regmap_tscadc, REG_CTRL, ctrl);
328 328
329 regmap_write(tscadc_dev->regmap_tscadc, REG_CLKDIV, tscadc_dev->clk_div); 329 regmap_write(tscadc->regmap_tscadc, REG_CLKDIV, tscadc->clk_div);
330 330
331 return 0; 331 return 0;
332} 332}