diff options
author | Axel Lin <axel.lin@ingics.com> | 2014-08-16 09:23:40 -0400 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2014-09-26 03:15:54 -0400 |
commit | e9e9d3973594cadd9e892bc79f914f299bb61124 (patch) | |
tree | 30b3bb2865a5f4e267b7353efdd41c4888249872 /drivers/mfd/da9052-spi.c | |
parent | c38715fed8f51a8fba4a15f86732ad885f073d78 (diff) |
mfd: da9052: Avoid setting read_flag_mask for da9052-i2c driver
Current code init regmap with &da9052_regmap_config for both da9052-spi and
da9052-i2c drivers. da9052-spi sets the read_flag_mask.
The same setting may be applied for da9052-i2c if da9052-spi driver is loaded
first because they actually use the same regmap_config setting.
Fix this issue by using a local variable for regmap_config in da9052-spi driver,
so the settings in spi driver won't impact the settings in i2c driver.
Also makes da9052_regmap_config const to avoid similar issue.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/da9052-spi.c')
-rw-r--r-- | drivers/mfd/da9052-spi.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c index 17666b40b70c..45ae0b7d13ef 100644 --- a/drivers/mfd/da9052-spi.c +++ b/drivers/mfd/da9052-spi.c | |||
@@ -23,6 +23,7 @@ | |||
23 | 23 | ||
24 | static int da9052_spi_probe(struct spi_device *spi) | 24 | static int da9052_spi_probe(struct spi_device *spi) |
25 | { | 25 | { |
26 | struct regmap_config config; | ||
26 | int ret; | 27 | int ret; |
27 | const struct spi_device_id *id = spi_get_device_id(spi); | 28 | const struct spi_device_id *id = spi_get_device_id(spi); |
28 | struct da9052 *da9052; | 29 | struct da9052 *da9052; |
@@ -40,10 +41,10 @@ static int da9052_spi_probe(struct spi_device *spi) | |||
40 | 41 | ||
41 | spi_set_drvdata(spi, da9052); | 42 | spi_set_drvdata(spi, da9052); |
42 | 43 | ||
43 | da9052_regmap_config.read_flag_mask = 1; | 44 | config = da9052_regmap_config; |
44 | da9052_regmap_config.write_flag_mask = 0; | 45 | config.read_flag_mask = 1; |
45 | 46 | ||
46 | da9052->regmap = devm_regmap_init_spi(spi, &da9052_regmap_config); | 47 | da9052->regmap = devm_regmap_init_spi(spi, &config); |
47 | if (IS_ERR(da9052->regmap)) { | 48 | if (IS_ERR(da9052->regmap)) { |
48 | ret = PTR_ERR(da9052->regmap); | 49 | ret = PTR_ERR(da9052->regmap); |
49 | dev_err(&spi->dev, "Failed to allocate register map: %d\n", | 50 | dev_err(&spi->dev, "Failed to allocate register map: %d\n", |