diff options
| author | Olof Johansson <olof@lixom.net> | 2016-07-07 01:33:47 -0400 |
|---|---|---|
| committer | Olof Johansson <olof@lixom.net> | 2016-07-07 01:33:47 -0400 |
| commit | e1d1dfc2c2c25ce5ab2db3f3685c71532200fa01 (patch) | |
| tree | 3a643677d73471f396aa7da8ff6531f18e006eba /drivers/memory | |
| parent | 34df3b8bdc54709f78b0d72648fee6e53ffd8598 (diff) | |
| parent | 55bb1d8355ce91662dc8760f24f578db5a595819 (diff) | |
Merge tag 'tegra-for-4.8-memory' of git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux into next/drivers
memory: tegra: Changes for v4.8-rc1
Contains three reference count fixes from coccinelle.
* tag 'tegra-for-4.8-memory' of git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux:
memory: tegra: mc: Add missing of_node_put()
memory: tegra: Delete unneeded of_node_put()
memory: tegra: tegra124-emc: Add missing of_node_put()
Signed-off-by: Olof Johansson <olof@lixom.net>
Diffstat (limited to 'drivers/memory')
| -rw-r--r-- | drivers/memory/tegra/mc.c | 10 | ||||
| -rw-r--r-- | drivers/memory/tegra/tegra124-emc.c | 8 |
2 files changed, 9 insertions, 9 deletions
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c index a1ae0cc2b86d..a4803ac192bb 100644 --- a/drivers/memory/tegra/mc.c +++ b/drivers/memory/tegra/mc.c | |||
| @@ -186,8 +186,10 @@ static int load_timings(struct tegra_mc *mc, struct device_node *node) | |||
| 186 | timing = &mc->timings[i++]; | 186 | timing = &mc->timings[i++]; |
| 187 | 187 | ||
| 188 | err = load_one_timing(mc, timing, child); | 188 | err = load_one_timing(mc, timing, child); |
| 189 | if (err) | 189 | if (err) { |
| 190 | of_node_put(child); | ||
| 190 | return err; | 191 | return err; |
| 192 | } | ||
| 191 | } | 193 | } |
| 192 | 194 | ||
| 193 | return 0; | 195 | return 0; |
| @@ -206,15 +208,13 @@ static int tegra_mc_setup_timings(struct tegra_mc *mc) | |||
| 206 | for_each_child_of_node(mc->dev->of_node, node) { | 208 | for_each_child_of_node(mc->dev->of_node, node) { |
| 207 | err = of_property_read_u32(node, "nvidia,ram-code", | 209 | err = of_property_read_u32(node, "nvidia,ram-code", |
| 208 | &node_ram_code); | 210 | &node_ram_code); |
| 209 | if (err || (node_ram_code != ram_code)) { | 211 | if (err || (node_ram_code != ram_code)) |
| 210 | of_node_put(node); | ||
| 211 | continue; | 212 | continue; |
| 212 | } | ||
| 213 | 213 | ||
| 214 | err = load_timings(mc, node); | 214 | err = load_timings(mc, node); |
| 215 | of_node_put(node); | ||
| 215 | if (err) | 216 | if (err) |
| 216 | return err; | 217 | return err; |
| 217 | of_node_put(node); | ||
| 218 | break; | 218 | break; |
| 219 | } | 219 | } |
| 220 | 220 | ||
diff --git a/drivers/memory/tegra/tegra124-emc.c b/drivers/memory/tegra/tegra124-emc.c index 3dac7be39654..06cc781ebac1 100644 --- a/drivers/memory/tegra/tegra124-emc.c +++ b/drivers/memory/tegra/tegra124-emc.c | |||
| @@ -970,8 +970,10 @@ static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc, | |||
| 970 | timing = &emc->timings[i++]; | 970 | timing = &emc->timings[i++]; |
| 971 | 971 | ||
| 972 | err = load_one_timing_from_dt(emc, timing, child); | 972 | err = load_one_timing_from_dt(emc, timing, child); |
| 973 | if (err) | 973 | if (err) { |
| 974 | of_node_put(child); | ||
| 974 | return err; | 975 | return err; |
| 976 | } | ||
| 975 | } | 977 | } |
| 976 | 978 | ||
| 977 | sort(emc->timings, emc->num_timings, sizeof(*timing), cmp_timings, | 979 | sort(emc->timings, emc->num_timings, sizeof(*timing), cmp_timings, |
| @@ -995,10 +997,8 @@ tegra_emc_find_node_by_ram_code(struct device_node *node, u32 ram_code) | |||
| 995 | u32 value; | 997 | u32 value; |
| 996 | 998 | ||
| 997 | err = of_property_read_u32(np, "nvidia,ram-code", &value); | 999 | err = of_property_read_u32(np, "nvidia,ram-code", &value); |
| 998 | if (err || (value != ram_code)) { | 1000 | if (err || (value != ram_code)) |
| 999 | of_node_put(np); | ||
| 1000 | continue; | 1001 | continue; |
| 1001 | } | ||
| 1002 | 1002 | ||
| 1003 | return np; | 1003 | return np; |
| 1004 | } | 1004 | } |
