diff options
author | Philipp Zabel <philipp.zabel@gmail.com> | 2015-03-24 13:30:57 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2015-04-10 09:11:05 -0400 |
commit | 582d887211612c197fc8ea9435503f9b278ce76f (patch) | |
tree | d0052724c2ddb1707c521fb7afb17f3001535516 /drivers/media/platform/coda/coda-common.c | |
parent | 5c76c2c3e2783886975ff536c50d9c446e0ecb6e (diff) |
[media] coda: fix fill bitstream errors in nonstreaming case
When queueing a buffer into the bitstream fails, it has to be requeued
in the videobuf2 queue before streaming starts, but while streaming it
should be returned to userspace with an error.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/platform/coda/coda-common.c')
-rw-r--r-- | drivers/media/platform/coda/coda-common.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index c8811b7fa137..8e6fe0200117 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c | |||
@@ -1192,7 +1192,7 @@ static void coda_buf_queue(struct vb2_buffer *vb) | |||
1192 | mutex_lock(&ctx->bitstream_mutex); | 1192 | mutex_lock(&ctx->bitstream_mutex); |
1193 | v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vb); | 1193 | v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vb); |
1194 | if (vb2_is_streaming(vb->vb2_queue)) | 1194 | if (vb2_is_streaming(vb->vb2_queue)) |
1195 | coda_fill_bitstream(ctx); | 1195 | coda_fill_bitstream(ctx, true); |
1196 | mutex_unlock(&ctx->bitstream_mutex); | 1196 | mutex_unlock(&ctx->bitstream_mutex); |
1197 | } else { | 1197 | } else { |
1198 | v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vb); | 1198 | v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vb); |
@@ -1252,9 +1252,9 @@ static int coda_start_streaming(struct vb2_queue *q, unsigned int count) | |||
1252 | if (q_data_src->fourcc == V4L2_PIX_FMT_H264 || | 1252 | if (q_data_src->fourcc == V4L2_PIX_FMT_H264 || |
1253 | (q_data_src->fourcc == V4L2_PIX_FMT_JPEG && | 1253 | (q_data_src->fourcc == V4L2_PIX_FMT_JPEG && |
1254 | ctx->dev->devtype->product == CODA_7541)) { | 1254 | ctx->dev->devtype->product == CODA_7541)) { |
1255 | /* copy the buffers that where queued before streamon */ | 1255 | /* copy the buffers that were queued before streamon */ |
1256 | mutex_lock(&ctx->bitstream_mutex); | 1256 | mutex_lock(&ctx->bitstream_mutex); |
1257 | coda_fill_bitstream(ctx); | 1257 | coda_fill_bitstream(ctx, false); |
1258 | mutex_unlock(&ctx->bitstream_mutex); | 1258 | mutex_unlock(&ctx->bitstream_mutex); |
1259 | 1259 | ||
1260 | if (coda_get_bitstream_payload(ctx) < 512) { | 1260 | if (coda_get_bitstream_payload(ctx) < 512) { |