aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/pci/saa7134
diff options
context:
space:
mode:
authorHans Verkuil <hans.verkuil@cisco.com>2016-02-15 09:37:15 -0500
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2016-07-08 13:37:17 -0400
commit2bc46b3ad3c15165f91459b07ff8682478683194 (patch)
tree01a28e76142c4dde286157e7253fbd89dddc300b /drivers/media/pci/saa7134
parent0e2f511894ceca86d2cc006a363a1be0b17ca359 (diff)
[media] media/pci: convert drivers to use the new vb2_queue dev field
Stop using alloc_ctx and just fill in the device pointer. Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Cc: Federico Vaga <federico.vaga@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/media/pci/saa7134')
-rw-r--r--drivers/media/pci/saa7134/saa7134-core.c22
-rw-r--r--drivers/media/pci/saa7134/saa7134-ts.c1
-rw-r--r--drivers/media/pci/saa7134/saa7134-vbi.c1
-rw-r--r--drivers/media/pci/saa7134/saa7134-video.c3
-rw-r--r--drivers/media/pci/saa7134/saa7134.h1
5 files changed, 9 insertions, 19 deletions
diff --git a/drivers/media/pci/saa7134/saa7134-core.c b/drivers/media/pci/saa7134/saa7134-core.c
index c0e1780ec831..ffb66a9ae23e 100644
--- a/drivers/media/pci/saa7134/saa7134-core.c
+++ b/drivers/media/pci/saa7134/saa7134-core.c
@@ -1164,18 +1164,13 @@ static int saa7134_initdev(struct pci_dev *pci_dev,
1164 saa7134_board_init1(dev); 1164 saa7134_board_init1(dev);
1165 saa7134_hwinit1(dev); 1165 saa7134_hwinit1(dev);
1166 1166
1167 dev->alloc_ctx = vb2_dma_sg_init_ctx(&pci_dev->dev);
1168 if (IS_ERR(dev->alloc_ctx)) {
1169 err = PTR_ERR(dev->alloc_ctx);
1170 goto fail3;
1171 }
1172 /* get irq */ 1167 /* get irq */
1173 err = request_irq(pci_dev->irq, saa7134_irq, 1168 err = request_irq(pci_dev->irq, saa7134_irq,
1174 IRQF_SHARED, dev->name, dev); 1169 IRQF_SHARED, dev->name, dev);
1175 if (err < 0) { 1170 if (err < 0) {
1176 pr_err("%s: can't get IRQ %d\n", 1171 pr_err("%s: can't get IRQ %d\n",
1177 dev->name,pci_dev->irq); 1172 dev->name,pci_dev->irq);
1178 goto fail4; 1173 goto fail3;
1179 } 1174 }
1180 1175
1181 /* wait a bit, register i2c bus */ 1176 /* wait a bit, register i2c bus */
@@ -1233,7 +1228,7 @@ static int saa7134_initdev(struct pci_dev *pci_dev,
1233 if (err < 0) { 1228 if (err < 0) {
1234 pr_info("%s: can't register video device\n", 1229 pr_info("%s: can't register video device\n",
1235 dev->name); 1230 dev->name);
1236 goto fail5; 1231 goto fail4;
1237 } 1232 }
1238 pr_info("%s: registered device %s [v4l2]\n", 1233 pr_info("%s: registered device %s [v4l2]\n",
1239 dev->name, video_device_node_name(dev->video_dev)); 1234 dev->name, video_device_node_name(dev->video_dev));
@@ -1246,7 +1241,7 @@ static int saa7134_initdev(struct pci_dev *pci_dev,
1246 err = video_register_device(dev->vbi_dev,VFL_TYPE_VBI, 1241 err = video_register_device(dev->vbi_dev,VFL_TYPE_VBI,
1247 vbi_nr[dev->nr]); 1242 vbi_nr[dev->nr]);
1248 if (err < 0) 1243 if (err < 0)
1249 goto fail5; 1244 goto fail4;
1250 pr_info("%s: registered device %s\n", 1245 pr_info("%s: registered device %s\n",
1251 dev->name, video_device_node_name(dev->vbi_dev)); 1246 dev->name, video_device_node_name(dev->vbi_dev));
1252 1247
@@ -1257,7 +1252,7 @@ static int saa7134_initdev(struct pci_dev *pci_dev,
1257 err = video_register_device(dev->radio_dev,VFL_TYPE_RADIO, 1252 err = video_register_device(dev->radio_dev,VFL_TYPE_RADIO,
1258 radio_nr[dev->nr]); 1253 radio_nr[dev->nr]);
1259 if (err < 0) 1254 if (err < 0)
1260 goto fail5; 1255 goto fail4;
1261 pr_info("%s: registered device %s\n", 1256 pr_info("%s: registered device %s\n",
1262 dev->name, video_device_node_name(dev->radio_dev)); 1257 dev->name, video_device_node_name(dev->radio_dev));
1263 } 1258 }
@@ -1268,7 +1263,7 @@ static int saa7134_initdev(struct pci_dev *pci_dev,
1268 err = v4l2_mc_create_media_graph(dev->media_dev); 1263 err = v4l2_mc_create_media_graph(dev->media_dev);
1269 if (err) { 1264 if (err) {
1270 pr_err("failed to create media graph\n"); 1265 pr_err("failed to create media graph\n");
1271 goto fail5; 1266 goto fail4;
1272 } 1267 }
1273#endif 1268#endif
1274 /* everything worked */ 1269 /* everything worked */
@@ -1287,17 +1282,15 @@ static int saa7134_initdev(struct pci_dev *pci_dev,
1287#ifdef CONFIG_MEDIA_CONTROLLER 1282#ifdef CONFIG_MEDIA_CONTROLLER
1288 err = media_device_register(dev->media_dev); 1283 err = media_device_register(dev->media_dev);
1289 if (err) 1284 if (err)
1290 goto fail5; 1285 goto fail4;
1291#endif 1286#endif
1292 1287
1293 return 0; 1288 return 0;
1294 1289
1295 fail5: 1290 fail4:
1296 saa7134_unregister_video(dev); 1291 saa7134_unregister_video(dev);
1297 saa7134_i2c_unregister(dev); 1292 saa7134_i2c_unregister(dev);
1298 free_irq(pci_dev->irq, dev); 1293 free_irq(pci_dev->irq, dev);
1299 fail4:
1300 vb2_dma_sg_cleanup_ctx(dev->alloc_ctx);
1301 fail3: 1294 fail3:
1302 saa7134_hwfini(dev); 1295 saa7134_hwfini(dev);
1303 iounmap(dev->lmmio); 1296 iounmap(dev->lmmio);
@@ -1367,7 +1360,6 @@ static void saa7134_finidev(struct pci_dev *pci_dev)
1367 1360
1368 /* release resources */ 1361 /* release resources */
1369 free_irq(pci_dev->irq, dev); 1362 free_irq(pci_dev->irq, dev);
1370 vb2_dma_sg_cleanup_ctx(dev->alloc_ctx);
1371 iounmap(dev->lmmio); 1363 iounmap(dev->lmmio);
1372 release_mem_region(pci_resource_start(pci_dev,0), 1364 release_mem_region(pci_resource_start(pci_dev,0),
1373 pci_resource_len(pci_dev,0)); 1365 pci_resource_len(pci_dev,0));
diff --git a/drivers/media/pci/saa7134/saa7134-ts.c b/drivers/media/pci/saa7134/saa7134-ts.c
index 0584a2adbe99..8c68a934e22b 100644
--- a/drivers/media/pci/saa7134/saa7134-ts.c
+++ b/drivers/media/pci/saa7134/saa7134-ts.c
@@ -131,7 +131,6 @@ int saa7134_ts_queue_setup(struct vb2_queue *q,
131 *nbuffers = 3; 131 *nbuffers = 3;
132 *nplanes = 1; 132 *nplanes = 1;
133 sizes[0] = size; 133 sizes[0] = size;
134 alloc_ctxs[0] = dev->alloc_ctx;
135 return 0; 134 return 0;
136} 135}
137EXPORT_SYMBOL_GPL(saa7134_ts_queue_setup); 136EXPORT_SYMBOL_GPL(saa7134_ts_queue_setup);
diff --git a/drivers/media/pci/saa7134/saa7134-vbi.c b/drivers/media/pci/saa7134/saa7134-vbi.c
index e76da37c4a8a..e9bffb3569ba 100644
--- a/drivers/media/pci/saa7134/saa7134-vbi.c
+++ b/drivers/media/pci/saa7134/saa7134-vbi.c
@@ -155,7 +155,6 @@ static int queue_setup(struct vb2_queue *q,
155 *nbuffers = saa7134_buffer_count(size, *nbuffers); 155 *nbuffers = saa7134_buffer_count(size, *nbuffers);
156 *nplanes = 1; 156 *nplanes = 1;
157 sizes[0] = size; 157 sizes[0] = size;
158 alloc_ctxs[0] = dev->alloc_ctx;
159 return 0; 158 return 0;
160} 159}
161 160
diff --git a/drivers/media/pci/saa7134/saa7134-video.c b/drivers/media/pci/saa7134/saa7134-video.c
index ffa39543eb65..965ade72f5c5 100644
--- a/drivers/media/pci/saa7134/saa7134-video.c
+++ b/drivers/media/pci/saa7134/saa7134-video.c
@@ -980,7 +980,6 @@ static int queue_setup(struct vb2_queue *q,
980 *nbuffers = saa7134_buffer_count(size, *nbuffers); 980 *nbuffers = saa7134_buffer_count(size, *nbuffers);
981 *nplanes = 1; 981 *nplanes = 1;
982 sizes[0] = size; 982 sizes[0] = size;
983 alloc_ctxs[0] = dev->alloc_ctx;
984 983
985 saa7134_enable_analog_tuner(dev); 984 saa7134_enable_analog_tuner(dev);
986 985
@@ -2173,6 +2172,7 @@ int saa7134_video_init1(struct saa7134_dev *dev)
2173 q->buf_struct_size = sizeof(struct saa7134_buf); 2172 q->buf_struct_size = sizeof(struct saa7134_buf);
2174 q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; 2173 q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
2175 q->lock = &dev->lock; 2174 q->lock = &dev->lock;
2175 q->dev = &dev->pci->dev;
2176 ret = vb2_queue_init(q); 2176 ret = vb2_queue_init(q);
2177 if (ret) 2177 if (ret)
2178 return ret; 2178 return ret;
@@ -2191,6 +2191,7 @@ int saa7134_video_init1(struct saa7134_dev *dev)
2191 q->buf_struct_size = sizeof(struct saa7134_buf); 2191 q->buf_struct_size = sizeof(struct saa7134_buf);
2192 q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; 2192 q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
2193 q->lock = &dev->lock; 2193 q->lock = &dev->lock;
2194 q->dev = &dev->pci->dev;
2194 ret = vb2_queue_init(q); 2195 ret = vb2_queue_init(q);
2195 if (ret) 2196 if (ret)
2196 return ret; 2197 return ret;
diff --git a/drivers/media/pci/saa7134/saa7134.h b/drivers/media/pci/saa7134/saa7134.h
index 69a9bbf22d4d..41c01588af37 100644
--- a/drivers/media/pci/saa7134/saa7134.h
+++ b/drivers/media/pci/saa7134/saa7134.h
@@ -610,7 +610,6 @@ struct saa7134_dev {
610 610
611 611
612 /* video+ts+vbi capture */ 612 /* video+ts+vbi capture */
613 void *alloc_ctx;
614 struct saa7134_dmaqueue video_q; 613 struct saa7134_dmaqueue video_q;
615 struct vb2_queue video_vbq; 614 struct vb2_queue video_vbq;
616 struct saa7134_dmaqueue vbi_q; 615 struct saa7134_dmaqueue vbi_q;