V4L/DVB: ir-core: centralize sysfs raw decoder enabling/disabling

With the current logic, each raw decoder needs to add a copy of the exact
same sysfs code. This is both unnecessary and also means that (re)loading
an IR driver after raw decoder modules have been loaded won't work as
expected.

This patch moves that logic into ir-raw-event and adds a single sysfs
file per device.

Reading that file returns something like:

	"rc5 [rc6] nec jvc [sony]"

(with enabled protocols in [] brackets)

Writing either "+protocol" or "-protocol" to that file will
enable or disable the according protocol decoder.

An additional benefit is that the disabling of a decoder will be
remembered across module removal/insertion so a previously
disabled decoder won't suddenly be activated again. The default
setting is to enable all decoders.

This is also necessary for the next patch which moves even more decoder
state into the central raw decoding structs.

Signed-off-by: David Härdeman <david@hardeman.nu>
Acked-by: Jarod Wilson <jarod@redhat.com>
Tested-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

1 files changed, 4 insertions, 63 deletions

diff --git a/drivers/media/IR/ir-rc5-decoder.c b/drivers/media/IR/ir-rc5-decoder.c
index 4aa797bc69fd..bdfa404a6537 100644
--- a/drivers/media/IR/ir-rc5-decoder.c
+++ b/drivers/media/IR/ir-rc5-decoder.c
@@ -45,7 +45,6 @@ enum rc5_state {
 struct decoder_data {
         struct list_head        list;
         struct ir_input_dev     *ir_dev;
-        int                     enabled:1;
 
         /* State machine control */
         enum rc5_state          state;
@@ -76,53 +75,6 @@ static struct decoder_data *get_decoder_data(struct  ir_input_dev *ir_dev)
         return data;
 }
 
-static ssize_t store_enabled(struct device *d,
-                             struct device_attribute *mattr,
-                             const char *buf,
-                             size_t len)
-{
-        unsigned long value;
-        struct ir_input_dev *ir_dev = dev_get_drvdata(d);
-        struct decoder_data *data = get_decoder_data(ir_dev);
-
-        if (!data)
-                return -EINVAL;
-
-        if (strict_strtoul(buf, 10, &value) || value > 1)
-                return -EINVAL;
-
-        data->enabled = value;
-
-        return len;
-}
-
-static ssize_t show_enabled(struct device *d,
-                             struct device_attribute *mattr, char *buf)
-{
-        struct ir_input_dev *ir_dev = dev_get_drvdata(d);
-        struct decoder_data *data = get_decoder_data(ir_dev);
-
-        if (!data)
-                return -EINVAL;
-
-        if (data->enabled)
-                return sprintf(buf, "1\n");
-        else
-        return sprintf(buf, "0\n");
-}
-
-static DEVICE_ATTR(enabled, S_IRUGO | S_IWUSR, show_enabled, store_enabled);
-
-static struct attribute *decoder_attributes[] = {
-        &dev_attr_enabled.attr,
-        NULL
-};
-
-static struct attribute_group decoder_attribute_group = {
-        .name   = "rc5_decoder",
-        .attrs  = decoder_attributes,
-};
-
 /**
  * ir_rc5_decode() - Decode one RC-5 pulse or space
  * @input_dev:  the struct input_dev descriptor of the device
@@ -141,8 +93,8 @@ static int ir_rc5_decode(struct input_dev *input_dev, struct ir_raw_event ev)
         if (!data)
                 return -EINVAL;
 
-        if (!data->enabled)
-                return 0;
+        if (!(ir_dev->raw->enabled_protocols & IR_TYPE_RC5))
+                return 0;
 
         if (IS_RESET(ev)) {
                 data->state = STATE_INACTIVE;
@@ -256,22 +208,12 @@ static int ir_rc5_register(struct input_dev *input_dev)
 {
         struct ir_input_dev *ir_dev = input_get_drvdata(input_dev);
         struct decoder_data *data;
-        u64 ir_type = ir_dev->rc_tab.ir_type;
-        int rc;
-
-        rc = sysfs_create_group(&ir_dev->dev.kobj, &decoder_attribute_group);
-        if (rc < 0)
-                return rc;
 
         data = kzalloc(sizeof(*data), GFP_KERNEL);
-        if (!data) {
-                sysfs_remove_group(&ir_dev->dev.kobj, &decoder_attribute_group);
+        if (!data)
                 return -ENOMEM;
-        }
 
         data->ir_dev = ir_dev;
-        if (ir_type == IR_TYPE_RC5 || ir_type == IR_TYPE_UNKNOWN)
-                data->enabled = 1;
 
         spin_lock(&decoder_lock);
         list_add_tail(&data->list, &decoder_list);
@@ -289,8 +231,6 @@ static int ir_rc5_unregister(struct input_dev *input_dev)
         if (!data)
                 return 0;
 
-        sysfs_remove_group(&ir_dev->dev.kobj, &decoder_attribute_group);
-
         spin_lock(&decoder_lock);
         list_del(&data->list);
         spin_unlock(&decoder_lock);
@@ -299,6 +239,7 @@ static int ir_rc5_unregister(struct input_dev *input_dev)
 }
 
 static struct ir_raw_handler rc5_handler = {
+        .protocols      = IR_TYPE_RC5,
         .decode         = ir_rc5_decode,
         .raw_register   = ir_rc5_register,
         .raw_unregister = ir_rc5_unregister,