aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/md/raid1.c
diff options
context:
space:
mode:
authorShaohua Li <shli@fb.com>2016-12-08 18:48:17 -0500
committerShaohua Li <shli@fb.com>2016-12-09 01:00:11 -0500
commit6995f0b247e15e34fbcd10852c08b30bdc1a78da (patch)
treecf269278686e1ace761edded6fe4e7ae64417920 /drivers/md/raid1.c
parent3c6edc66085e1d895a698c572bbfaf4d57fdb771 (diff)
md: takeover should clear unrelated bits
When we change level from raid1 to raid5, the MD_FAILFAST_SUPPORTED bit will be accidentally set, but raid5 doesn't support it. The same is true for the MD_HAS_JOURNAL bit. Fix: 46533ff (md: Use REQ_FAILFAST_* on metadata writes where appropriate) Reviewed-by: NeilBrown <neilb@suse.com> Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'drivers/md/raid1.c')
-rw-r--r--drivers/md/raid1.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 94e0afce6d4c..efc2e744cfd3 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -3243,9 +3243,12 @@ static void *raid1_takeover(struct mddev *mddev)
3243 mddev->new_layout = 0; 3243 mddev->new_layout = 0;
3244 mddev->new_chunk_sectors = 0; 3244 mddev->new_chunk_sectors = 0;
3245 conf = setup_conf(mddev); 3245 conf = setup_conf(mddev);
3246 if (!IS_ERR(conf)) 3246 if (!IS_ERR(conf)) {
3247 /* Array must appear to be quiesced */ 3247 /* Array must appear to be quiesced */
3248 conf->array_frozen = 1; 3248 conf->array_frozen = 1;
3249 clear_bit(MD_HAS_JOURNAL, &mddev->flags);
3250 clear_bit(MD_JOURNAL_CLEAN, &mddev->flags);
3251 }
3249 return conf; 3252 return conf;
3250 } 3253 }
3251 return ERR_PTR(-EINVAL); 3254 return ERR_PTR(-EINVAL);