diff options
author | NeilBrown <neilb@suse.com> | 2016-06-02 02:19:52 -0400 |
---|---|---|
committer | Shaohua Li <shli@fb.com> | 2016-06-13 14:54:21 -0400 |
commit | 40cf2123c57928c3ec0626c49bef97ebdbce008e (patch) | |
tree | 0583f446c659c85f627d447f978a017a67bacf83 /drivers/md/multipath.c | |
parent | 5fd133511d5f2a9167573d100e14fddd9c621581 (diff) |
md/multipath: add rcu protection to rdev access in multipath_status.
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'drivers/md/multipath.c')
-rw-r--r-- | drivers/md/multipath.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/drivers/md/multipath.c b/drivers/md/multipath.c index dd483bb2e111..69244de2036b 100644 --- a/drivers/md/multipath.c +++ b/drivers/md/multipath.c | |||
@@ -141,17 +141,19 @@ static void multipath_make_request(struct mddev *mddev, struct bio * bio) | |||
141 | return; | 141 | return; |
142 | } | 142 | } |
143 | 143 | ||
144 | static void multipath_status (struct seq_file *seq, struct mddev *mddev) | 144 | static void multipath_status(struct seq_file *seq, struct mddev *mddev) |
145 | { | 145 | { |
146 | struct mpconf *conf = mddev->private; | 146 | struct mpconf *conf = mddev->private; |
147 | int i; | 147 | int i; |
148 | 148 | ||
149 | seq_printf (seq, " [%d/%d] [", conf->raid_disks, | 149 | seq_printf (seq, " [%d/%d] [", conf->raid_disks, |
150 | conf->raid_disks - mddev->degraded); | 150 | conf->raid_disks - mddev->degraded); |
151 | for (i = 0; i < conf->raid_disks; i++) | 151 | rcu_read_lock(); |
152 | seq_printf (seq, "%s", | 152 | for (i = 0; i < conf->raid_disks; i++) { |
153 | conf->multipaths[i].rdev && | 153 | struct md_rdev *rdev = rcu_dereference(conf->multipaths[i].rdev); |
154 | test_bit(In_sync, &conf->multipaths[i].rdev->flags) ? "U" : "_"); | 154 | seq_printf (seq, "%s", rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); |
155 | } | ||
156 | rcu_read_unlock(); | ||
155 | seq_printf (seq, "]"); | 157 | seq_printf (seq, "]"); |
156 | } | 158 | } |
157 | 159 | ||