diff options
author | Mike Snitzer <snitzer@redhat.com> | 2016-06-02 12:06:54 -0400 |
---|---|---|
committer | Mike Snitzer <snitzer@redhat.com> | 2016-06-14 17:24:59 -0400 |
commit | bb91a63fcc58d5a992fe5e92c6ff1e7f4d20664e (patch) | |
tree | e2b6e86bbeb50efc84081296d4331bcabb42463c /drivers/md/dm-raid.c | |
parent | ef9b85a651d4f09c36867c6666ea4086440d89a0 (diff) |
dm raid: rename _in_range to __within_range
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md/dm-raid.c')
-rw-r--r-- | drivers/md/dm-raid.c | 28 |
1 files changed, 14 insertions, 14 deletions
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 02c07a75e4dc..039db81c9d53 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c | |||
@@ -244,7 +244,7 @@ static struct raid_type { | |||
244 | }; | 244 | }; |
245 | 245 | ||
246 | /* True, if @v is in inclusive range [@min, @max] */ | 246 | /* True, if @v is in inclusive range [@min, @max] */ |
247 | static bool _in_range(long v, long min, long max) | 247 | static bool __within_range(long v, long min, long max) |
248 | { | 248 | { |
249 | return v >= min && v <= max; | 249 | return v >= min && v <= max; |
250 | } | 250 | } |
@@ -385,7 +385,7 @@ static bool rt_is_raid10(struct raid_type *rt) | |||
385 | /* Return true, if raid type in @rt is raid4/5 */ | 385 | /* Return true, if raid type in @rt is raid4/5 */ |
386 | static bool rt_is_raid45(struct raid_type *rt) | 386 | static bool rt_is_raid45(struct raid_type *rt) |
387 | { | 387 | { |
388 | return _in_range(rt->level, 4, 5); | 388 | return __within_range(rt->level, 4, 5); |
389 | } | 389 | } |
390 | 390 | ||
391 | /* Return true, if raid type in @rt is raid6 */ | 391 | /* Return true, if raid type in @rt is raid6 */ |
@@ -397,7 +397,7 @@ static bool rt_is_raid6(struct raid_type *rt) | |||
397 | /* Return true, if raid type in @rt is raid4/5/6 */ | 397 | /* Return true, if raid type in @rt is raid4/5/6 */ |
398 | static bool rt_is_raid456(struct raid_type *rt) | 398 | static bool rt_is_raid456(struct raid_type *rt) |
399 | { | 399 | { |
400 | return _in_range(rt->level, 4, 6); | 400 | return __within_range(rt->level, 4, 6); |
401 | } | 401 | } |
402 | /* END: raid level bools */ | 402 | /* END: raid level bools */ |
403 | 403 | ||
@@ -1123,7 +1123,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as, | |||
1123 | * indexes of replaced devices and to set up additional | 1123 | * indexes of replaced devices and to set up additional |
1124 | * devices on raid level takeover. | 1124 | * devices on raid level takeover. |
1125 | */ | 1125 | */ |
1126 | if (!_in_range(value, 0, rs->raid_disks - 1)) { | 1126 | if (!__within_range(value, 0, rs->raid_disks - 1)) { |
1127 | rs->ti->error = "Invalid rebuild index given"; | 1127 | rs->ti->error = "Invalid rebuild index given"; |
1128 | return -EINVAL; | 1128 | return -EINVAL; |
1129 | } | 1129 | } |
@@ -1144,7 +1144,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as, | |||
1144 | return -EINVAL; | 1144 | return -EINVAL; |
1145 | } | 1145 | } |
1146 | 1146 | ||
1147 | if (!_in_range(value, 0, rs->md.raid_disks - 1)) { | 1147 | if (!__within_range(value, 0, rs->md.raid_disks - 1)) { |
1148 | rs->ti->error = "Invalid write_mostly index given"; | 1148 | rs->ti->error = "Invalid write_mostly index given"; |
1149 | return -EINVAL; | 1149 | return -EINVAL; |
1150 | } | 1150 | } |
@@ -1202,7 +1202,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as, | |||
1202 | return -EINVAL; | 1202 | return -EINVAL; |
1203 | } | 1203 | } |
1204 | /* Ensure MAX_RAID_DEVICES and raid type minimal_devs! */ | 1204 | /* Ensure MAX_RAID_DEVICES and raid type minimal_devs! */ |
1205 | if (!_in_range(abs(value), 1, MAX_RAID_DEVICES - rt->minimal_devs)) { | 1205 | if (!__within_range(abs(value), 1, MAX_RAID_DEVICES - rt->minimal_devs)) { |
1206 | rs->ti->error = "Too many delta_disk requested"; | 1206 | rs->ti->error = "Too many delta_disk requested"; |
1207 | return -EINVAL; | 1207 | return -EINVAL; |
1208 | } | 1208 | } |
@@ -1262,7 +1262,7 @@ static int parse_raid_params(struct raid_set *rs, struct dm_arg_set *as, | |||
1262 | return -EINVAL; | 1262 | return -EINVAL; |
1263 | } | 1263 | } |
1264 | 1264 | ||
1265 | if (!_in_range(value, 2, rs->md.raid_disks)) { | 1265 | if (!__within_range(value, 2, rs->md.raid_disks)) { |
1266 | rs->ti->error = "Bad value for 'raid10_copies'"; | 1266 | rs->ti->error = "Bad value for 'raid10_copies'"; |
1267 | return -EINVAL; | 1267 | return -EINVAL; |
1268 | } | 1268 | } |
@@ -1380,7 +1380,7 @@ static int rs_check_takeover(struct raid_set *rs) | |||
1380 | return 0; | 1380 | return 0; |
1381 | 1381 | ||
1382 | /* raid0 with multiple disks -> raid4/5/6 */ | 1382 | /* raid0 with multiple disks -> raid4/5/6 */ |
1383 | if (_in_range(mddev->new_level, 4, 6) && | 1383 | if (__within_range(mddev->new_level, 4, 6) && |
1384 | mddev->new_layout == ALGORITHM_PARITY_N && | 1384 | mddev->new_layout == ALGORITHM_PARITY_N && |
1385 | mddev->raid_disks > 1) | 1385 | mddev->raid_disks > 1) |
1386 | return 0; | 1386 | return 0; |
@@ -1418,14 +1418,14 @@ static int rs_check_takeover(struct raid_set *rs) | |||
1418 | return 0; | 1418 | return 0; |
1419 | 1419 | ||
1420 | /* raid10_{near,far} with 2 disks -> raid4/5 */ | 1420 | /* raid10_{near,far} with 2 disks -> raid4/5 */ |
1421 | if (_in_range(mddev->new_level, 4, 5) && | 1421 | if (__within_range(mddev->new_level, 4, 5) && |
1422 | mddev->raid_disks == 2) | 1422 | mddev->raid_disks == 2) |
1423 | return 0; | 1423 | return 0; |
1424 | break; | 1424 | break; |
1425 | 1425 | ||
1426 | case 1: | 1426 | case 1: |
1427 | /* raid1 with 2 disks -> raid4/5 */ | 1427 | /* raid1 with 2 disks -> raid4/5 */ |
1428 | if (_in_range(mddev->new_level, 4, 5) && | 1428 | if (__within_range(mddev->new_level, 4, 5) && |
1429 | mddev->raid_disks == 2) { | 1429 | mddev->raid_disks == 2) { |
1430 | mddev->degraded = 1; | 1430 | mddev->degraded = 1; |
1431 | return 0; | 1431 | return 0; |
@@ -1453,7 +1453,7 @@ static int rs_check_takeover(struct raid_set *rs) | |||
1453 | return 0; | 1453 | return 0; |
1454 | 1454 | ||
1455 | /* raid4 -> raid5/6 with parity N */ | 1455 | /* raid4 -> raid5/6 with parity N */ |
1456 | if (_in_range(mddev->new_level, 5, 6) && | 1456 | if (__within_range(mddev->new_level, 5, 6) && |
1457 | mddev->layout == ALGORITHM_PARITY_N) | 1457 | mddev->layout == ALGORITHM_PARITY_N) |
1458 | return 0; | 1458 | return 0; |
1459 | break; | 1459 | break; |
@@ -1477,7 +1477,7 @@ static int rs_check_takeover(struct raid_set *rs) | |||
1477 | /* raid5 with parity N -> raid6 with parity N */ | 1477 | /* raid5 with parity N -> raid6 with parity N */ |
1478 | if (mddev->new_level == 6 && | 1478 | if (mddev->new_level == 6 && |
1479 | ((mddev->layout == ALGORITHM_PARITY_N && mddev->new_layout == ALGORITHM_PARITY_N) || | 1479 | ((mddev->layout == ALGORITHM_PARITY_N && mddev->new_layout == ALGORITHM_PARITY_N) || |
1480 | _in_range(mddev->new_layout, ALGORITHM_LEFT_ASYMMETRIC_6, ALGORITHM_RIGHT_SYMMETRIC_6))) | 1480 | __within_range(mddev->new_layout, ALGORITHM_LEFT_ASYMMETRIC_6, ALGORITHM_RIGHT_SYMMETRIC_6))) |
1481 | return 0; | 1481 | return 0; |
1482 | break; | 1482 | break; |
1483 | 1483 | ||
@@ -1495,7 +1495,7 @@ static int rs_check_takeover(struct raid_set *rs) | |||
1495 | /* raid6_*_n with parity N -> raid5_* */ | 1495 | /* raid6_*_n with parity N -> raid5_* */ |
1496 | if (mddev->new_level == 5 && | 1496 | if (mddev->new_level == 5 && |
1497 | ((mddev->layout == ALGORITHM_PARITY_N && mddev->new_layout == ALGORITHM_PARITY_N) || | 1497 | ((mddev->layout == ALGORITHM_PARITY_N && mddev->new_layout == ALGORITHM_PARITY_N) || |
1498 | _in_range(mddev->new_layout, ALGORITHM_LEFT_ASYMMETRIC, ALGORITHM_RIGHT_SYMMETRIC))) | 1498 | __within_range(mddev->new_layout, ALGORITHM_LEFT_ASYMMETRIC, ALGORITHM_RIGHT_SYMMETRIC))) |
1499 | return 0; | 1499 | return 0; |
1500 | 1500 | ||
1501 | default: | 1501 | default: |
@@ -2291,7 +2291,7 @@ static int raid_ctr(struct dm_target *ti, unsigned argc, char **argv) | |||
2291 | if (dm_read_arg(_args + 1, &as_nrd, &num_raid_devs, &ti->error)) | 2291 | if (dm_read_arg(_args + 1, &as_nrd, &num_raid_devs, &ti->error)) |
2292 | return -EINVAL; | 2292 | return -EINVAL; |
2293 | 2293 | ||
2294 | if (!_in_range(num_raid_devs, 1, MAX_RAID_DEVICES)) { | 2294 | if (!__within_range(num_raid_devs, 1, MAX_RAID_DEVICES)) { |
2295 | ti->error = "Invalid number of supplied raid devices"; | 2295 | ti->error = "Invalid number of supplied raid devices"; |
2296 | return -EINVAL; | 2296 | return -EINVAL; |
2297 | } | 2297 | } |