bcache: add io_disable to struct cached_dev

If a bcache device is configured to writeback mode, current code does not
handle write I/O errors on backing devices properly.

In writeback mode, write request is written to cache device, and
latter being flushed to backing device. If I/O failed when writing from
cache device to the backing device, bcache code just ignores the error and
upper layer code is NOT noticed that the backing device is broken.

This patch tries to handle backing device failure like how the cache device
failure is handled,
- Add a error counter 'io_errors' and error limit 'error_limit' in struct
  cached_dev. Add another io_disable to struct cached_dev to disable I/Os
  on the problematic backing device.
- When I/O error happens on backing device, increase io_errors counter. And
  if io_errors reaches error_limit, set cache_dev->io_disable to true, and
  stop the bcache device.

The result is, if backing device is broken of disconnected, and I/O errors
reach its error limit, backing device will be disabled and the associated
bcache device will be removed from system.

Changelog:
v2: remove "bcache: " prefix in pr_error(), and use correct name string to
    print out bcache device gendisk name.
v1: indeed this is new added in v2 patch set.

Signed-off-by: Coly Li <colyli@suse.de>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Michael Lyle <mlyle@lyle.org>
Cc: Michael Lyle <mlyle@lyle.org>
Cc: Junhui Tang <tang.junhui@zte.com.cn>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

1 files changed, 12 insertions, 2 deletions

diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index b4a5768afbe9..5a82237c7025 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -637,6 +637,8 @@ static void backing_request_endio(struct bio *bio)
 
         if (bio->bi_status) {
                 struct search *s = container_of(cl, struct search, cl);
+                struct cached_dev *dc = container_of(s->d,
+                                                     struct cached_dev, disk);
                 /*
                  * If a bio has REQ_PREFLUSH for writeback mode, it is
                  * speically assembled in cached_dev_write() for a non-zero
@@ -657,6 +659,7 @@ static void backing_request_endio(struct bio *bio)
                 }
                 s->recoverable = false;
                 /* should count I/O error for backing device here */
+                bch_count_backing_io_errors(dc, bio);
         }
 
         bio_put(bio);
@@ -1065,8 +1068,14 @@ static void detached_dev_end_io(struct bio *bio)
                             bio_data_dir(bio),
                             &ddip->d->disk->part0, ddip->start_time);
 
-        kfree(ddip);
+        if (bio->bi_status) {
+                struct cached_dev *dc = container_of(ddip->d,
+                                                     struct cached_dev, disk);
+                /* should count I/O error for backing device here */
+                bch_count_backing_io_errors(dc, bio);
+        }
 
+        kfree(ddip);
         bio->bi_end_io(bio);
 }
 
@@ -1105,7 +1114,8 @@ static blk_qc_t cached_dev_make_request(struct request_queue *q,
         struct cached_dev *dc = container_of(d, struct cached_dev, disk);
         int rw = bio_data_dir(bio);
 
-        if (unlikely(d->c && test_bit(CACHE_SET_IO_DISABLE, &d->c->flags))) {
+        if (unlikely((d->c && test_bit(CACHE_SET_IO_DISABLE, &d->c->flags)) ||
+                     dc->io_disable)) {
                 bio->bi_status = BLK_STS_IOERR;
                 bio_endio(bio);
                 return BLK_QC_T_NONE;