aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/macintosh
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-06-06 08:17:12 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-06-09 05:00:46 -0400
commit60bb70aa761ca4090a718926f8299364a0c61ae0 (patch)
treedf81e3133fb8c97860ac9ebf64438198d16b92d6 /drivers/macintosh
parent9f4ac349bd60ef463450a00aa5e19c67f5ad12e2 (diff)
macintosh: use dev_groups and not dev_attrs for bus_type
The dev_attrs field has long been "depreciated" and is finally being removed, so move the driver to use the "correct" dev_groups field instead for struct bus_type. Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: <linuxppc-dev@lists.ozlabs.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/macintosh')
-rw-r--r--drivers/macintosh/macio_asic.c4
-rw-r--r--drivers/macintosh/macio_sysfs.c29
2 files changed, 23 insertions, 10 deletions
diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c
index f757cef293f8..62f541f968f6 100644
--- a/drivers/macintosh/macio_asic.c
+++ b/drivers/macintosh/macio_asic.c
@@ -133,7 +133,7 @@ static int macio_device_resume(struct device * dev)
133 return 0; 133 return 0;
134} 134}
135 135
136extern struct device_attribute macio_dev_attrs[]; 136extern const struct attribute_group *macio_dev_groups[];
137 137
138struct bus_type macio_bus_type = { 138struct bus_type macio_bus_type = {
139 .name = "macio", 139 .name = "macio",
@@ -144,7 +144,7 @@ struct bus_type macio_bus_type = {
144 .shutdown = macio_device_shutdown, 144 .shutdown = macio_device_shutdown,
145 .suspend = macio_device_suspend, 145 .suspend = macio_device_suspend,
146 .resume = macio_device_resume, 146 .resume = macio_device_resume,
147 .dev_attrs = macio_dev_attrs, 147 .dev_groups = macio_dev_groups,
148}; 148};
149 149
150static int __init macio_bus_driver_init(void) 150static int __init macio_bus_driver_init(void)
diff --git a/drivers/macintosh/macio_sysfs.c b/drivers/macintosh/macio_sysfs.c
index 0b1f9c76c68d..2445274f7e4b 100644
--- a/drivers/macintosh/macio_sysfs.c
+++ b/drivers/macintosh/macio_sysfs.c
@@ -10,7 +10,8 @@ field##_show (struct device *dev, struct device_attribute *attr, \
10{ \ 10{ \
11 struct macio_dev *mdev = to_macio_device (dev); \ 11 struct macio_dev *mdev = to_macio_device (dev); \
12 return sprintf (buf, format_string, mdev->ofdev.dev.of_node->field); \ 12 return sprintf (buf, format_string, mdev->ofdev.dev.of_node->field); \
13} 13} \
14static DEVICE_ATTR_RO(field);
14 15
15static ssize_t 16static ssize_t
16compatible_show (struct device *dev, struct device_attribute *attr, char *buf) 17compatible_show (struct device *dev, struct device_attribute *attr, char *buf)
@@ -37,6 +38,7 @@ compatible_show (struct device *dev, struct device_attribute *attr, char *buf)
37 38
38 return length; 39 return length;
39} 40}
41static DEVICE_ATTR_RO(compatible);
40 42
41static ssize_t modalias_show (struct device *dev, struct device_attribute *attr, 43static ssize_t modalias_show (struct device *dev, struct device_attribute *attr,
42 char *buf) 44 char *buf)
@@ -52,15 +54,26 @@ static ssize_t devspec_show(struct device *dev,
52 ofdev = to_platform_device(dev); 54 ofdev = to_platform_device(dev);
53 return sprintf(buf, "%s\n", ofdev->dev.of_node->full_name); 55 return sprintf(buf, "%s\n", ofdev->dev.of_node->full_name);
54} 56}
57static DEVICE_ATTR_RO(modalias);
58static DEVICE_ATTR_RO(devspec);
55 59
56macio_config_of_attr (name, "%s\n"); 60macio_config_of_attr (name, "%s\n");
57macio_config_of_attr (type, "%s\n"); 61macio_config_of_attr (type, "%s\n");
58 62
59struct device_attribute macio_dev_attrs[] = { 63static struct attribute *macio_dev_attrs[] = {
60 __ATTR_RO(name), 64 &dev_attr_name.attr,
61 __ATTR_RO(type), 65 &dev_attr_type.attr,
62 __ATTR_RO(compatible), 66 &dev_attr_compatible.attr,
63 __ATTR_RO(modalias), 67 &dev_attr_modalias.attr,
64 __ATTR_RO(devspec), 68 &dev_attr_devspec.attr,
65 __ATTR_NULL 69 NULL,
70};
71
72static const struct attribute_group macio_dev_group = {
73 .attrs = macio_dev_attrs,
74};
75
76const struct attribute_group *macio_dev_groups[] = {
77 &macio_dev_group,
78 NULL,
66}; 79};