lightnvm: pblk: fix error path in pblk_lines_alloc_metadata

Use appropriate memory free calls based on allocation type used and
also fix number of times free is called if kmalloc fails.

Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
Reviewed-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

1 files changed, 4 insertions, 1 deletions

diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 6df65d14a2c5..05665a7e648c 100644
--- a/drivers/lightnvm/pblk-init.c
+++ b/drivers/lightnvm/pblk-init.c
@@ -630,7 +630,10 @@ static int pblk_lines_alloc_metadata(struct pblk *pblk)
 
 fail_free_emeta:
         while (--i >= 0) {
-                vfree(l_mg->eline_meta[i]->buf);
+                if (l_mg->emeta_alloc_type == PBLK_VMALLOC_META)
+                        vfree(l_mg->eline_meta[i]->buf);
+                else
+                        kfree(l_mg->eline_meta[i]->buf);
                 kfree(l_mg->eline_meta[i]);
         }