diff options
author | Javier González <javier@cnexlabs.com> | 2018-03-29 18:05:14 -0400 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2018-03-29 19:29:09 -0400 |
commit | a40afad90b9a253b282183eb9365f1cc14aeff77 (patch) | |
tree | 7285af81f7c740fadea5d58383114bd20ca86d58 /drivers/lightnvm/pblk-init.c | |
parent | 3f48021bad73696421e2725c856b9b3aec7f567c (diff) |
lightnvm: normalize geometry nomenclature
Normalize nomenclature for naming channels, luns, chunks, planes and
sectors as well as derivations in order to improve readability.
Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/lightnvm/pblk-init.c')
-rw-r--r-- | drivers/lightnvm/pblk-init.c | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c index 2fca27d0a9b5..4656d1ff81a6 100644 --- a/drivers/lightnvm/pblk-init.c +++ b/drivers/lightnvm/pblk-init.c | |||
@@ -193,15 +193,15 @@ static int pblk_set_addrf_12(struct nvm_geo *geo, struct nvm_addrf_12 *dst) | |||
193 | int power_len; | 193 | int power_len; |
194 | 194 | ||
195 | /* Re-calculate channel and lun format to adapt to configuration */ | 195 | /* Re-calculate channel and lun format to adapt to configuration */ |
196 | power_len = get_count_order(geo->nr_chnls); | 196 | power_len = get_count_order(geo->num_ch); |
197 | if (1 << power_len != geo->nr_chnls) { | 197 | if (1 << power_len != geo->num_ch) { |
198 | pr_err("pblk: supports only power-of-two channel config.\n"); | 198 | pr_err("pblk: supports only power-of-two channel config.\n"); |
199 | return -EINVAL; | 199 | return -EINVAL; |
200 | } | 200 | } |
201 | dst->ch_len = power_len; | 201 | dst->ch_len = power_len; |
202 | 202 | ||
203 | power_len = get_count_order(geo->nr_luns); | 203 | power_len = get_count_order(geo->num_lun); |
204 | if (1 << power_len != geo->nr_luns) { | 204 | if (1 << power_len != geo->num_lun) { |
205 | pr_err("pblk: supports only power-of-two LUN config.\n"); | 205 | pr_err("pblk: supports only power-of-two LUN config.\n"); |
206 | return -EINVAL; | 206 | return -EINVAL; |
207 | } | 207 | } |
@@ -210,16 +210,16 @@ static int pblk_set_addrf_12(struct nvm_geo *geo, struct nvm_addrf_12 *dst) | |||
210 | dst->blk_len = src->blk_len; | 210 | dst->blk_len = src->blk_len; |
211 | dst->pg_len = src->pg_len; | 211 | dst->pg_len = src->pg_len; |
212 | dst->pln_len = src->pln_len; | 212 | dst->pln_len = src->pln_len; |
213 | dst->sect_len = src->sect_len; | 213 | dst->sec_len = src->sec_len; |
214 | 214 | ||
215 | dst->sect_offset = 0; | 215 | dst->sec_offset = 0; |
216 | dst->pln_offset = dst->sect_len; | 216 | dst->pln_offset = dst->sec_len; |
217 | dst->ch_offset = dst->pln_offset + dst->pln_len; | 217 | dst->ch_offset = dst->pln_offset + dst->pln_len; |
218 | dst->lun_offset = dst->ch_offset + dst->ch_len; | 218 | dst->lun_offset = dst->ch_offset + dst->ch_len; |
219 | dst->pg_offset = dst->lun_offset + dst->lun_len; | 219 | dst->pg_offset = dst->lun_offset + dst->lun_len; |
220 | dst->blk_offset = dst->pg_offset + dst->pg_len; | 220 | dst->blk_offset = dst->pg_offset + dst->pg_len; |
221 | 221 | ||
222 | dst->sec_mask = ((1ULL << dst->sect_len) - 1) << dst->sect_offset; | 222 | dst->sec_mask = ((1ULL << dst->sec_len) - 1) << dst->sec_offset; |
223 | dst->pln_mask = ((1ULL << dst->pln_len) - 1) << dst->pln_offset; | 223 | dst->pln_mask = ((1ULL << dst->pln_len) - 1) << dst->pln_offset; |
224 | dst->ch_mask = ((1ULL << dst->ch_len) - 1) << dst->ch_offset; | 224 | dst->ch_mask = ((1ULL << dst->ch_len) - 1) << dst->ch_offset; |
225 | dst->lun_mask = ((1ULL << dst->lun_len) - 1) << dst->lun_offset; | 225 | dst->lun_mask = ((1ULL << dst->lun_len) - 1) << dst->lun_offset; |
@@ -503,7 +503,7 @@ static void *pblk_bb_get_log(struct pblk *pblk) | |||
503 | int i, nr_blks, blk_per_lun; | 503 | int i, nr_blks, blk_per_lun; |
504 | int ret; | 504 | int ret; |
505 | 505 | ||
506 | blk_per_lun = geo->nr_chks * geo->plane_mode; | 506 | blk_per_lun = geo->num_chk * geo->pln_mode; |
507 | nr_blks = blk_per_lun * geo->all_luns; | 507 | nr_blks = blk_per_lun * geo->all_luns; |
508 | 508 | ||
509 | log = kmalloc(nr_blks, GFP_KERNEL); | 509 | log = kmalloc(nr_blks, GFP_KERNEL); |
@@ -530,7 +530,7 @@ static int pblk_bb_line(struct pblk *pblk, struct pblk_line *line, | |||
530 | struct nvm_tgt_dev *dev = pblk->dev; | 530 | struct nvm_tgt_dev *dev = pblk->dev; |
531 | struct nvm_geo *geo = &dev->geo; | 531 | struct nvm_geo *geo = &dev->geo; |
532 | int i, bb_cnt = 0; | 532 | int i, bb_cnt = 0; |
533 | int blk_per_lun = geo->nr_chks * geo->plane_mode; | 533 | int blk_per_lun = geo->num_chk * geo->pln_mode; |
534 | 534 | ||
535 | for (i = 0; i < blk_per_line; i++) { | 535 | for (i = 0; i < blk_per_line; i++) { |
536 | struct pblk_lun *rlun = &pblk->luns[i]; | 536 | struct pblk_lun *rlun = &pblk->luns[i]; |
@@ -554,7 +554,7 @@ static int pblk_luns_init(struct pblk *pblk) | |||
554 | int i; | 554 | int i; |
555 | 555 | ||
556 | /* TODO: Implement unbalanced LUN support */ | 556 | /* TODO: Implement unbalanced LUN support */ |
557 | if (geo->nr_luns < 0) { | 557 | if (geo->num_lun < 0) { |
558 | pr_err("pblk: unbalanced LUN config.\n"); | 558 | pr_err("pblk: unbalanced LUN config.\n"); |
559 | return -EINVAL; | 559 | return -EINVAL; |
560 | } | 560 | } |
@@ -566,9 +566,9 @@ static int pblk_luns_init(struct pblk *pblk) | |||
566 | 566 | ||
567 | for (i = 0; i < geo->all_luns; i++) { | 567 | for (i = 0; i < geo->all_luns; i++) { |
568 | /* Stripe across channels */ | 568 | /* Stripe across channels */ |
569 | int ch = i % geo->nr_chnls; | 569 | int ch = i % geo->num_ch; |
570 | int lun_raw = i / geo->nr_chnls; | 570 | int lun_raw = i / geo->num_ch; |
571 | int lunid = lun_raw + ch * geo->nr_luns; | 571 | int lunid = lun_raw + ch * geo->num_lun; |
572 | 572 | ||
573 | rlun = &pblk->luns[i]; | 573 | rlun = &pblk->luns[i]; |
574 | rlun->bppa = dev->luns[lunid]; | 574 | rlun->bppa = dev->luns[lunid]; |
@@ -672,7 +672,7 @@ static int pblk_line_mg_init(struct pblk *pblk) | |||
672 | struct pblk_line_meta *lm = &pblk->lm; | 672 | struct pblk_line_meta *lm = &pblk->lm; |
673 | int i, bb_distance; | 673 | int i, bb_distance; |
674 | 674 | ||
675 | l_mg->nr_lines = geo->nr_chks; | 675 | l_mg->nr_lines = geo->num_chk; |
676 | l_mg->log_line = l_mg->data_line = NULL; | 676 | l_mg->log_line = l_mg->data_line = NULL; |
677 | l_mg->l_seq_nr = l_mg->d_seq_nr = 0; | 677 | l_mg->l_seq_nr = l_mg->d_seq_nr = 0; |
678 | l_mg->nr_free_lines = 0; | 678 | l_mg->nr_free_lines = 0; |