diff options
| author | Rakesh Pandit <rakesh@tuxera.com> | 2017-10-13 08:45:58 -0400 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2017-10-13 10:34:57 -0400 |
| commit | c5493845b7b303315118fb4ab96654bf7cb897f0 (patch) | |
| tree | 2136b2ed437d830fb34ba9760777db34ec275f56 /drivers/lightnvm/pblk-core.c | |
| parent | 4e76af53e132bff9e2b94f018457fadabf5ab419 (diff) | |
lightnvm: pblk: improve error message if down_timeout fails
The two pr_err messages are useless as they don't differentiate
error code.
Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
Reviewed-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/lightnvm/pblk-core.c')
| -rw-r--r-- | drivers/lightnvm/pblk-core.c | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c index b53bb00a9918..027c42bb1ab9 100644 --- a/drivers/lightnvm/pblk-core.c +++ b/drivers/lightnvm/pblk-core.c | |||
| @@ -1691,16 +1691,8 @@ static void __pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, | |||
| 1691 | #endif | 1691 | #endif |
| 1692 | 1692 | ||
| 1693 | ret = down_timeout(&rlun->wr_sem, msecs_to_jiffies(30000)); | 1693 | ret = down_timeout(&rlun->wr_sem, msecs_to_jiffies(30000)); |
| 1694 | if (ret) { | 1694 | if (ret == -ETIME || ret == -EINTR) |
| 1695 | switch (ret) { | 1695 | pr_err("pblk: taking lun semaphore timed out: err %d\n", -ret); |
| 1696 | case -ETIME: | ||
| 1697 | pr_err("pblk: lun semaphore timed out\n"); | ||
| 1698 | break; | ||
| 1699 | case -EINTR: | ||
| 1700 | pr_err("pblk: lun semaphore timed out\n"); | ||
| 1701 | break; | ||
| 1702 | } | ||
| 1703 | } | ||
| 1704 | } | 1696 | } |
| 1705 | 1697 | ||
| 1706 | void pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas) | 1698 | void pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas) |